trent_larson/crowd-funder-for-time-pwa
4
1
Fork 2
Code Issues Pull Requests 22 Releases 5 Wiki Activity

Updates to contacts UI. Sweep for buildIdentity and buildHeaders #35

Merged
anomalist merged 7 commits from contacts-identity into master 2023-07-09 02:58:52 +00:00
Conversation 5 Commits 7 Files Changed 11 +395 -361
anomalist commented 2023-07-07 09:30:30 +00:00
Owner
Copy Link

@trentlarson I added a case to Contacts to show a message when no contacts. Also added a (no name) to the Home page since the buttons didn't cover that case.

Rest of this commit is a partial cleanup of identity and header creations. There's an edge case where it's checking for accounts which I didn't cover just yet.

@trentlarson I added a case to Contacts to show a message when no contacts. Also added a (no name) to the Home page since the buttons didn't cover that case. Rest of this commit is a partial cleanup of identity and header creations. There's an edge case where it's checking for accounts which I didn't cover just yet.
anomalist added 1 commit 2023-07-07 09:30:31 +00:00
Updates to contacts UI. Sweep for buildIdentity and buildHeaders 08137eb000
anomalist added 1 commit 2023-07-07 09:42:56 +00:00
Fix a bug in HomeView and clean up recordGive method dc23ba1375
anomalist added 1 commit 2023-07-07 11:33:26 +00:00
Project Task update 0fbdb45d3e
trentlarson requested changes 2023-07-08 01:26:49 +00:00
src/views/AccountViewView.vue Outdated
@@ -358,4 +381,1 @@
await accountsDB.open();
const accounts = await accountsDB.accounts.toArray();
this.numAccounts = accounts.length;
trentlarson commented 2023-07-08 01:24:46 +00:00
Owner
Copy Link

This cuts some extra code: in this case the "this.numAccounts" isn't set and so the "Switch Identifier" section does not show. (I looked for others and didn't see anything obvious but it's worth another look.)

This cuts some extra code: in this case the "this.numAccounts" isn't set and so the "Switch Identifier" section does not show. (I looked for others and didn't see anything obvious but it's worth another look.)
anomalist commented 2023-07-08 08:13:36 +00:00
Author
Owner
Copy Link

@trentlarson going to push something after this message. I did a little thinking and approach this in a different way.

@trentlarson going to push something after this message. I did a little thinking and approach this in a different way.
anomalist marked this conversation as resolved
trentlarson reviewed 2023-07-08 01:33:28 +00:00
src/views/ContactQRScanShowView.vue
@@ -53,0 +58,4 @@
if (!identity) {
throw new Error(
"Attempted to load Give records with no identity available.",
trentlarson commented 2023-07-08 01:33:28 +00:00
Owner
Copy Link

Note that this message doesn't really apply on this page. The original has the more generic: "An ID is chosen but there are no keys for it so it cannot be used to talk with the service." Recommend making some more generic message for all these cases if you want to keep the same error message for them all.

Note that this message doesn't really apply on this page. The original has the more generic: "An ID is chosen but there are no keys for it so it cannot be used to talk with the service." Recommend making some more generic message for all these cases if you want to keep the same error message for them all.
anomalist marked this conversation as resolved
trentlarson reviewed 2023-07-08 01:34:22 +00:00
src/views/AccountViewView.vue Outdated
@@ -456,1 +463,3 @@
this.limitsMessage = data?.error?.message || "Bad server response.";
if (
error.message ===
"Attempted to load Give records with no identity available."
trentlarson commented 2023-07-08 01:34:22 +00:00
Owner
Copy Link

Someday we can have a specific error type, rather than relying on a message string check. Not critical now.

Someday we can have a specific error type, rather than relying on a message string check. Not critical now.
anomalist marked this conversation as resolved
trentlarson reviewed 2023-07-08 01:36:35 +00:00
src/views/NewEditProjectView.vue
@@ -104,0 +109,4 @@
if (!identity) {
throw new Error(
"Attempted to load Give records with no identity available.",
trentlarson commented 2023-07-08 01:36:35 +00:00
Owner
Copy Link

Here's another case where the message about "Give records" is not appropriate for this screen.

Here's another case where the message about "Give records" is not appropriate for this screen.
anomalist marked this conversation as resolved
trentlarson reviewed 2023-07-08 01:45:54 +00:00
src/views/HomeView.vue Outdated
@@ -279,3 +325,3 @@
}
}
createAndSubmitGive(
trentlarson commented 2023-07-08 01:45:54 +00:00
Owner
Copy Link

Thanks for cutting out this moved stuff!

Thanks for cutting out this moved stuff!
anomalist marked this conversation as resolved
anomalist added 1 commit 2023-07-08 08:19:48 +00:00
Move account counter to mounted event e25a83ff1b
anomalist added 1 commit 2023-07-08 08:39:02 +00:00
Cleaned up messages and improved the accountsDB lookups 3471afdf25
anomalist added 1 commit 2023-07-08 09:30:51 +00:00
More cleanup and application of new db loading 3bd55f3ad2
anomalist added 1 commit 2023-07-08 09:42:33 +00:00
More cleanup from project task list c61bb88788
anomalist merged commit 81dd6eb595 into master 2023-07-09 02:58:52 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
trentlarson
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
anomalist jose jsnbuchanan kentbull trentlarson
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: trent_larson/crowd-funder-for-time-pwa#35
Delete Branch "contacts-identity"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?