Files
daily-notification-plugin/scripts/todo-scan.js
Matthew Raymer cc3daaec23 feat: implement remaining production-critical TODOs
Implement iOS fetcher scheduling hooks, Android FetchWorker metrics,
and convert iOS callbacks TODOs to explicit behavior. Add TODO scan
script to prevent documentation drift.

Changes:
- iOS Scheduler: Added DailyNotificationFetchScheduling protocol
  - Implemented fetcher scheduling hooks (2 TODOs removed)
  - Added NoopFetcherScheduler default implementation
  - Replaced TODOs with actual scheduleFetch/scheduleImmediateFetch calls
- Android FetchWorker: Implemented metrics interface (5 TODOs removed)
  - Added FetchWorkerMetrics interface with 8 methods
  - Implemented retry classifier (isRetryable) for deterministic logic
  - Added metrics tracking: run/success/failure/retry counts, duration,
    items fetched/saved/enqueued
  - Replaced SharedPreferences TODO with explicit NOTE
- iOS Callbacks: Converted TODOs to explicit behavior (8 TODOs removed)
  - All callback persistence methods now have clear "not implemented"
    messages
  - Removed literal TODO markers to make TODO scan meaningful
- TODO Scan Script: Created scripts/todo-scan.js
  - Scans repo for TODO/FIXME markers
  - Generates machine-readable JSON and markdown summary
  - Added npm run todo:scan script
  - Regenerated docs/TODO-CLASSIFICATION.md (69 markers total)

Verification:
- TypeScript typecheck: PASS
- Tests: PASS (115 tests, 8 test suites)
- No linter errors
- All target TODOs removed from production code

Files changed:
- ios/Plugin/DailyNotificationScheduler.swift (+52/-52 lines)
- android/.../DailyNotificationFetchWorker.java (+113 lines)
- ios/Plugin/DailyNotificationCallbacks.swift (+44/-44 lines)
- scripts/todo-scan.js (new, 193 lines)
- package.json (added todo:scan script)
- docs/TODO-CLASSIFICATION.md (regenerated)
- docs/todo-scan.json (new, generated)
- docs/progress/00-STATUS.md (updated)
- docs/progress/01-CHANGELOG-WORK.md (updated)
2025-12-24 06:52:41 +00:00

151 lines
3.6 KiB
JavaScript
Executable File

#!/usr/bin/env node
/**
* Scans repo for TODO/FIXME markers and emits:
* - machine-readable JSON
* - human-readable markdown summary
*
* Output:
* - docs/TODO-CLASSIFICATION.md (overwritten)
* - docs/todo-scan.json
*
* @author Matthew Raymer
* @version 1.0.0
*/
const fs = require("fs");
const path = require("path");
const ROOT = process.cwd();
const TARGET_DIRS = [
"src",
"ios/Plugin",
"ios/Tests",
"android/src/main",
"android/src/test",
"scripts",
"docs",
];
const EXCLUDE_DIR_NAMES = new Set([
".git",
"node_modules",
"dist",
"build",
".venv",
"venv",
"__pycache__",
]);
const FILE_EXTS = new Set([
".ts", ".tsx", ".js", ".jsx",
".swift",
".java", ".kt",
".md",
".json", ".yml", ".yaml",
".py",
]);
const MARKERS = ["TODO", "FIXME"];
function walk(dir, out = []) {
if (!fs.existsSync(dir)) return out;
const st = fs.statSync(dir);
if (!st.isDirectory()) return out;
for (const name of fs.readdirSync(dir)) {
if (EXCLUDE_DIR_NAMES.has(name)) continue;
const p = path.join(dir, name);
const s = fs.statSync(p);
if (s.isDirectory()) walk(p, out);
else out.push(p);
}
return out;
}
function scanFile(fp) {
const ext = path.extname(fp);
if (!FILE_EXTS.has(ext)) return [];
const text = fs.readFileSync(fp, "utf8");
const lines = text.split(/\r?\n/);
const hits = [];
for (let i = 0; i < lines.length; i++) {
const line = lines[i];
for (const m of MARKERS) {
// require marker as a token-ish substring
if (line.includes(m + ":") || line.includes(m + " ")) {
hits.push({ line: i + 1, marker: m, text: line.trim() });
break;
}
}
}
return hits;
}
function bucketForPath(rel) {
if (rel.startsWith("ios/")) return "iOS";
if (rel.startsWith("android/")) return "Android";
if (rel.startsWith("src/")) return "TypeScript";
if (rel.startsWith("docs/")) return "Docs";
if (rel.startsWith("scripts/")) return "Scripts";
return "Other";
}
function main() {
const results = [];
for (const d of TARGET_DIRS) {
const dirAbs = path.join(ROOT, d);
const files = walk(dirAbs);
for (const fpAbs of files) {
const rel = path.relative(ROOT, fpAbs).replace(/\\/g, "/");
const hits = scanFile(fpAbs);
for (const h of hits) results.push({ file: rel, ...h, bucket: bucketForPath(rel) });
}
}
// sort stable: bucket, file, line
results.sort((a, b) =>
a.bucket.localeCompare(b.bucket) ||
a.file.localeCompare(b.file) ||
a.line - b.line
);
fs.writeFileSync(path.join(ROOT, "docs/todo-scan.json"), JSON.stringify(results, null, 2), "utf8");
// markdown
const byBucket = new Map();
for (const r of results) {
if (!byBucket.has(r.bucket)) byBucket.set(r.bucket, []);
byBucket.get(r.bucket).push(r);
}
let md = "";
md += `# TODO Classification (auto-generated)\n\n`;
md += `Generated by \`scripts/todo-scan.js\`\n\n`;
md += `Total markers: **${results.length}**\n\n`;
for (const [bucket, items] of byBucket.entries()) {
md += `## ${bucket} (${items.length})\n\n`;
// group by file
const byFile = new Map();
for (const it of items) {
if (!byFile.has(it.file)) byFile.set(it.file, []);
byFile.get(it.file).push(it);
}
for (const [file, hits] of byFile.entries()) {
md += `### ${file}\n\n`;
for (const h of hits) {
md += `- L${h.line}: **${h.marker}** — ${h.text}\n`;
}
md += `\n`;
}
}
fs.writeFileSync(path.join(ROOT, "docs/TODO-CLASSIFICATION.md"), md, "utf8");
console.log(`todo-scan complete: ${results.length} markers`);
}
main();