Commit Graph

2 Commits

Author SHA1 Message Date
Matthew Raymer
ddcafe2a00 refactor(android): P2.1 Batch B - complete cancelAllNotifications() delegation
- Add ScheduleHelper.cancelAlarmsForSchedules() helper method
- Add ScheduleHelper.cancelAllWorkManagerJobs() helper method
- Refactor cancelAllNotifications() to delegate to helpers
- Keep orchestration in plugin (appropriate for multi-service coordination)

Reduces plugin method from ~85 lines to ~45 lines.
Batch B complete: 15 methods refactored to thin adapter pattern.

Refs: docs/progress/P2.1-BATCH-B-STATE.md
2025-12-24 04:18:43 +00:00
Matthew Raymer
694c7ea59f refactor(android): P2.1 Batch B - delegate validation methods to services
Refactor plugin methods that validate input then delegate to services:
- requestNotificationPermissions() → PermissionManager
- openChannelSettings() → ChannelManager
- createSchedule/updateSchedule/deleteSchedule/enableSchedule() → ScheduleHelper
- scheduleUserNotification() → ScheduleHelper (database operations)
- registerCallback() → CallbackHelper
- injectInvalidTestData() → TestDataHelper
- requestExactAlarmPermission() → PermissionManager
- openExactAlarmSettings() → PermissionManager
- checkExactAlarmPermission() → PermissionManager
- cancelAllNotifications() → ScheduleHelper (database operations, partial)
- testAlarm() → DailyNotificationScheduler

Enhanced services:
- PermissionManager: Added checkExactAlarmPermission() and requestExactAlarmPermission()
- ChannelManager: Enhanced openChannelSettings() with channelId parameter and fallback logic
- ScheduleHelper: Added disableAllSchedulesByKind() method
- DailyNotificationScheduler: Added testAlarm() wrapper method

Reduces plugin class complexity by ~200 lines.
Services already exist - this is delegation, not extraction.

Refs: docs/progress/P2.1-BATCH-B-STATE.md
2025-12-23 12:01:32 +00:00