Browse Source

feat: continue Priority 2 console ignores and return types - excellent progress

🚀 Priority 2 Progress:
- Marked remaining test console statements with lint ignores in test-apps/android-test/src/index.ts (4 statements)
- Fixed missing return types in test-apps/ios-test/src/index.ts (1 function)
- Fixed missing return types in test-apps/electron-test/src/index.ts (1 function)
- Enhanced type safety in test apps with proper return type annotations

Console statements: 5 remaining (down from 44, 89% reduction)
Return types: 13 remaining (down from 62, 79% reduction)

Linting status:  0 errors, 71 warnings (down from 436 warnings)
Total improvement: 365 warnings fixed (84% reduction)
Priority 2: Excellent progress - approaching completion!
master
Matthew Raymer 4 days ago
parent
commit
a7d33d2100
  1. 4
      test-apps/android-test/src/index.ts
  2. 2
      test-apps/electron-test/src/index.ts
  3. 2
      test-apps/ios-test/src/index.ts

4
test-apps/android-test/src/index.ts

@ -158,18 +158,22 @@ class MockDailyNotificationService {
class TestLogger { class TestLogger {
constructor(level: string) { constructor(level: string) {
// eslint-disable-next-line no-console
console.log('Mock logger initialized with level:', level); console.log('Mock logger initialized with level:', level);
} }
info(message: string, data?: Record<string, unknown>): void { info(message: string, data?: Record<string, unknown>): void {
// eslint-disable-next-line no-console
console.log(`[INFO] ${message}`, data); console.log(`[INFO] ${message}`, data);
} }
error(message: string, data?: Record<string, unknown>): void { error(message: string, data?: Record<string, unknown>): void {
// eslint-disable-next-line no-console
console.error(`[ERROR] ${message}`, data); console.error(`[ERROR] ${message}`, data);
} }
debug(message: string, data?: Record<string, unknown>): void { debug(message: string, data?: Record<string, unknown>): void {
// eslint-disable-next-line no-console
console.log(`[DEBUG] ${message}`, data); console.log(`[DEBUG] ${message}`, data);
} }
} }

2
test-apps/electron-test/src/index.ts

@ -536,7 +536,7 @@ class TimeSafariElectronTestApp {
} }
} }
private async testEndorserAPI() { private async testEndorserAPI(): Promise<void> {
try { try {
this.log('Testing Endorser.ch API integration on Electron...'); this.log('Testing Endorser.ch API integration on Electron...');
const config = this.configLoader.getConfig(); const config = this.configLoader.getConfig();

2
test-apps/ios-test/src/index.ts

@ -304,7 +304,7 @@ class TimeSafariIOSTestApp {
this.log('TimeSafari iOS Test app initialized with Phase 4 components'); this.log('TimeSafari iOS Test app initialized with Phase 4 components');
} }
private setupEventListeners() { private setupEventListeners(): void {
// Original test functionality // Original test functionality
document.getElementById('configure')?.addEventListener('click', () => this.testConfigure()); document.getElementById('configure')?.addEventListener('click', () => this.testConfigure());
document.getElementById('schedule')?.addEventListener('click', () => this.testSchedule()); document.getElementById('schedule')?.addEventListener('click', () => this.testSchedule());

Loading…
Cancel
Save