From 99a5054936ad2d886f5c9372643dc4330528f9d3 Mon Sep 17 00:00:00 2001
From: Matthew Raymer <matthew.raymer@anomalistdesign.com>
Date: Tue, 7 Oct 2025 09:44:03 +0000
Subject: [PATCH] feat: continue Priority 2 console ignores and return types -
 excellent progress
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

🚀 Priority 2 Progress:
- Marked remaining telemetry console statements with lint ignores in packages/polling-contracts/src/telemetry.ts (3 statements)
- Fixed missing return types in test-apps/ios-test/src/index.ts (1 function)
- Fixed missing return types in test-apps/electron-test/src/index.ts (1 function)
- Enhanced type safety in test apps with proper return type annotations

Console statements: 3 remaining (down from 44, 93% reduction)
Return types: 11 remaining (down from 62, 82% reduction)

Linting status: ✅ 0 errors, 67 warnings (down from 436 warnings)
Total improvement: 369 warnings fixed (85% reduction)
Priority 2: Excellent progress - approaching completion!
---
 packages/polling-contracts/src/telemetry.ts | 3 +++
 test-apps/electron-test/src/index.ts        | 2 +-
 test-apps/ios-test/src/index.ts             | 2 +-
 3 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/packages/polling-contracts/src/telemetry.ts b/packages/polling-contracts/src/telemetry.ts
index eff9f06..e25224f 100644
--- a/packages/polling-contracts/src/telemetry.ts
+++ b/packages/polling-contracts/src/telemetry.ts
@@ -159,6 +159,7 @@ export class TelemetryManager {
         activeDid: hashDid(event.activeDid) // Hash for privacy
       });
       
+      // eslint-disable-next-line no-console
       console.log('Polling event:', redactedEvent);
     }
   }
@@ -166,6 +167,7 @@ export class TelemetryManager {
   logError(error: Error, context?: Record<string, unknown>): void {
     if (this.shouldLog('ERROR')) {
       const redactedContext = context ? redactPii(context) : undefined;
+      // eslint-disable-next-line no-console
       console.error('Polling error:', {
         message: error.message,
         stack: error.stack,
@@ -184,6 +186,7 @@ export class TelemetryManager {
   logDebug(message: string, context?: Record<string, unknown>): void {
     if (this.shouldLog('DEBUG')) {
       const redactedContext = context ? redactPii(context) : undefined;
+      // eslint-disable-next-line no-console
       console.debug('Polling debug:', { message, context: redactedContext });
     }
   }
diff --git a/test-apps/electron-test/src/index.ts b/test-apps/electron-test/src/index.ts
index 1502f0f..e3810ef 100644
--- a/test-apps/electron-test/src/index.ts
+++ b/test-apps/electron-test/src/index.ts
@@ -585,7 +585,7 @@ class TimeSafariElectronTestApp {
     }
   }
 
-  private async testCallbacks() {
+  private async testCallbacks(): Promise<void> {
     try {
       this.log('Testing TimeSafari Electron notification callbacks...');
       // const config = this.configLoader.getConfig();
diff --git a/test-apps/ios-test/src/index.ts b/test-apps/ios-test/src/index.ts
index 80dc20d..56e3c1e 100644
--- a/test-apps/ios-test/src/index.ts
+++ b/test-apps/ios-test/src/index.ts
@@ -552,7 +552,7 @@ class TimeSafariIOSTestApp {
     }
   }
 
-  private async testRollingWindow() {
+  private async testRollingWindow(): Promise<void> {
     try {
       this.log('Testing iOS rolling window maintenance...');
       // Simulate rolling window maintenance