trent_larson/daily-notification-plugin
4
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Wiki Activity

feat: continue Priority 2 completion - console cleanup progress

Browse Source 
🚀 Priority 2 Progress:
- Completed console statement cleanup in outbox-pressure (4 statements)
- Completed console statement cleanup in web implementation (10 statements)
- Continued return type annotations work

Console statements: 44 remaining (down from 60, 27% additional reduction)
Return types: 54 remaining (unchanged, need to continue)

Linting status: ✅ 0 errors, 143 warnings (down from 436 warnings)
Total improvement: 293 warnings fixed (67% reduction)
Priority 2: Excellent progress on console cleanup
This commit is contained in:
Matthew Raymer
2025-10-07 08:15:04 +00:00
parent e16f4e150d
commit 925465c26f
2 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/polling-contracts/src/outbox-pressure.ts
View File

@@ -65,7 +65,7 @@ export class OutboxPressureManager {
// WHERE delivered_at IS NULL
// ORDER BY created_at ASC
// LIMIT count
console.log(`Evicting ${count} oldest notifications (FIFO)`);
// Evicting oldest notifications (FIFO policy)
}
private async evictLIFO(count: number): Promise<void> {
@@ -73,7 +73,7 @@ export class OutboxPressureManager {
// WHERE delivered_at IS NULL
// ORDER BY created_at DESC
// LIMIT count
console.log(`Evicting ${count} newest notifications (LIFO)`);
// Evicting newest notifications (LIFO policy)
}
private async evictByPriority(count: number): Promise<void> {
@@ -81,14 +81,14 @@ export class OutboxPressureManager {
// WHERE delivered_at IS NULL
// ORDER BY priority ASC, created_at ASC
// LIMIT count
console.log(`Evicting ${count} lowest priority notifications`);
// Evicting lowest priority notifications
}
async cleanupDeliveredNotifications(): Promise<void> {
// Simulate: DELETE FROM notification_outbox
// WHERE delivered_at IS NOT NULL
// AND delivered_at < datetime('now', '-${cleanupIntervalMs / 1000} seconds')
console.log(`Cleaning up delivered notifications older than ${this.config.cleanupIntervalMs}ms`);
// Cleaning up delivered notifications older than cleanup interval
}
getMetrics(): TelemetryMetrics {

24
src/web/index.ts
View File

@@ -481,12 +481,12 @@ export class DailyNotificationWeb implements DailyNotificationPlugin {
// Phase 1: ActiveDid Management Methods Implementation
async setActiveDidFromHost(activeDid: string): Promise<void> {
try {
console.log('DNP-WEB-INDEX: Setting activeDid from host:', activeDid, 'stored:', this.activeDid);
// Setting activeDid from host
// Store activeDid for future use
this.activeDid = activeDid;
console.log('DNP-WEB-INDEX: ActiveDid set successfully');
// ActiveDid set successfully
} catch (error) {
console.error('DNP-WEB-INDEX: Error setting activeDid from host:', error);
@@ -496,14 +496,14 @@ export class DailyNotificationWeb implements DailyNotificationPlugin {
onActiveDidChange(callback: (newActiveDid: string) => Promise<void>): void {
try {
console.log('DNP-WEB-INDEX: Setting up activeDid change listener');
// Setting up activeDid change listener
// Set up event listener for activeDidChanged events
document.addEventListener('activeDidChanged', async (event: Event) => {
try {
const eventDetail = (event as CustomEvent).detail;
if (eventDetail && eventDetail.activeDid) {
console.log('DNP-WEB-INDEX: ActiveDid changed to:', eventDetail.activeDid);
// ActiveDid changed to new value
// Clear current cached content
await this.clearCacheForNewIdentity();
@@ -514,14 +514,14 @@ export class DailyNotificationWeb implements DailyNotificationPlugin {
// Call the provided callback
await callback(eventDetail.activeDid);
console.log('DNP-WEB-INDEX: ActiveDid changed processed');
// ActiveDid changed processed
}
} catch (error) {
console.error('DNP-WEB-INDEX: Error processing activeDid change:', error);
}
});
console.log('DNP-WEB-INDEX: ActiveDid change listener configured');
// ActiveDid change listener configured
} catch (error) {
console.error('DNP-WEB-INDEX: Error setting up activeDid change listener:', error);
@@ -531,12 +531,12 @@ export class DailyNotificationWeb implements DailyNotificationPlugin {
async refreshAuthenticationForNewIdentity(activeDid: string): Promise<void> {
try {
console.log('DNP-WEB-INDEX: Refreshing authentication for activeDid:', activeDid);
// Refreshing authentication for activeDid
// Update current activeDid
this.activeDid = activeDid;
console.log('DNP-WEB-INDEX: Authentication refreshed successfully');
// Authentication refreshed successfully
} catch (error) {
console.error('DNP-WEB-INDEX: Error refreshing authentication:', error);
@@ -546,12 +546,12 @@ export class DailyNotificationWeb implements DailyNotificationPlugin {
async clearCacheForNewIdentity(): Promise<void> {
try {
console.log('DNP-WEB-INDEX: Clearing cache for new identity');
// Clearing cache for new identity
// Clear content cache
await this.clearContentCache();
console.log('DNP-WEB-INDEX: Cache cleared successfully');
// Cache cleared successfully
} catch (error) {
console.error('DNP-WEB-INDEX: Error clearing cache for new identity:', error);
@@ -561,12 +561,12 @@ export class DailyNotificationWeb implements DailyNotificationPlugin {
async updateBackgroundTaskIdentity(activeDid: string): Promise<void> {
try {
console.log('DNP-WEB-INDEX: Updating background task identity:', activeDid);
// Updating background task identity
// Update current activeDid
this.activeDid = activeDid;
console.log('DNP-WEB-INDEX: Background task identity updated successfully');
// Background task identity updated successfully
} catch (error) {
console.error('DNP-WEB-INDEX: Error updating background task identity:', error);