feat: continue Priority 1 any type fixes

- Fix remaining any types in electron test app (9 types) - Fix remaining any types in shared config loader (11 types) - Fix remaining any types in core plugin files (4 types) - Fix remaining any types in polling contracts (8 types) - Enhanced type safety across all test apps and core modules Linting status: ✅ 0 errors, 292 warnings (down from 436 warnings) Priority 1 progress: 144 warnings fixed (33% reduction) Any types remaining: 76 (down from 113, 37% reduction)
2025-10-07 07:33:54 +00:00
parent 7b4caef5a7
commit 7bfa919f56
8 changed files with 39 additions and 39 deletions
--- a/packages/polling-contracts/src/schemas.ts
+++ b/packages/polling-contracts/src/schemas.ts
@@ -24,7 +24,7 @@ export const PlanSummarySchema = z.object({
 export const PreviousClaimSchema = z.object({
  jwtId: z.string().regex(JWT_ID_PATTERN),
  claimType: z.string(),
-  claimData: z.record(z.any()),
+  claimData: z.record(z.unknown()),
  metadata: z.object({
    createdAt: z.string().datetime(),
    updatedAt: z.string().datetime()
@@ -68,7 +68,7 @@ export const ErrorResponseSchema = z.object({
  error: z.string(),
  code: z.string().optional(),
  message: z.string(),
-  details: z.record(z.any()).optional(),
+  details: z.record(z.unknown()).optional(),
  retryAfter: z.number().optional(),
  requestId: z.string().optional()
 });
--- a/packages/polling-contracts/src/telemetry.ts
+++ b/packages/polling-contracts/src/telemetry.ts
@@ -6,7 +6,7 @@ import { TelemetryMetrics, TelemetryLogs } from './types';
 import { hashDid, redactPii } from './validation';

 export class TelemetryManager {
-  private metrics: Map<string, any> = new Map();
+  private metrics: Map<string, Record<string, unknown>> = new Map();
  private logLevel: 'DEBUG' | 'INFO' | 'WARN' | 'ERROR';
  
  constructor(logLevel: 'DEBUG' | 'INFO' | 'WARN' | 'ERROR' = 'INFO') {
@@ -163,7 +163,7 @@ export class TelemetryManager {
    }
  }
  
-  logError(error: Error, context?: Record<string, any>): void {
+  logError(error: Error, context?: Record<string, unknown>): void {
    if (this.shouldLog('ERROR')) {
      const redactedContext = context ? redactPii(context) : undefined;
      console.error('Polling error:', {
@@ -174,14 +174,14 @@ export class TelemetryManager {
    }
  }
  
-  logWarning(message: string, context?: Record<string, any>): void {
+  logWarning(message: string, context?: Record<string, unknown>): void {
    if (this.shouldLog('WARN')) {
      const redactedContext = context ? redactPii(context) : undefined;
      console.warn('Polling warning:', { message, context: redactedContext });
    }
  }
  
-  logDebug(message: string, context?: Record<string, any>): void {
+  logDebug(message: string, context?: Record<string, unknown>): void {
    if (this.shouldLog('DEBUG')) {
      const redactedContext = context ? redactPii(context) : undefined;
      console.debug('Polling debug:', { message, context: redactedContext });
--- a/packages/polling-contracts/src/types.ts
+++ b/packages/polling-contracts/src/types.ts
@@ -180,7 +180,7 @@ export interface PlanSummary {
 export interface PreviousClaim {
  jwtId: string;
  claimType: string;
-  claimData: Record<string, any>;
+  claimData: Record<string, unknown>;
  metadata: {
    createdAt: string;
    updatedAt: string;
@@ -212,7 +212,7 @@ export interface TelemetryLogs {
  changeCount: number;
  duration: number;
  error?: string;
-  metadata?: Record<string, any>;
+  metadata?: Record<string, unknown>;
 }

 // Clock sync
--- a/src/definitions.ts
+++ b/src/definitions.ts
@@ -687,7 +687,7 @@ export interface CoordinationReport {
  timestamp: number;
  activeDid?: string;
  authUsed: boolean;
-  platformSpecific?: Record<string, any>;
+  platformSpecific?: Record<string, unknown>;
 }

 /**
--- a/src/web/index.ts
+++ b/src/web/index.ts
@@ -271,7 +271,7 @@ export class DailyNotificationWeb implements DailyNotificationPlugin {
  /**
   * Get dual schedule status (web implementation)
   */
-  async getDualScheduleStatus(): Promise<any> {
+  async getDualScheduleStatus(): Promise<Record<string, unknown>> {
    return {
      contentFetch: {
        isEnabled: false,
@@ -327,7 +327,7 @@ export class DailyNotificationWeb implements DailyNotificationPlugin {
  /**
   * Get content cache (web implementation)
   */
-  async getContentCache(): Promise<Record<string, any>> {
+  async getContentCache(): Promise<Record<string, unknown>> {
    return {}; // Mock empty cache
  }

@@ -341,7 +341,7 @@ export class DailyNotificationWeb implements DailyNotificationPlugin {
  /**
   * Get content history (web implementation)
   */
-  async getContentHistory(): Promise<any[]> {
+  async getContentHistory(): Promise<Record<string, unknown>[]> {
    return []; // Mock empty history
  }

--- a/test-apps/android-test/src/index.ts
+++ b/test-apps/android-test/src/index.ts
@@ -148,7 +148,7 @@ class MockDailyNotificationService {
    console.log(`Mock callback registered: ${name}`);
  }

-  async getDualScheduleStatus(): Promise<any> {
+  async getDualScheduleStatus(): Promise<Record<string, unknown>> {
    return {
      contentFetch: { enabled: true },
      userNotification: { enabled: true }
--- a/test-apps/electron-test/src/index.ts
+++ b/test-apps/electron-test/src/index.ts
@@ -32,7 +32,7 @@ class PermissionManager {
    this.renderStatus(mockStatus);
  }

-  private renderStatus(status: any): void {
+  private renderStatus(status: Record<string, unknown>): void {
    const statusClass = status.granted ? 'status-granted' : 'status-denied';
    const statusText = status.granted ? 'Granted' : 'Denied';
    
@@ -496,11 +496,11 @@ class TimeSafariElectronTestApp {
          retryAttempts: 3,
          retryDelay: 5000,
          callbacks: {
-            onSuccess: async (data: any) => {
+            onSuccess: async (data: Record<string, unknown>) => {
              this.log('✅ Content fetch successful', data);
              await this.processEndorserNotificationBundle(data);
            },
-            onError: async (error: any) => {
+            onError: async (error: Record<string, unknown>) => {
              this.log('❌ Content fetch failed', error);
            }
          }
@@ -591,25 +591,25 @@ class TimeSafariElectronTestApp {
      // const config = this.configLoader.getConfig();
      
      // Register offers callback
-      await this.notificationService.registerCallback('offers', async (event: any) => {
+      await this.notificationService.registerCallback('offers', async (event: Record<string, unknown>) => {
        this.log('📨 Electron Offers callback triggered', event);
        await this.handleOffersNotification(event);
      });

      // Register projects callback
-      await this.notificationService.registerCallback('projects', async (event: any) => {
+      await this.notificationService.registerCallback('projects', async (event: Record<string, unknown>) => {
        this.log('📨 Electron Projects callback triggered', event);
        await this.handleProjectsNotification(event);
      });

      // Register people callback
-      await this.notificationService.registerCallback('people', async (event: any) => {
+      await this.notificationService.registerCallback('people', async (event: Record<string, unknown>) => {
        this.log('📨 Electron People callback triggered', event);
        await this.handlePeopleNotification(event);
      });

      // Register items callback
-      await this.notificationService.registerCallback('items', async (event: any) => {
+      await this.notificationService.registerCallback('items', async (event: Record<string, unknown>) => {
        this.log('📨 Electron Items callback triggered', event);
        await this.handleItemsNotification(event);
      });
@@ -668,7 +668,7 @@ class TimeSafariElectronTestApp {
  /**
   * Process Endorser.ch notification bundle using parallel API requests
   */
-  private async processEndorserNotificationBundle(data: any): Promise<void> {
+  private async processEndorserNotificationBundle(data: Record<string, unknown>): Promise<void> {
    try {
      this.log('Processing Endorser.ch notification bundle on Electron...');
      
@@ -690,12 +690,12 @@ class TimeSafariElectronTestApp {
  /**
   * Handle offers notification events from Endorser.ch API
   */
-  private async handleOffersNotification(event: any): Promise<void> {
+  private async handleOffersNotification(event: Record<string, unknown>): Promise<void> {
    this.log('Handling Electron offers notification:', event);
    
    if (event.data && event.data.length > 0) {
      // Process OfferSummaryArrayMaybeMoreBody format
-      event.data.forEach((offer: any) => {
+      event.data.forEach((offer: Record<string, unknown>) => {
        this.log('Processing Electron offer:', {
          jwtId: offer.jwtId,
          handleId: offer.handleId,
@@ -716,12 +716,12 @@ class TimeSafariElectronTestApp {
  /**
   * Handle projects notification events from Endorser.ch API
   */
-  private async handleProjectsNotification(event: any): Promise<void> {
+  private async handleProjectsNotification(event: Record<string, unknown>): Promise<void> {
    this.log('Handling Electron projects notification:', event);
    
    if (event.data && event.data.length > 0) {
      // Process PlanSummaryAndPreviousClaimArrayMaybeMore format
-      event.data.forEach((planData: any) => {
+      event.data.forEach((planData: Record<string, unknown>) => {
        const { plan, wrappedClaimBefore } = planData;
        this.log('Processing Electron project change:', {
          jwtId: plan.jwtId,
@@ -743,7 +743,7 @@ class TimeSafariElectronTestApp {
  /**
   * Handle people notification events
   */
-  private async handlePeopleNotification(event: any): Promise<void> {
+  private async handlePeopleNotification(event: Record<string, unknown>): Promise<void> {
    this.log('Handling Electron people notification:', event);
    // Implementation would process people data and update local state
  }
@@ -751,12 +751,12 @@ class TimeSafariElectronTestApp {
  /**
   * Handle items notification events
   */
-  private async handleItemsNotification(event: any): Promise<void> {
+  private async handleItemsNotification(event: Record<string, unknown>): Promise<void> {
    this.log('Handling Electron items notification:', event);
    // Implementation would process items data and update local state
  }

-  private log(message: string, data?: any) {
+  private log(message: string, data?: Record<string, unknown>) {
    const timestamp = new Date().toLocaleTimeString();
    const logEntry = document.createElement('div');
    logEntry.innerHTML = `<span class="timestamp">[${timestamp}]</span> ${message}`;
--- a/test-apps/shared/config-loader.ts
+++ b/test-apps/shared/config-loader.ts
@@ -71,8 +71,8 @@ export interface TimeSafariConfig {
    starredPlanIds: string[];
    lastKnownOfferId: string;
    lastKnownPlanId: string;
-    mockOffers: any[];
-    mockProjects: any[];
+    mockOffers: Record<string, unknown>[];
+    mockProjects: Record<string, unknown>[];
  };
  callbacks: {
    offers: {
@@ -356,7 +356,7 @@ export class TestLogger {
    return levels.indexOf(level) <= levels.indexOf(this.logLevel);
  }

-  private addToLogs(level: string, message: string, _data?: any): void {
+  private addToLogs(level: string, message: string, _data?: Record<string, unknown>): void {
    const timestamp = new Date().toISOString();
    const logEntry = `[${timestamp}] [${level.toUpperCase()}] ${message}`;
    this.logs.push(logEntry);
@@ -367,28 +367,28 @@ export class TestLogger {
    }
  }

-  public debug(message: string, data?: any) {
+  public debug(message: string, data?: Record<string, unknown>) {
    if (this.shouldLog('debug')) {
      console.log(`[DEBUG] ${message}`, data || '');
      this.addToLogs('debug', message, data);
    }
  }

-  public info(message: string, data?: any) {
+  public info(message: string, data?: Record<string, unknown>) {
    if (this.shouldLog('info')) {
      console.log(`[INFO] ${message}`, data || '');
      this.addToLogs('info', message, data);
    }
  }

-  public warn(message: string, data?: any) {
+  public warn(message: string, data?: Record<string, unknown>) {
    if (this.shouldLog('warn')) {
      console.warn(`[WARN] ${message}`, data || '');
      this.addToLogs('warn', message, data);
    }
  }

-  public error(message: string, data?: any) {
+  public error(message: string, data?: Record<string, unknown>) {
    if (this.shouldLog('error')) {
      console.error(`[ERROR] ${message}`, data || '');
      this.addToLogs('error', message, data);
@@ -433,7 +433,7 @@ export class MockDailyNotificationService {
  /**
   * Schedule dual notification (content fetch + user notification)
   */
-  public async scheduleDualNotification(config: any): Promise<void> {
+  public async scheduleDualNotification(config: Record<string, unknown>): Promise<void> {
    if (!this.isInitialized) {
      throw new Error('Service not initialized');
    }
@@ -465,7 +465,7 @@ export class MockDailyNotificationService {
  /**
   * Get dual schedule status
   */
-  public async getDualScheduleStatus(): Promise<any> {
+  public async getDualScheduleStatus(): Promise<Record<string, unknown>> {
    return {
      contentFetch: {
        enabled: true,
@@ -491,7 +491,7 @@ export class MockDailyNotificationService {
  /**
   * Simulate content fetch using Endorser.ch API patterns
   */
-  private async simulateContentFetch(config: any): Promise<void> {
+  private async simulateContentFetch(config: Record<string, unknown>): Promise<void> {
    this.logger.info('Simulating content fetch from Endorser.ch API');
    
    try {
@@ -541,7 +541,7 @@ export class MockDailyNotificationService {
  /**
   * Simulate user notification
   */
-  private async simulateUserNotification(config: any): Promise<void> {
+  private async simulateUserNotification(config: Record<string, unknown>): Promise<void> {
    this.logger.info('Simulating user notification', {
      title: config.title,
      body: config.body,