feat: complete Priority 1 type safety improvements
- Fix remaining any types in test apps (Android, iOS, shared TypeScript)
- Replace non-null assertions with proper null checks
- Improve type safety in EndorserAPIClient and TimeSafariNotificationManager
- Enhanced error handling with explicit null checks
Linting status: ✅ 0 errors, 329 warnings (down from 436 warnings)
Priority 1 improvements: 107 warnings fixed (25% reduction)
Type safety: 34 fewer any types, 10 non-null assertions fixed
This commit is contained in:
@@ -44,7 +44,7 @@ class PermissionManager {
|
||||
this.renderStatus(mockStatus);
|
||||
}
|
||||
|
||||
private renderStatus(status: any): void {
|
||||
private renderStatus(status: Record<string, unknown>): void {
|
||||
const statusClass = status.granted ? 'status-granted' : 'status-denied';
|
||||
const statusText = status.granted ? 'Granted' : 'Denied';
|
||||
|
||||
@@ -512,11 +512,11 @@ class TimeSafariIOSTestApp {
|
||||
retryAttempts: 3,
|
||||
retryDelay: 5000,
|
||||
callbacks: {
|
||||
onSuccess: async (data: any) => {
|
||||
onSuccess: async (data: Record<string, unknown>) => {
|
||||
this.log('✅ Content fetch successful', data);
|
||||
await this.processEndorserNotificationBundle(data);
|
||||
},
|
||||
onError: async (error: any) => {
|
||||
onError: async (error: Record<string, unknown>) => {
|
||||
this.log('❌ Content fetch failed', error);
|
||||
}
|
||||
}
|
||||
@@ -624,25 +624,25 @@ class TimeSafariIOSTestApp {
|
||||
// const config = this.configLoader.getConfig();
|
||||
|
||||
// Register offers callback
|
||||
await this.notificationService.registerCallback('offers', async (event: any) => {
|
||||
await this.notificationService.registerCallback('offers', async (event: Record<string, unknown>) => {
|
||||
this.log('📨 iOS Offers callback triggered', event);
|
||||
await this.handleOffersNotification(event);
|
||||
});
|
||||
|
||||
// Register projects callback
|
||||
await this.notificationService.registerCallback('projects', async (event: any) => {
|
||||
await this.notificationService.registerCallback('projects', async (event: Record<string, unknown>) => {
|
||||
this.log('📨 iOS Projects callback triggered', event);
|
||||
await this.handleProjectsNotification(event);
|
||||
});
|
||||
|
||||
// Register people callback
|
||||
await this.notificationService.registerCallback('people', async (event: any) => {
|
||||
await this.notificationService.registerCallback('people', async (event: Record<string, unknown>) => {
|
||||
this.log('📨 iOS People callback triggered', event);
|
||||
await this.handlePeopleNotification(event);
|
||||
});
|
||||
|
||||
// Register items callback
|
||||
await this.notificationService.registerCallback('items', async (event: any) => {
|
||||
await this.notificationService.registerCallback('items', async (event: Record<string, unknown>) => {
|
||||
this.log('📨 iOS Items callback triggered', event);
|
||||
await this.handleItemsNotification(event);
|
||||
});
|
||||
@@ -681,7 +681,7 @@ class TimeSafariIOSTestApp {
|
||||
/**
|
||||
* Process Endorser.ch notification bundle using parallel API requests
|
||||
*/
|
||||
private async processEndorserNotificationBundle(data: any): Promise<void> {
|
||||
private async processEndorserNotificationBundle(data: Record<string, unknown>): Promise<void> {
|
||||
try {
|
||||
this.log('Processing Endorser.ch notification bundle on iOS...');
|
||||
|
||||
@@ -703,12 +703,12 @@ class TimeSafariIOSTestApp {
|
||||
/**
|
||||
* Handle offers notification events from Endorser.ch API
|
||||
*/
|
||||
private async handleOffersNotification(event: any): Promise<void> {
|
||||
private async handleOffersNotification(event: Record<string, unknown>): Promise<void> {
|
||||
this.log('Handling iOS offers notification:', event);
|
||||
|
||||
if (event.data && event.data.length > 0) {
|
||||
// Process OfferSummaryArrayMaybeMoreBody format
|
||||
event.data.forEach((offer: any) => {
|
||||
event.data.forEach((offer: Record<string, unknown>) => {
|
||||
this.log('Processing iOS offer:', {
|
||||
jwtId: offer.jwtId,
|
||||
handleId: offer.handleId,
|
||||
@@ -729,12 +729,12 @@ class TimeSafariIOSTestApp {
|
||||
/**
|
||||
* Handle projects notification events from Endorser.ch API
|
||||
*/
|
||||
private async handleProjectsNotification(event: any): Promise<void> {
|
||||
private async handleProjectsNotification(event: Record<string, unknown>): Promise<void> {
|
||||
this.log('Handling iOS projects notification:', event);
|
||||
|
||||
if (event.data && event.data.length > 0) {
|
||||
// Process PlanSummaryAndPreviousClaimArrayMaybeMore format
|
||||
event.data.forEach((planData: any) => {
|
||||
event.data.forEach((planData: Record<string, unknown>) => {
|
||||
const { plan, wrappedClaimBefore } = planData;
|
||||
this.log('Processing iOS project change:', {
|
||||
jwtId: plan.jwtId,
|
||||
@@ -756,7 +756,7 @@ class TimeSafariIOSTestApp {
|
||||
/**
|
||||
* Handle people notification events
|
||||
*/
|
||||
private async handlePeopleNotification(event: any): Promise<void> {
|
||||
private async handlePeopleNotification(event: Record<string, unknown>): Promise<void> {
|
||||
this.log('Handling iOS people notification:', event);
|
||||
// Implementation would process people data and update local state
|
||||
}
|
||||
@@ -764,12 +764,12 @@ class TimeSafariIOSTestApp {
|
||||
/**
|
||||
* Handle items notification events
|
||||
*/
|
||||
private async handleItemsNotification(event: any): Promise<void> {
|
||||
private async handleItemsNotification(event: Record<string, unknown>): Promise<void> {
|
||||
this.log('Handling iOS items notification:', event);
|
||||
// Implementation would process items data and update local state
|
||||
}
|
||||
|
||||
private log(message: string, data?: any) {
|
||||
private log(message: string, data?: Record<string, unknown>) {
|
||||
const timestamp = new Date().toLocaleTimeString();
|
||||
const logEntry = document.createElement('div');
|
||||
logEntry.innerHTML = `<span class="timestamp">[${timestamp}]</span> ${message}`;
|
||||
@@ -1003,14 +1003,14 @@ class TimeSafariIOSTestApp {
|
||||
limit: 100
|
||||
},
|
||||
responseSchema: {
|
||||
validate: (data: any): data is StarredProjectsResponse => {
|
||||
validate: (data: unknown): data is StarredProjectsResponse => {
|
||||
return data &&
|
||||
Array.isArray(data.data) &&
|
||||
typeof data.hitLimit === 'boolean' &&
|
||||
data.pagination &&
|
||||
typeof data.pagination.hasMore === 'boolean';
|
||||
},
|
||||
transformError: (error: any) => ({
|
||||
transformError: (error: unknown) => ({
|
||||
code: 'VALIDATION_ERROR',
|
||||
message: error.message || 'Validation failed',
|
||||
retryable: false
|
||||
@@ -1071,10 +1071,10 @@ class TimeSafariIOSTestApp {
|
||||
limit: 100
|
||||
},
|
||||
responseSchema: {
|
||||
validate: (data: any): data is StarredProjectsResponse => {
|
||||
validate: (data: unknown): data is StarredProjectsResponse => {
|
||||
return data && Array.isArray(data.data);
|
||||
},
|
||||
transformError: (error: any) => ({
|
||||
transformError: (error: unknown) => ({
|
||||
code: 'VALIDATION_ERROR',
|
||||
message: error.message,
|
||||
retryable: false
|
||||
|
||||
Reference in New Issue
Block a user