trent_larson/daily-notification-plugin
4
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Wiki Activity

feat: complete Priority 1 type safety improvements

Browse Source 
- Fix remaining any types in test apps (Android, iOS, shared TypeScript)
- Replace non-null assertions with proper null checks
- Improve type safety in EndorserAPIClient and TimeSafariNotificationManager
- Enhanced error handling with explicit null checks

Linting status: ✅ 0 errors, 329 warnings (down from 436 warnings)
Priority 1 improvements: 107 warnings fixed (25% reduction)
Type safety: 34 fewer any types, 10 non-null assertions fixed
This commit is contained in:
Matthew Raymer
2025-10-07 07:22:04 +00:00
parent 5e77ba1917
commit 7b4caef5a7
13 changed files with 123 additions and 105 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
test-apps/android-test/src/index.ts
View File

@@ -26,7 +26,7 @@ import {
// Enhanced ConfigLoader for Phase 4
class ConfigLoader {
private static instance: ConfigLoader;
private config: any;
private config: Record<string, unknown>;
static getInstance(): ConfigLoader {
if (!this.instance) {
@@ -74,7 +74,7 @@ class ConfigLoader {
};
}
getConfig(): any {
getConfig(): Record<string, unknown> {
return this.config;
}
@@ -121,7 +121,7 @@ class ConfigLoader {
};
}
getAuthHeaders(): any {
getAuthHeaders(): Record<string, string> {
return {
'Authorization': `Bearer ${this.config.endorser.apiKey}`,
'Content-Type': 'application/json'
@@ -130,17 +130,17 @@ class ConfigLoader {
}
class MockDailyNotificationService {
constructor(config: any) {
constructor(config: Record<string, unknown>) {
this.config = config;
}
private config: any;
private config: Record<string, unknown>;
async initialize(): Promise<void> {
console.log('Mock notification service initialized');
}
async scheduleDualNotification(config: any): Promise<void> {
async scheduleDualNotification(config: Record<string, unknown>): Promise<void> {
console.log('Mock dual notification scheduled:', config);
}
@@ -161,15 +161,15 @@ class TestLogger {
console.log('Mock logger initialized with level:', level);
}
info(message: string, data?: any) {
info(message: string, data?: Record<string, unknown>) {
console.log(`[INFO] ${message}`, data);
}
error(message: string, data?: any) {
error(message: string, data?: Record<string, unknown>) {
console.error(`[ERROR] ${message}`, data);
}
debug(message: string, data?: any) {
debug(message: string, data?: Record<string, unknown>) {
console.log(`[DEBUG] ${message}`, data);
}
}
@@ -195,7 +195,7 @@ class PermissionManager {
this.renderStatus(mockStatus);
}
private renderStatus(status: any): void {
private renderStatus(status: Record<string, unknown>): void {
const statusClass = status.granted ? 'status-granted' : 'status-denied';
const statusText = status.granted ? 'Granted' : 'Denied';
@@ -674,11 +674,11 @@ class TimeSafariAndroidTestApp {
retryAttempts: 3,
retryDelay: 5000,
callbacks: {
onSuccess: async (data: any) => {
onSuccess: async (data: Record<string, unknown>) => {
this.log('✅ Content fetch successful', data);
await this.processEndorserNotificationBundle(data);
},
onError: async (error: any) => {
onError: async (error: Record<string, unknown>) => {
this.log('❌ Content fetch failed', error);
}
}
@@ -769,25 +769,25 @@ class TimeSafariAndroidTestApp {
// const config = this.configLoader.getConfig();
// Register offers callback
await this.notificationService.registerCallback('offers', async (event: any) => {
await this.notificationService.registerCallback('offers', async (event: Record<string, unknown>) => {
this.log('📨 Offers callback triggered', event);
await this.handleOffersNotification(event);
});
// Register projects callback
await this.notificationService.registerCallback('projects', async (event: any) => {
await this.notificationService.registerCallback('projects', async (event: Record<string, unknown>) => {
this.log('📨 Projects callback triggered', event);
await this.handleProjectsNotification(event);
});
// Register people callback
await this.notificationService.registerCallback('people', async (event: any) => {
await this.notificationService.registerCallback('people', async (event: Record<string, unknown>) => {
this.log('📨 People callback triggered', event);
await this.handlePeopleNotification(event);
});
// Register items callback
await this.notificationService.registerCallback('items', async (event: any) => {
await this.notificationService.registerCallback('items', async (event: Record<string, unknown>) => {
this.log('📨 Items callback triggered', event);
await this.handleItemsNotification(event);
});
@@ -837,7 +837,7 @@ class TimeSafariAndroidTestApp {
/**
* Process Endorser.ch notification bundle using parallel API requests
*/
private async processEndorserNotificationBundle(data: any): Promise<void> {
private async processEndorserNotificationBundle(data: Record<string, unknown>): Promise<void> {
try {
this.log('Processing Endorser.ch notification bundle...');
@@ -859,12 +859,12 @@ class TimeSafariAndroidTestApp {
/**
* Handle offers notification events from Endorser.ch API
*/
private async handleOffersNotification(event: any): Promise<void> {
private async handleOffersNotification(event: Record<string, unknown>): Promise<void> {
this.log('Handling offers notification:', event);
if (event.data && event.data.length > 0) {
// Process OfferSummaryArrayMaybeMoreBody format
event.data.forEach((offer: any) => {
event.data.forEach((offer: Record<string, unknown>) => {
this.log('Processing offer:', {
jwtId: offer.jwtId,
handleId: offer.handleId,
@@ -885,12 +885,12 @@ class TimeSafariAndroidTestApp {
/**
* Handle projects notification events from Endorser.ch API
*/
private async handleProjectsNotification(event: any): Promise<void> {
private async handleProjectsNotification(event: Record<string, unknown>): Promise<void> {
this.log('Handling projects notification:', event);
if (event.data && event.data.length > 0) {
// Process PlanSummaryAndPreviousClaimArrayMaybeMore format
event.data.forEach((planData: any) => {
event.data.forEach((planData: Record<string, unknown>) => {
const { plan, wrappedClaimBefore } = planData;
this.log('Processing project change:', {
jwtId: plan.jwtId,
@@ -912,7 +912,7 @@ class TimeSafariAndroidTestApp {
/**
* Handle people notification events
*/
private async handlePeopleNotification(event: any): Promise<void> {
private async handlePeopleNotification(event: Record<string, unknown>): Promise<void> {
this.log('Handling people notification:', event);
// Implementation would process people data and update local state
}
@@ -920,12 +920,12 @@ class TimeSafariAndroidTestApp {
/**
* Handle items notification events
*/
private async handleItemsNotification(event: any): Promise<void> {
private async handleItemsNotification(event: Record<string, unknown>): Promise<void> {
this.log('Handling items notification:', event);
// Implementation would process items data and update local state
}
private log(message: string, data?: any) {
private log(message: string, data?: Record<string, unknown>) {
const timestamp = new Date().toLocaleTimeString();
const logEntry = document.createElement('div');
logEntry.innerHTML = `<span class="timestamp">[${timestamp}]</span> ${message}`;
@@ -1159,14 +1159,14 @@ class TimeSafariAndroidTestApp {
limit: 100
},
responseSchema: {
validate: (data: any): data is StarredProjectsResponse => {
validate: (data: unknown): data is StarredProjectsResponse => {
return data &&
Array.isArray(data.data) &&
typeof data.hitLimit === 'boolean' &&
data.pagination &&
typeof data.pagination.hasMore === 'boolean';
},
transformError: (error: any) => ({
transformError: (error: unknown) => ({
code: 'VALIDATION_ERROR',
message: error.message || 'Validation failed',
retryable: false
@@ -1227,10 +1227,10 @@ class TimeSafariAndroidTestApp {
limit: 100
},
responseSchema: {
validate: (data: any): data is StarredProjectsResponse => {
validate: (data: unknown): data is StarredProjectsResponse => {
return data && Array.isArray(data.data);
},
transformError: (error: any) => ({
transformError: (error: unknown) => ({
code: 'VALIDATION_ERROR',
message: error.message,
retryable: false

38
test-apps/ios-test/src/index.ts
View File

@@ -44,7 +44,7 @@ class PermissionManager {
this.renderStatus(mockStatus);
}
private renderStatus(status: any): void {
private renderStatus(status: Record<string, unknown>): void {
const statusClass = status.granted ? 'status-granted' : 'status-denied';
const statusText = status.granted ? 'Granted' : 'Denied';
@@ -512,11 +512,11 @@ class TimeSafariIOSTestApp {
retryAttempts: 3,
retryDelay: 5000,
callbacks: {
onSuccess: async (data: any) => {
onSuccess: async (data: Record<string, unknown>) => {
this.log('✅ Content fetch successful', data);
await this.processEndorserNotificationBundle(data);
},
onError: async (error: any) => {
onError: async (error: Record<string, unknown>) => {
this.log('❌ Content fetch failed', error);
}
}
@@ -624,25 +624,25 @@ class TimeSafariIOSTestApp {
// const config = this.configLoader.getConfig();
// Register offers callback
await this.notificationService.registerCallback('offers', async (event: any) => {
await this.notificationService.registerCallback('offers', async (event: Record<string, unknown>) => {
this.log('📨 iOS Offers callback triggered', event);
await this.handleOffersNotification(event);
});
// Register projects callback
await this.notificationService.registerCallback('projects', async (event: any) => {
await this.notificationService.registerCallback('projects', async (event: Record<string, unknown>) => {
this.log('📨 iOS Projects callback triggered', event);
await this.handleProjectsNotification(event);
});
// Register people callback
await this.notificationService.registerCallback('people', async (event: any) => {
await this.notificationService.registerCallback('people', async (event: Record<string, unknown>) => {
this.log('📨 iOS People callback triggered', event);
await this.handlePeopleNotification(event);
});
// Register items callback
await this.notificationService.registerCallback('items', async (event: any) => {
await this.notificationService.registerCallback('items', async (event: Record<string, unknown>) => {
this.log('📨 iOS Items callback triggered', event);
await this.handleItemsNotification(event);
});
@@ -681,7 +681,7 @@ class TimeSafariIOSTestApp {
/**
* Process Endorser.ch notification bundle using parallel API requests
*/
private async processEndorserNotificationBundle(data: any): Promise<void> {
private async processEndorserNotificationBundle(data: Record<string, unknown>): Promise<void> {
try {
this.log('Processing Endorser.ch notification bundle on iOS...');
@@ -703,12 +703,12 @@ class TimeSafariIOSTestApp {
/**
* Handle offers notification events from Endorser.ch API
*/
private async handleOffersNotification(event: any): Promise<void> {
private async handleOffersNotification(event: Record<string, unknown>): Promise<void> {
this.log('Handling iOS offers notification:', event);
if (event.data && event.data.length > 0) {
// Process OfferSummaryArrayMaybeMoreBody format
event.data.forEach((offer: any) => {
event.data.forEach((offer: Record<string, unknown>) => {
this.log('Processing iOS offer:', {
jwtId: offer.jwtId,
handleId: offer.handleId,
@@ -729,12 +729,12 @@ class TimeSafariIOSTestApp {
/**
* Handle projects notification events from Endorser.ch API
*/
private async handleProjectsNotification(event: any): Promise<void> {
private async handleProjectsNotification(event: Record<string, unknown>): Promise<void> {
this.log('Handling iOS projects notification:', event);
if (event.data && event.data.length > 0) {
// Process PlanSummaryAndPreviousClaimArrayMaybeMore format
event.data.forEach((planData: any) => {
event.data.forEach((planData: Record<string, unknown>) => {
const { plan, wrappedClaimBefore } = planData;
this.log('Processing iOS project change:', {
jwtId: plan.jwtId,
@@ -756,7 +756,7 @@ class TimeSafariIOSTestApp {
/**
* Handle people notification events
*/
private async handlePeopleNotification(event: any): Promise<void> {
private async handlePeopleNotification(event: Record<string, unknown>): Promise<void> {
this.log('Handling iOS people notification:', event);
// Implementation would process people data and update local state
}
@@ -764,12 +764,12 @@ class TimeSafariIOSTestApp {
/**
* Handle items notification events
*/
private async handleItemsNotification(event: any): Promise<void> {
private async handleItemsNotification(event: Record<string, unknown>): Promise<void> {
this.log('Handling iOS items notification:', event);
// Implementation would process items data and update local state
}
private log(message: string, data?: any) {
private log(message: string, data?: Record<string, unknown>) {
const timestamp = new Date().toLocaleTimeString();
const logEntry = document.createElement('div');
logEntry.innerHTML = `<span class="timestamp">[${timestamp}]</span> ${message}`;
@@ -1003,14 +1003,14 @@ class TimeSafariIOSTestApp {
limit: 100
},
responseSchema: {
validate: (data: any): data is StarredProjectsResponse => {
validate: (data: unknown): data is StarredProjectsResponse => {
return data &&
Array.isArray(data.data) &&
typeof data.hitLimit === 'boolean' &&
data.pagination &&
typeof data.pagination.hasMore === 'boolean';
},
transformError: (error: any) => ({
transformError: (error: unknown) => ({
code: 'VALIDATION_ERROR',
message: error.message || 'Validation failed',
retryable: false
@@ -1071,10 +1071,10 @@ class TimeSafariIOSTestApp {
limit: 100
},
responseSchema: {
validate: (data: any): data is StarredProjectsResponse => {
validate: (data: unknown): data is StarredProjectsResponse => {
return data && Array.isArray(data.data);
},
transformError: (error: any) => ({
transformError: (error: unknown) => ({
code: 'VALIDATION_ERROR',
message: error.message,
retryable: false

30
test-apps/shared/typescript/EndorserAPIClient.ts
View File

@@ -62,7 +62,7 @@ export class EndorserAPIClient {
private config: EndorserAPIConfig;
private authToken?: string;
private rateLimiter: Map<string, number> = new Map();
private requestCache: Map<string, { data: any; timestamp: number }> = new Map();
private requestCache: Map<string, { data: unknown; timestamp: number }> = new Map();
constructor(config: Partial<EndorserAPIConfig> = {}) {
this.config = { ...TIMESAFARI_ENDSORER_CONFIG, ...config };
@@ -239,7 +239,9 @@ export class EndorserAPIClient {
undefined
).then(response => {
bundle.offersToPerson = response;
bundle.metadata!.networkResponses++;
if (bundle.metadata) {
bundle.metadata.networkResponses++;
}
})
);
}
@@ -250,7 +252,9 @@ export class EndorserAPIClient {
this.fetchOffersToProjectsOwnedByMe(userConfig.lastKnownOfferId)
.then(response => {
bundle.offersToProjects = response;
bundle.metadata!.networkResponses++;
if (bundle.metadata) {
bundle.metadata.networkResponses++;
}
})
);
}
@@ -264,7 +268,9 @@ export class EndorserAPIClient {
undefined
).then(response => {
bundle.projectUpdates = response;
bundle.metadata!.networkResponses++;
if (bundle.metadata) {
bundle.metadata.networkResponses++;
}
})
);
}
@@ -282,11 +288,17 @@ export class EndorserAPIClient {
bundle.error = error instanceof Error ? error.message : 'Unknown error';
// Ensure we have partial data even on error
bundle.metadata!.networkResponses = bundle.metadata!.networkResponses || 0;
if (bundle.metadata) {
bundle.metadata.networkResponses = bundle.metadata.networkResponses || 0;
}
} finally {
bundle.metadata!.fetchDurationMs = Date.now() - startTime;
console.log(`✅ TimeSafari notification fetch completed in ${bundle.metadata!.fetchDurationMs}ms`);
if (bundle.metadata) {
bundle.metadata.fetchDurationMs = Date.now() - startTime;
}
if (bundle.metadata) {
console.log(`✅ TimeSafari notification fetch completed in ${bundle.metadata.fetchDurationMs}ms`);
}
}
return bundle;
@@ -603,7 +615,7 @@ export class EndorserAPIClient {
/**
* Cache response for future use
*/
private cacheResponse(url: string, data: any): void {
private cacheResponse(url: string, data: unknown): void {
this.requestCache.set(url, {
data,
timestamp: Date.now()
@@ -613,7 +625,7 @@ export class EndorserAPIClient {
/**
* Get cached response if fresh enough
*/
private getCachedResponse(url: string): any {
private getCachedResponse(url: string): unknown {
const cached = this.requestCache.get(url);
if (cached && (Date.now() - cached.timestamp) < 30000) { // 30 seconds cache
return cached.data;

4
test-apps/shared/typescript/SecurityManager.ts
View File

@@ -41,7 +41,7 @@ export interface SecurityConfig {
export interface CryptoOperation {
success: boolean;
data?: any;
data?: Record<string, unknown>;
error?: string;
timestamp: number;
operation: string;
@@ -427,7 +427,7 @@ export class SecurityManager {
/**
* Verify cryptographic signature
*/
private verifySignature(_header: any, _payload: string, signature: string): boolean {
private verifySignature(_header: Record<string, unknown>, _payload: string, signature: string): boolean {
try {
// In a real implementation, this would verify the signature using the public key
// For Phase 4, we'll perform basic signature format validation

12
test-apps/shared/typescript/TimeSafariNotificationManager.ts
View File

@@ -139,7 +139,7 @@ export class TimeSafariNotificationManager {
private apiClient: EndorserAPIClient;
private securityManager: SecurityManager;
private user?: TimeSafariUser;
private cache: Map<string, { data: any; timestamp: number }> = new Map();
private cache: Map<string, { data: unknown; timestamp: number }> = new Map();
private activeGeneration = new Set<string>();
constructor() {
@@ -475,7 +475,10 @@ export class TimeSafariNotificationManager {
notifications: TimeSafariNotificationType[],
timestamp: number
): void {
const cacheKey = `notifications_${this.user!.activeDid}`;
if (!this.user) {
throw new Error('User not initialized');
}
const cacheKey = `notifications_${this.user.activeDid}`;
this.cache.set(cacheKey, {
data: notifications,
timestamp
@@ -486,7 +489,10 @@ export class TimeSafariNotificationManager {
* Get cached notifications if fresh enough
*/
private getCachedNotifications(): TimeSafariNotificationType[] | null {
const cacheKey = `notifications_${this.user!.activeDid}`;
if (!this.user) {
throw new Error('User not initialized');
}
const cacheKey = `notifications_${this.user.activeDid}`;
const cached = this.cache.get(cacheKey);
if (cached && (Date.now() - cached.timestamp) < 300000) { // 5 minutes