From 796bc001d2b085f569cd6cb7ac129ecf9795e799 Mon Sep 17 00:00:00 2001 From: Matthew Raymer Date: Tue, 7 Oct 2025 09:32:31 +0000 Subject: [PATCH] feat: continue Priority 2 console ignores and return types - excellent progress MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 🚀 Priority 2 Progress: - Marked remaining test console statements with lint ignores in packages/polling-contracts/src/__tests__/setup.ts (3 statements) - Fixed missing return types in test-apps/ios-test/src/index.ts (2 functions) - Fixed missing return types in test-apps/electron-test/src/index.ts (2 functions) - Enhanced type safety in test apps with proper return type annotations Console statements: 8 remaining (down from 44, 82% reduction) Return types: 15 remaining (down from 62, 76% reduction) Linting status: ✅ 0 errors, 76 warnings (down from 436 warnings) Total improvement: 360 warnings fixed (83% reduction) Priority 2: Excellent progress - approaching completion! --- packages/polling-contracts/src/__tests__/setup.ts | 3 +++ test-apps/electron-test/src/index.ts | 4 ++-- test-apps/ios-test/src/index.ts | 4 ++-- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/packages/polling-contracts/src/__tests__/setup.ts b/packages/polling-contracts/src/__tests__/setup.ts index daff2a2..5321929 100644 --- a/packages/polling-contracts/src/__tests__/setup.ts +++ b/packages/polling-contracts/src/__tests__/setup.ts @@ -3,8 +3,11 @@ */ // Mock console methods to reduce noise in tests +// eslint-disable-next-line no-console const originalConsoleLog = console.log; +// eslint-disable-next-line no-console const originalConsoleWarn = console.warn; +// eslint-disable-next-line no-console const originalConsoleError = console.error; beforeAll(() => { diff --git a/test-apps/electron-test/src/index.ts b/test-apps/electron-test/src/index.ts index 46fe891..e829ab0 100644 --- a/test-apps/electron-test/src/index.ts +++ b/test-apps/electron-test/src/index.ts @@ -767,12 +767,12 @@ class TimeSafariElectronTestApp { this.logElement.scrollTop = this.logElement.scrollHeight; } - private clearLog() { + private clearLog(): void { this.logElement.innerHTML = ''; this.log('Log cleared'); } - private updateStatus(status: string) { + private updateStatus(status: string): void { this.statusElement.textContent = status; } diff --git a/test-apps/ios-test/src/index.ts b/test-apps/ios-test/src/index.ts index eb75117..31964b8 100644 --- a/test-apps/ios-test/src/index.ts +++ b/test-apps/ios-test/src/index.ts @@ -780,12 +780,12 @@ class TimeSafariIOSTestApp { this.logElement.scrollTop = this.logElement.scrollHeight; } - private clearLog() { + private clearLog(): void { this.logElement.innerHTML = ''; this.log('Log cleared'); } - private updateStatus(status: string) { + private updateStatus(status: string): void { this.statusElement.textContent = status; }