WIP: iOS Share Target Reliability #235

Draft
jose wants to merge 31 commits from fix/ios-share-target-reliability into master
4 changed files with 3 additions and 50 deletions
Showing only changes of commit b48ab3dc42 - Show all commits

View File

@@ -108,9 +108,7 @@ public class SharedImageUtility {
"shareExtensionLastStart": NSNull(),
"sharedPhotoShareId": NSNull(),
"sharedPhotoFilePath": NSNull(),
"fileExists": false,
// TEMPORARY SHARE TARGET DIAGNOSTICS
"pendingShareExists": false
"fileExists": false
]
}
@@ -125,23 +123,13 @@ public class SharedImageUtility {
fileExists = false
}
// TEMPORARY SHARE TARGET DIAGNOSTICS
let pendingShareExists = (
shareExtensionLastStart != nil ||
shareId != nil ||
filePath != nil ||
fileExists == true
)
print("[ShareTarget] getShareExtensionDiagnostics shareExtensionLastStart=\(shareExtensionLastStart ?? "nil") sharedPhotoShareId=\(shareId ?? "nil") sharedPhotoFilePath=\(filePath ?? "nil") fileExists=\(fileExists) pendingShareExists=\(pendingShareExists)")
print("[ShareTarget] getShareExtensionDiagnostics shareExtensionLastStart=\(shareExtensionLastStart ?? "nil") sharedPhotoShareId=\(shareId ?? "nil") sharedPhotoFilePath=\(filePath ?? "nil") fileExists=\(fileExists)")
return [
"shareExtensionLastStart": shareExtensionLastStart ?? NSNull(),
"sharedPhotoShareId": shareId ?? NSNull(),
"sharedPhotoFilePath": filePath ?? NSNull(),
"fileExists": fileExists,
// TEMPORARY SHARE TARGET DIAGNOSTICS
"pendingShareExists": pendingShareExists
"fileExists": fileExists
]
}

View File

@@ -359,37 +359,6 @@ async function checkForSharedImageAndNavigate() {
}
try {
// TEMPORARY SHARE TARGET DIAGNOSTICS
if (Capacitor.getPlatform() === "ios") {
try {
const diagnostics = await SharedImage.getShareExtensionDiagnostics();
// TEMPORARY SHARE TARGET DIAGNOSTICS
console.info(
"[ShareTarget] Cold-start state",
JSON.stringify({
pendingShareExists: diagnostics.pendingShareExists,
shareExtensionLastStart: diagnostics.shareExtensionLastStart,
sharedPhotoShareId: diagnostics.sharedPhotoShareId,
sharedPhotoFilePath: diagnostics.sharedPhotoFilePath,
fileExists: diagnostics.fileExists,
currentRoute: router.currentRoute.value.fullPath,
appReady: true,
timestamp: new Date().toISOString(),
}),
);
logger.info(`[ShareTarget] Diagnostics ${JSON.stringify(diagnostics)}`);
} catch (diagnosticsError) {
logger.info(
`[ShareTarget] Diagnostics ${JSON.stringify({
error:
diagnosticsError instanceof Error
? diagnosticsError.message
: String(diagnosticsError),
})}`,
);
}
}
logger.debug("[Main] 🔍 Checking for shared image on app activation");
const imageResult = await checkAndStoreNativeSharedImage();

View File

@@ -29,8 +29,6 @@ export class SharedImagePluginWeb
sharedPhotoShareId: null,
sharedPhotoFilePath: null,
fileExists: false,
// TEMPORARY SHARE TARGET DIAGNOSTICS
pendingShareExists: false,
};
}
}

View File

@@ -12,8 +12,6 @@ export interface ShareExtensionDiagnostics {
sharedPhotoShareId: string | null;
sharedPhotoFilePath: string | null;
fileExists: boolean;
// TEMPORARY SHARE TARGET DIAGNOSTICS
pendingShareExists: boolean;
}
export interface SharedImagePlugin {