From e647af0777515a806176eab65239c149dfc4b278 Mon Sep 17 00:00:00 2001 From: Jose Olarte III Date: Fri, 24 Oct 2025 13:26:36 +0800 Subject: [PATCH 1/9] refactor: convert entity display to list style - Switch from grid display to list layout for persons and projects - Re-styled special entities (unnamed, You) to match - Added max-height limit to list in preparation for scrolling and displaying more items --- src/assets/styles/tailwind.css | 2 +- src/components/EntityGrid.vue | 17 ++----------- src/components/PersonCard.vue | 38 +++++++++++++--------------- src/components/ProjectCard.vue | 35 ++++++++++++------------- src/components/ShowAllCard.vue | 20 +++++++-------- src/components/SpecialEntityCard.vue | 13 +++++----- 6 files changed, 55 insertions(+), 70 deletions(-) diff --git a/src/assets/styles/tailwind.css b/src/assets/styles/tailwind.css index 03063394..396d6b96 100644 --- a/src/assets/styles/tailwind.css +++ b/src/assets/styles/tailwind.css @@ -38,7 +38,7 @@ } .dialog { - @apply bg-white p-4 rounded-lg w-full max-w-lg; + @apply bg-white p-4 rounded-lg w-full max-w-lg max-h-[calc(100vh-3rem)] overflow-y-auto; } /* Markdown content styling to restore list elements */ diff --git a/src/components/EntityGrid.vue b/src/components/EntityGrid.vue index ec5fe236..4e49c77c 100644 --- a/src/components/EntityGrid.vue +++ b/src/components/EntityGrid.vue @@ -2,7 +2,7 @@ GiftedDialog.vue to provide a reusable grid layout * for displaying people, projects, and special entities with selection. * * @author Matthew Raymer */ @@ -79,7 +71,6 @@ import { Component, Prop, Vue, Emit } from "vue-facing-decorator"; import PersonCard from "./PersonCard.vue"; import ProjectCard from "./ProjectCard.vue"; import SpecialEntityCard from "./SpecialEntityCard.vue"; -import ShowAllCard from "./ShowAllCard.vue"; import { Contact } from "../db/tables/contacts"; import { PlanData } from "../interfaces/records"; import { NotificationIface } from "../constants/app"; @@ -93,7 +84,6 @@ import { UNNAMED_ENTITY_NAME } from "@/constants/entities"; * - Special entity integration (You, Unnamed) * - Conflict detection integration * - Empty state messaging - * - Show All navigation * - Event delegation for entity selection * - Warning notifications for conflicted entities * - Template streamlined with computed CSS properties @@ -104,7 +94,6 @@ import { UNNAMED_ENTITY_NAME } from "@/constants/entities"; PersonCard, ProjectCard, SpecialEntityCard, - ShowAllCard, }, }) export default class EntityGrid extends Vue { @@ -144,14 +133,6 @@ export default class EntityGrid extends Vue { @Prop({ default: true }) youSelectable!: boolean; - /** Route name for "Show All" navigation */ - @Prop({ default: "" }) - showAllRoute!: string; - - /** Query parameters for "Show All" navigation */ - @Prop({ default: () => ({}) }) - showAllQueryParams!: Record; - /** Notification function from parent component */ @Prop() notify?: (notification: NotificationIface, timeout?: number) => void; @@ -160,10 +141,6 @@ export default class EntityGrid extends Vue { @Prop({ default: "other party" }) conflictContext!: string; - /** Whether to hide the "Show All" navigation */ - @Prop({ default: false }) - hideShowAll!: boolean; - /** * Function to determine which entities to display (allows parent control) * @@ -233,15 +210,6 @@ export default class EntityGrid extends Vue { } } - /** - * Whether to show the "Show All" navigation - */ - get shouldShowAll(): boolean { - return ( - !this.hideShowAll && this.entities.length > 0 && this.showAllRoute !== "" - ); - } - /** * Whether the "You" entity is conflicted */ diff --git a/src/components/EntitySelectionStep.vue b/src/components/EntitySelectionStep.vue index 2fb6bcac..b4fada43 100644 --- a/src/components/EntitySelectionStep.vue +++ b/src/components/EntitySelectionStep.vue @@ -3,10 +3,9 @@ from GiftedDialog.vue to handle the complete step 1 * entity selection interface with dynamic labeling and grid display. * * Features: * - Dynamic step labeling based on context * - EntityGrid integration for unified entity display * - Conflict detection and prevention * - Special entity handling (You, Unnamed) * - -Show All navigation with context preservation * - Cancel functionality * - Event -delegation for entity selection * - Warning notifications for conflicted -entities * - Template streamlined with computed CSS properties * * @author -Matthew Raymer */ +Cancel functionality * - Event delegation for entity selection * - Warning +notifications for conflicted entities * - Template streamlined with computed CSS +properties * * @author Matthew Raymer */