trent_larson/crowd-funder-for-time-pwa
4
1
Fork 2
Code Issues Pull Requests 22 Releases 5 Wiki Activity

fix some formatting of web-push doc #60

Merged
anomalist merged 4 commits from plan-loc into master 2023-08-28 05:26:45 +00:00
Conversation 4 Commits 4 Files Changed 1 +21 -16
trentlarson commented 2023-08-27 16:49:02 +00:00
Owner
Copy Link

Note that I changed some indentation & moved some things according to my guess at the intent, so double-check.

Note that I changed some indentation & moved some things according to my guess at the intent, so double-check.
trentlarson added 1 commit 2023-08-27 16:49:02 +00:00
fix some formatting of web-push doc dc54006fca
trentlarson requested review from anomalist 2023-08-27 16:49:08 +00:00
trentlarson added 1 commit 2023-08-27 16:51:31 +00:00
Merge branch 'master' into plan-loc b171e1ae13
trentlarson added 1 commit 2023-08-27 16:58:23 +00:00
take a stab at the meaning of the "options" in the web-push doc 12de3dec4f
trentlarson commented 2023-08-27 17:00:53 +00:00
Author
Owner
Copy Link

Ah... I see now that the "options" are part of the "subscribe()" call.

I'm fine if you want to move it back, maybe with a hint, like: "The subscribe(options) method returns..."

Ah... I see now that the "options" are part of the "subscribe()" call. I'm fine if you want to move it back, maybe with a hint, like: "The subscribe(options) method returns..."
trentlarson added 1 commit 2023-08-27 18:12:55 +00:00
Merge branch 'master' into plan-loc 2ccfb283b4
trentlarson commented 2023-08-27 18:13:44 +00:00
Author
Owner
Copy Link

Note that last merge: I pushed directly onto master a change to the test domain (to remove the port, now that I have certs set up properly).

Note that last merge: I pushed directly onto master a change to the test domain (to remove the port, now that I have certs set up properly).
trentlarson commented 2023-08-27 18:22:48 +00:00
Author
Owner
Copy Link

We should include a link to https://gitea.anomalistdesign.com/trent_larson/endorser-push-server

We should include a link to https://gitea.anomalistdesign.com/trent_larson/endorser-push-server
trentlarson commented 2023-08-27 19:16:13 +00:00
Author
Owner
Copy Link

OK, so I can see that it runs. I'm sure I could take the time to plug this stuff into some of our pages, but I think it'll be faster for you to do.

If you add a Dockerfile to the endorser-push-server then I'll install and run it at test-webpush.timesafari.app

OK, so I can see that it runs. I'm sure I could take the time to plug this stuff into some of our pages, but I think it'll be faster for you to do. If you add a Dockerfile to the endorser-push-server then I'll install and run it at test-webpush.timesafari.app
anomalist merged commit 87139f203c into master 2023-08-28 05:26:45 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
anomalist
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
anomalist jose jsnbuchanan kentbull trentlarson
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: trent_larson/crowd-funder-for-time-pwa#60
Delete Branch "plan-loc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?