fix some formatting of web-push doc #60

Merged
anomalist merged 4 commits from plan-loc into master 1 year ago
Owner

Note that I changed some indentation & moved some things according to my guess at the intent, so double-check.

Note that I changed some indentation & moved some things according to my guess at the intent, so double-check.
trentlarson added 1 commit 1 year ago
trentlarson requested review from anomalist 1 year ago
trentlarson added 1 commit 1 year ago
trentlarson added 1 commit 1 year ago
Poster
Owner

Ah... I see now that the "options" are part of the "subscribe()" call.

I'm fine if you want to move it back, maybe with a hint, like: "The subscribe(options) method returns..."

Ah... I see now that the "options" are part of the "subscribe()" call. I'm fine if you want to move it back, maybe with a hint, like: "The subscribe(options) method returns..."
trentlarson added 1 commit 1 year ago
Poster
Owner

Note that last merge: I pushed directly onto master a change to the test domain (to remove the port, now that I have certs set up properly).

Note that last merge: I pushed directly onto master a change to the test domain (to remove the port, now that I have certs set up properly).
Poster
Owner
We should include a link to https://gitea.anomalistdesign.com/trent_larson/endorser-push-server
Poster
Owner

OK, so I can see that it runs. I'm sure I could take the time to plug this stuff into some of our pages, but I think it'll be faster for you to do.

If you add a Dockerfile to the endorser-push-server then I'll install and run it at test-webpush.timesafari.app

OK, so I can see that it runs. I'm sure I could take the time to plug this stuff into some of our pages, but I think it'll be faster for you to do. If you add a Dockerfile to the endorser-push-server then I'll install and run it at test-webpush.timesafari.app
anomalist merged commit 87139f203c into master 1 year ago

Reviewers

anomalist was requested for review 1 year ago
The pull request has been merged as 87139f203c.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.