Copy important settings from previous MASTER settings #202

2025-09-23T02:23:09Z

trentlarson commented

2025-09-23 02:23:09 +00:00

These settings were set by "saveSettings" and thus changed the MASTER settings record, and that's deleted in the 004 migration. So let's copy them before it's deleted.

I realize that this migration change breaks our process because we don't like to edit previous migrations; however, it really has to be done as part of 004 before the MASTER settings are deleted. Thankfully we haven't released this yet.

Also: remove a method that depended on the existence of an implicit variable. (That might be fine if we can typecheck something, but I worry about any mistaken usage in a class that doesn't have activeDid.)

These settings were set by "saveSettings" and thus changed the MASTER settings record, and that's deleted in the 004 migration. So let's copy them before it's deleted. I realize that this migration change breaks our process because we don't like to edit previous migrations; however, it really has to be done as part of 004 before the MASTER settings are deleted. Thankfully we haven't released this yet. Also: remove a method that depended on the existence of an implicit variable. (That might be fine if we can typecheck something, but I worry about any mistaken usage in a class that doesn't have `activeDid`.)

trentlarson added 2 commits 2025-09-23 02:23:10 +00:00

feat: copy important old settings from master record to others e8e0f315f8

chore: remove saveMySettings that depended on an implicit variable c0f407eb72

trentlarson added 1 commit 2025-09-24 15:09:29 +00:00

fix: remove settings, too, when deleting an identity 46d7fee95e

trentlarson added 2 commits 2025-09-25 01:28:23 +00:00

fix: linting f5bea24921

fix: don't lose the name when running the migration d6524cbd43

trentlarson merged commit c7276f0b4d into master

2025-09-25 01:29:33 +00:00

trentlarson referenced this issue from a commit

2025-09-25 01:29:33 +00:00