Labels Milestones

Copy important settings from previous MASTER settings #202

Merged

trentlarson merged 5 commits from copy-settings into master 2 weeks ago

Conversation 0 Commits 5 Files Changed 6

trentlarson commented 3 weeks ago

Owner

These settings were set by "saveSettings" and thus changed the MASTER settings record, and that's deleted in the 004 migration. So let's copy them before it's deleted.

I realize that this migration change breaks our process because we don't like to edit previous migrations; however, it really has to be done as part of 004 before the MASTER settings are deleted. Thankfully we haven't released this yet.

Also: remove a method that depended on the existence of an implicit variable. (That might be fine if we can typecheck something, but I worry about any mistaken usage in a class that doesn't have activeDid.)

These settings were set by "saveSettings" and thus changed the MASTER settings record, and that's deleted in the 004 migration. So let's copy them before it's deleted. I realize that this migration change breaks our process because we don't like to edit previous migrations; however, it really has to be done as part of 004 before the MASTER settings are deleted. Thankfully we haven't released this yet. Also: remove a method that depended on the existence of an implicit variable. (That might be fine if we can typecheck something, but I worry about any mistaken usage in a class that doesn't have `activeDid`.)

trentlarson added 2 commits 3 weeks ago

e8e0f315f8 feat: copy important old settings from master record to others

c0f407eb72 chore: remove saveMySettings that depended on an implicit variable

trentlarson added 1 commit 2 weeks ago

46d7fee95e fix: remove settings, too, when deleting an identity

trentlarson added 2 commits 2 weeks ago

f5bea24921 fix: linting

d6524cbd43 fix: don't lose the name when running the migration

trentlarson merged commit c7276f0b4d into master 2 weeks ago

trentlarson referenced this issue from a commit 2 weeks ago

Merge pull request 'Copy important settings from previous MASTER settings' (#202) from copy-settings into master

trentlarson deleted branch copy-settings 2 weeks ago

The pull request has been merged as c7276f0b4d.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

No items

No Label

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.