DIDView: validate DID format #176

Merged

jose merged 8 commits from didview-invalid-did-handling into master 2 weeks ago

jose commented 3 weeks ago

Owner

Add DID validation using isDid() function to prevent invalid DIDs from loading current user's info
Show error message and redirect to HomeView for invalid DID formats (e.g., /did/0)
Import NOTIFY_CONTACT_INVALID_DID constant for consistent error messaging

Resolves: DIDView loading current user's info for invalid DID parameters

jose added 1 commit 3 weeks ago

74c70c7fa0 fix(DIDView): validate DID format before processing URL parameters

- Add DID validation using isDid() function to prevent invalid DIDs from loading current user's info
- Show error message and redirect to HomeView for invalid DID formats (e.g., /did/0)
- Import NOTIFY_CONTACT_INVALID_DID constant for consistent error messaging

Resolves: DIDView loading current user's info for invalid DID parameters

trentlarson reviewed 2 weeks ago

test-playwright/00-noid-tests.spec.ts

trentlarson reviewed 2 weeks ago

test-playwright/00-noid-tests.spec.ts Outdated

jose added 19 commits 2 weeks ago

9f976f011a Fix: account for new Export Data dialog

- Stricter targeting of buttons since Register and Export Data dialogs appear on screen at the same time
- Locate success notification first since it appears first (and cannot be "clicked" through the overlapping dialog-overlay)

f31eb5f6c9 Merge branch 'master' into playwright-test-60-fix

d663c52f2d feat: implement Build Architecture Guard with Husky hooks

- Add pre-commit and pre-push hooks for build file protection
- Create comprehensive guard script for BUILDING.md validation
- Add npm scripts for guard setup and testing
- Integrate with existing build system

d5786e5131 docs: add comprehensive Build Architecture Guard documentation

- Update main README with guard system overview
- Create detailed guard implementation guide
- Add PR template documentation and usage examples
- Document opt-in hook activation process

7b31ea0143 feat: add Build Architecture Guard PR template

- Create structured template for build-related changes
- Include L1/L2/L3 change classification
- Require BUILDING.md updates for sensitive file changes
- Add artifact SHA256 validation for L3 changes

ae0601281b feat: add markdown validation and auto-fix scripts

- Create validate-markdown.sh for compliance checking
- Add fix-markdown.sh for automatic formatting fixes
- Exclude node_modules from validation scope
- Integrate with npm scripts for easy usage

8336d9d6bd feat: enhance markdown rules for AI generation compliance

- Add AI Generation Guidelines with alwaysApply: true
- Extend globs to include .mdc files
- Ensure AI agents follow rules during content creation
- Improve markdown automation system integration

80aecbcbbc feat: add Build Architecture Guard MDC directive

- Create comprehensive guard rules for build system protection
- Define protected file patterns and validation requirements
- Include risk matrix and required validation checklists
- Add emergency procedures and rollback playbooks

963ff9234f feat: implement comprehensive Build Architecture Guard system

- Add Husky Git hooks for pre-commit and pre-push validation
- Create guard script for BUILDING.md update enforcement
- Implement PR template with L1/L2/L3 change classification
- Add markdown validation and auto-fix scripts
- Create comprehensive documentation and MDC rules
- Ensure zero-disruption deployment with opt-in activation

2d17bfd3b4 docs: comprehensive documentation updates and modernization

- Update BUILDING.md with current build system information
- Modernize various README files across the project
- Update CHANGELOG.md with recent changes
- Improve documentation consistency and formatting
- Update platform-specific documentation (iOS, Electron, Docker)
- Enhance test documentation and build guides

51b8a0b0a8 refactor: complete migration from GitHub to Gitea

- Remove all GitHub-specific workflows and configurations
- Update .dockerignore to exclude .github directory
- Clean up GitHub Actions workflows and branch protection rules
- Complete transition to Gitea Actions and Husky hooks

d7733e4c41 feat: add markdown automation setup script

- Create setup script for markdown pre-commit hooks
- Automate installation of markdownlint and related tools
- Provide easy setup for markdown compliance system

5fc362ad4b feat(cursor): add Harbor Pilot universal directive for technical guides

Add comprehensive Cursor rules file that extends base context with universal
constraints for creating developer-grade, reproducible technical guides.
Includes structured templates, validation checklists, and evidence-backed
documentation standards.

- Establishes 11 required sections for technical guides
- Enforces UTC timestamps and evidence requirements
- Provides Mermaid diagram requirements and API contract templates
- Includes competence and collaboration hooks per base context
- Sets coaching level to standard with 10-minute timeboxing

6afe1c4c13 feat(harbor-pilot): add historical comment management and no time estimates rules

Add two new Harbor Pilot directives to improve code quality and planning:

1. Historical Comment Management: Guidelines for transforming or removing
   obsolete comments into actionable architectural guidance
2. No Time Estimates: Rule prohibiting time estimates in favor of
   phase-based planning with complexity levels and milestones

Both rules are integrated into main Harbor Pilot directive for automatic
application across all operations.

0b9c243969 Merge branch 'master' into playwright-test-60-fix

4391cb2881 feat(harbor-pilot): add Playwright test investigation directive

- Create comprehensive MDC rule for systematic Playwright test failure investigation
- Integrate rule into harbor_pilot_universal.mdc for team-wide access
- Include investigation workflow, diagnostic commands, and evidence-based analysis
- Document specific failure patterns (alert stacking, selector conflicts, timing issues)
- Provide practical examples from recent test failure investigation
- Add investigation commands for error context, trace files, and page snapshots

This rule transforms ad-hoc test debugging into systematic investigation process,
leveraging Playwright's built-in debugging tools for faster root cause identification.

baccb962cf Merge branch 'master' into didview-invalid-did-handling

1365adad92 Test: change expected redirect view

1a77dfb750 Merge branch 'playwright-test-60-fix' into didview-invalid-did-handling

jose commented 2 weeks ago

Poster

Owner

I fixed the tests by:

Making .toHaveURL expect "/" instead of "/contacts" (expected behavior)
Merging a different branch that updates the tests to expect the second dialog after adding a contact

Ran the tests again, and it passed with flying colors! I'll go ahead and merge this back.

jose merged commit 43e7bc1c12 into master 2 weeks ago

jose referenced this issue from a commit 2 weeks ago

Merge pull request 'DIDView: validate DID format' (#176) from didview-invalid-did-handling into master

jose referenced this pull request 2 weeks ago

Fix: account for new Export Data dialog #174

The pull request has been merged as 43e7bc1c12.

No reviewers

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

   // Should redirect to contacts page
   await expect(page).toHaveURL(/.*\/contacts$/);
 });