Show current user in ContactGiftingView #155

Merged

jose merged 13 commits from contact-gifting-current-user into master 1 week ago

jose commented 1 month ago

Owner

"You" is displayed conditionally, similar to GiftedDialog behavior
"Show All" is hidden in GiftedDialog when accessed from ContactGiftingView (redundant)

jose added 1 commit 1 month ago

bed2c7106a Added: current user in ContactGiftingView

- "You" is displayed conditionally, similar to GiftedDialog behavior
- "Show All" is hidden in GiftedDialog when accessed from ContactGiftingView (redundant)

jose changed target branch from build-improvement to master 4 weeks ago

jose added 88 commits 4 weeks ago

861408c7bc Consolidate deep-link paths to be derived from the same source so they don't get out of sync any more.

b0d99e7c1e fix: quick-and-dirty fix to get the correct environment variables

a9a8ba217c bump to version 1.0.3 build 36

dc21e8dac3 bump version number and add '-beta'

33ce6bdb72 fix: invite-one-accept deep link would not route properly

c1477d0266 Merge branch 'master' into deep-link

6d6816d1a8 Merge pull request 'Deep-link fixes' (#145 ) from deep-link into master

Reviewed-on: https://gitea.anomalistdesign.com/trent_larson/crowd-funder-for-time-pwa/pulls/145

ffe8d90161 fix: linting

002f240720 bump to version 1.0.4 and build 37

3fce10ae98 bump version and add "-beta", and update commit hashes in changelog

fd0026ac2d fix problem with repeated bad stringifies of contactMethods on contact export/import

6ddde21a86 Merge pull request 'fix problem with repeated bad stringifies of contactMethods on contact export/import' (#148 ) from fix-contact-import-export into master

Reviewed-on: https://gitea.anomalistdesign.com/trent_larson/crowd-funder-for-time-pwa/pulls/148

64f24dc473 bump to version 1.0.5 and build 38

bcbb80e034 bump version and add "-beta"

5971f0976a chore: Comment out the unused caching utilities (so they're not mistakenly used).

54e5657899 fix: remove code that blanks out the profile image on limit retrieval, which should be unrelated

4e36612388 fix: remove more references to clearAllCaches

9562d3aa32 chore: commentary and verbiage and one stray unnecessary check

eb325871fa chore: add coverage folder to gitignore

9136a9c622 Merge branch 'build-improvement' of ssh://173.199.124.46:222/trent_larson/crowd-funder-for-time-pwa into build-improvement

07c5c6fd31 Convert Vue components to use @Emit decorator instead of manual emits declarations

Replace manual emits declarations with proper @Emit decorator usage across components:
- ActivityListItem: Add @Emit methods for viewImage, loadClaim, confirmClaim
- ContactInputForm: Convert handleQRScan to use @Emit("qr-scan")
- ContactBulkActions: Add @Emit methods for toggle-all-selection, copy-selected
- ContactListHeader: Add @Emit methods for all 5 emitted events
- MembersList: Add @Emit("error") method for error handling
- LargeIdenticonModal: Add @Emit("close") method
- ContactListItem: Add @Emit methods for all 4 emitted events

Update all templates to call emit methods instead of direct $emit calls.
Fix TypeScript type issues with optional parameters.
Resolves Vue warning about undeclared emitted events.

Follows vue-facing-decorator best practices and improves code consistency.

118e93b85a Fix: invalid clean command

9067bec54a fix: Convert searchBoxes arrays to JSON strings in $saveSettings and $updateSettings

- Add _convertSettingsForStorage helper method to handle Settings → SettingsWithJsonStrings conversion
- Fix $saveSettings and $saveUserSettings to properly convert searchBoxes arrays to JSON strings before database storage
- Update SearchAreaView.vue to use array format instead of manual JSON.stringify conversion
- Add comprehensive test UI in PlatformServiceMixinTest.vue with visual feedback and clear demonstration of conversion process
- Document migration strategy for consolidating $updateSettings into $saveSettings to reduce code duplication
- Add deprecation notices to $updateSettings method with clear migration guidance

The fix ensures that searchBoxes arrays are properly converted to JSON strings before database storage, preventing data corruption and maintaining consistency with the SettingsWithJsonStrings type definition. The enhanced test interface provides clear visualization of the conversion process and database storage format.

Migration Strategy:
- $saveSettings: ✅ KEEP (will be primary method after consolidation)
- $updateSettings: ⚠️ DEPRECATED (will be removed in favor of $saveSettings)
- Future: Consolidate to single $saveSettings(changes, did?) method

Files changed:
- src/utils/PlatformServiceMixin.ts: Add conversion helper, fix save methods, add deprecation notices
- src/views/SearchAreaView.vue: Remove manual JSON conversion
- src/test/PlatformServiceMixinTest.vue: Add comprehensive test UI with highlighting
- docs/migration-templates/updateSettings-consolidation-plan.md: Document future consolidation strategy

ca828d45a6 cleanup: Remove unused duplicate type definition files

- Remove src/types/global.d.ts and src/types/modules.d.ts (unused duplicates)
- Keep essential type files: sql.js.d.ts and absurd-sql.d.ts
- Maintain all existing type definitions and functionality

The removed files contained broken import paths and duplicate type declarations
that were never actually used by the codebase. All necessary type support for
@jlongster/sql.js and absurd-sql modules is preserved in the remaining files.

Files removed:
- src/types/global.d.ts (unused, had broken imports)
- src/types/modules.d.ts (unused, had broken imports)

Files kept:
- src/types/sql.js.d.ts (comprehensive @jlongster/sql.js types)
- src/types/absurd-sql.d.ts (comprehensive absurd-sql types)
- src/interfaces/database.ts (core database types)

31711e2ea6 fix: usage of testRecursivelyOnStrings method to match new definition

219a383015 change test port to 8081 (to not conflict with running server) and remove unused "logger" setting

I believe logger is not an option. https://playwright.dev/docs/api/class-testoptions

cbdd54e383 undo port change because it may cause a timeout starting the tests (intermittently)

1180ebd4ca chore: update cursor rulesets

12b43bf684 Ref name change

6d28a7d8a3 Function name change

0582954cfa Remove 'customTitle' variable

2a32903326 chore: more cursor rules updates

433f3c1154 Fix GiftedDialog functionality

- Add description, amountInput, and unitCode parameters to GiftedDialog.open()
- Pass offer details to GiftedDialog in ProjectViewView
- Update ContactsView to handle new GiftedDialog parameters

f4a7d437c8 Fix parameter passing in contact gift dialogs

- Replace @Emit decorator with direct $emit calls in ContactListItem
- Fix DID comparison from loose to strict equality in nameForDid function
- Resolve issue where giver/recipient names showed as "this unnamed user"

The @Emit decorator was not properly spreading array parameters, causing
the parent component to receive arrays instead of separate string parameters.

9cd4551bed docs: add comprehensive GiftedDialog architecture overview

Add detailed analysis of GiftedDialog component architecture including:
- DRY and SOLID principles compliance assessment
- Cognitive load analysis with before/after comparisons
- Architectural complexity remediation plan
- Phased implementation strategy (cognitive load → composable architecture)
- Component hierarchy and dependency analysis
- Performance and security considerations

The document provides actionable recommendations for reducing complexity
while maintaining functionality, with specific code examples and metrics.

8b2c6714ec Merge branch 'build-improvement' of ssh://173.199.124.46:222/trent_larson/crowd-funder-for-time-pwa into build-improvement

404a7cbc71 Add form field preservation in gifting flow

- Preserve description, amount, and unit code when navigating between gifting steps
- Add form field props to EntitySelectionStep and GiftedDialog components
- Update ContactGiftingView to handle form state persistence in URL parameters

e741790d70 Fix ClaimView affirm delivery action

- Add offer context support to gifting flow
- Add offerId prop to EntitySelectionStep for offer fulfillment context
- Pass offerId through GiftedDialog to EntitySelectionStep
- Update ContactGiftingView to handle offerId from route query parameters
- Extract offer details (description, amount, unitCode) for pre-population

c30b94dcc7 Integrate TypeScript type checking into build process with conditional execution

- Add type checking to build scripts for production/test builds only
- Fix TypeScript errors in migration service, router, and platform services
- Add electronAPI type declarations for Electron platform
- Remove type checking from development builds for faster hot reload
- Update tsconfig.node.json to resolve configuration conflicts
- Ensure type safety for production while maintaining fast development workflow

a63ccae9b1 Merge branch 'build-improvement' of ssh://173.199.124.46:222/trent_larson/crowd-funder-for-time-pwa into build-improvement

54bfaafbd0 Fix entity type matching in ClaimView

- Add recipientEntityTypeOverride prop to GiftedDialog component
- Add data-testid and data-recipient-entity-type-override attributes for testing
- Update updateEntityTypes() to respect recipientEntityTypeOverride when set
- Add watcher for recipientEntityTypeOverride prop changes
- Update ClaimView to pass recipient entity type override based on project context
- Improve recipient determination logic in ClaimView for person vs project recipients

197dea48c9 chore: remove comments that moved into ClickUp issues

e5e01040b2 chore: Restore the dev setting for a variable.

fb2ac963bd fix: Adjust VC types.

3d38cb89a9 Fix HomeView registration status by using $accountSettings() instead of $settings()

- Change HomeView to use $accountSettings() method which returns correct isRegistered value
- Remove isRegistered: false default that was overriding database values
- Fix settings override issue where empty defaults were overriding activeDid
- Remove excessive settings tracing logs to clean up console output
- Ensure consistent registration status between HomeView and AccountViewView

The HomeView was incorrectly showing users as unregistered while AccountViewView showed them as registered due to using $settings() (returns null) instead of $accountSettings() (returns correct database value).

371cf763c8 Merge branch 'build-improvement' of ssh://173.199.124.46:222/trent_larson/crowd-funder-for-time-pwa into build-improvement

06f3a4c7c2 Refactor: simplify GiftedDialog with explicit entity type props

Replace complex updateEntityTypes() method with explicit giverEntityType and
recipientEntityType props. This makes the component more declarative and
maintainable by removing hidden logic and making entity type relationships
clear at the call site.

- Remove updateEntityTypes() method and related watchers
- Add explicit giverEntityType and recipientEntityType props with defaults
- Update all views to use inline logic for entity type determination
- Fix entity type preservation in navigation flows
- Enhance query parameter passing for better context preservation
- Fix recipient reset issue in ContactGiftingView
- Resolve entity type mismatch in HomeView project button flow

Files changed:
- GiftedDialog.vue: Remove complex logic, add explicit props
- EntitySelectionStep.vue: Enhanced query parameter handling
- ContactGiftingView.vue: Improved context preservation
- HomeView.vue, ProjectViewView.vue, ClaimView.vue, ContactsView.vue:
  Updated to use explicit entity type props
- Add refactoring documentation

aed16ebe94 Remove PROD_SHARE_DOMAIN constant and unify domain configuration

- Remove hard-coded PROD_SHARE_DOMAIN from src/constants/app.ts
- Update all sharing functionality to use environment-specific APP_SERVER
- Rewrite domain configuration documentation to reflect unified approach
- Simplify domain management with single APP_SERVER constant
- Update README.md examples to use APP_SERVER for all URL generation

This change eliminates the complexity of separate constants for different
URL types and provides consistent environment-specific configuration for
all functionality including sharing.

0bd0e7c332 Fix contact methods JSON string/array duality in PlatformServiceMixin

- Add ContactMaybeWithJsonStrings type usage for internal database operations
- Implement $normalizeContacts() method to handle both JSON string and array formats
- Update $contacts(), $getContact(), and $getAllContacts() to use normalization
- Fix $updateContact() to properly convert contactMethods arrays to JSON strings
- Add validation to filter out malformed contact method objects
- Update ContactEditView to handle malformed data gracefully

Resolves issue where contactMethods could be stored as JSON strings in database
but expected as arrays in components, causing "Cannot create property 'label' on number '0'" errors.

984244117b chore: Remove duplicate checks for bad contact methods.

938cf673fc fix: A 'back' from a DID view page goes back to the list (not to edit again)

32f589b866 Fix Android emulator API connectivity with cleaner build script approach

- Move Android-specific API server logic from common.sh to build-android.sh
- Remove unnecessary ANDROID_BUILD environment variable
- Set localhost:3000 as default in common.sh for all Capacitor builds
- Override to 10.0.2.2:3000 specifically in build-android.sh for Android development
- Fix execution order issue where common.sh ran before ANDROID_BUILD was set
- Maintain proper separation: Android emulator uses 10.0.2.2, iOS simulator uses localhost

b681905abd Upgrade Android API from 35 to 36

Update Android SDK configuration to target API 36 (Android 16):
- Update compileSdkVersion and targetSdkVersion from 35 to 36
- Update suppressUnsupportedCompileSdk from 34 to 36
- Maintains minSdkVersion at 22 for broad device compatibility
- Verified build system compatibility with Gradle 8.13

1d6418b02c Add custom API IP support for Android physical device development

Implement --api-ip parameter for Android builds with smart defaults:
- Defaults to 10.0.2.2 for emulator development when no IP specified
- Supports custom IP for physical device development
- Added npm scripts for common use cases (dev:custom, test:custom)
- Updated help documentation with usage examples
- Created comprehensive documentation with troubleshooting guide

Usage:
  ./scripts/build-android.sh --dev                    # Default 10.0.2.2
  ./scripts/build-android.sh --dev --api-ip 192.168.1.100  # Custom IP

3b1a63468c Add iOS support for custom API IP configuration

Extend custom API IP feature to iOS platform with platform-appropriate defaults:
- Android: Defaults to 10.0.2.2 for emulator, custom IP for physical devices
- iOS: Uses localhost for simulator, custom IP for physical devices
- Added npm scripts for iOS custom IP builds (dev:custom, test:custom)
- Updated documentation to cover both platforms with examples
- Consistent --api-ip parameter across Android and iOS build scripts

Usage:
  ./scripts/build-ios.sh --dev                    # Default localhost
  ./scripts/build-ios.sh --dev --api-ip 192.168.1.100  # Custom IP

974d33b322 Document environment variable precedence and API configuration scheme

Add comprehensive documentation explaining the order of precedence for
environment variables in TimeSafari project. Covers shell script overrides,
platform-specific configurations, .env file usage, and API alignment between
claim and partner APIs. Includes troubleshooting guide and best practices
for maintaining consistent environment configuration across development,
test, and production environments.

b17642fbcb fix: Toast messages were showing numbers. Removed unused function. Clarified tests.

c27caf8887 Fix build script to fail on TypeScript errors

Update measure_time function to properly handle command exit codes:
- Check command success/failure and return appropriate exit code
- Log failure messages with timing and exit code information
- Ensure TypeScript type checking failures stop the build process
- Maintains timing logs for both success and failure cases

This prevents deployment of code with TypeScript type errors by making
test and production builds fail fast when tsc --noEmit reports issues.

5ae0535935 fix: Restore "Get someone to onboard you" button functionality

Replace notify.confirm() with $notify() in ProjectsView to support complex modal
with custom Yes/No buttons and routing callbacks for non-registered users.

607bb50a55 fix: Restore "Share Your Info" functionality with correct QR code format

- Fix navigation to use correct QR code routes (contact-qr/contact-qr-scan-full)
- Replace deep link generation with CSV format QR codes
- Remove unused imports and fix notification method calls
- Aligns with master branch behavior for contact sharing

Resolves issue where Share Your Info showed "not implemented" and generated
localhost deep links instead of proper CSV format QR codes.

4480778a49 fix: export contactMethods as JSON arrays instead of strings

- Fixed contactsToExportJson to properly handle contactMethods as arrays
- Fixed contactToCsvLine to correctly stringify contactMethods arrays
- Removed unused parseJsonField function (consolidated with PlatformServiceMixin)
- Resolves issue where contact backup exports showed contactMethods as strings instead of JSON arrays

2a34d0e2d1 chore: Adjust some types and type commentary

b267d1bc66 Fix contact backup export: contactMethods now exports as JSON arrays instead of strings

- Fixed contactsToExportJson to export contactMethods as proper arrays instead of stringified JSON
- Added JSON parsing for contactMethods in _mapColumnsToValues when retrieving from database
- Updated $insertContact to properly handle contactMethods field storage
- Removed unused ContactWithJsonStrings import
ref:  https://app.clickup.com/t/86b63ffpb
Resolves issue where contact backup exports showed contactMethods as "[]" strings instead of proper JSON arrays.

75e8b34e88 Merge branch 'build-improvement' of ssh://173.199.124.46:222/trent_larson/crowd-funder-for-time-pwa into build-improvement

ed0f49656d Simplify contactsToExportJson function

Remove unnecessary contact object mapping in contactsToExportJson function.
The contacts array can be used directly since it already contains all required
fields in the correct format.

1f1739f00c fix: Fix messaging on the info-circles by givers & receivers in gifting details.

783ad6e122 fix: Fix data for gives that fulfill offers that are attached to projects (not to include person info). Also: commentary.

6868a322f1 feat: switch ContactQRScanShowView to URL-based contact sharing

- Replace CSV QR value copying with URL generation for better UX
- Add generateEndorserJwtUrlForAccount import and Account type
- Implement proper error handling for URL generation failures
- Maintain consistency with ContactQRScanFullView behavior
- Add documentation for the URL solution implementation

Recipients can now click shared URLs to add contacts directly instead of
manually pasting CSV data into input fields.

addresses:  https://app.clickup.com/t/86b63xhz4

3c37ead60d feat: add comprehensive Quick Start section and clean:all command

- Add Quick Start for Developers section with most common commands
- Add clean:all command to package.json for cleaning all platforms
- Update BUILDING.md with accurate command descriptions and workflow
- Reorganize sections to prioritize npm commands at the top
- Add comprehensive environment configuration documentation
- Update appendices A and B with current build system information
- Fix port number in development server documentation (8080)
- Add troubleshooting quick fixes and platform-specific guidance
- Document environment variable precedence and loading process
- Add comprehensive Vite configuration documentation in Appendix B

919b48e61f Remove unneeded comment

795df6a8fb Test "You" explicitly; fallback is "Unnamed"

18e6aa5a9a Fix: gifting error messages

- Replaced error messages in GiftedDetailsView
- Maintained consistency between GiftedDialog and GiftedDetailsView (error message constants, amountInput)

bf08e57ce7 Fix: re-organize entity type conditional logic in gifting flow

- Add conditional checks for person vs project entity types when setting DID fields
- Simplify project ID assignment logic by removing redundant entity type checks
- Preserve existing recipient context when selecting givers in ContactGiftingView, especially when dealing with "Unnamed" entity

f98d6c7020 Fix notify initialization and axios access errors

- ContactQRScanShowView: Move notify initialization to created() lifecycle hook
- DIDView: Remove axios getter accessing non-existent platformService.axios
- DIDView: Enhance setVisibility() with proper server API error handling

0eb8d3d50e Migrate OnboardMeetingListView to new notify system and add comprehensive documentation

- Add missing logger import to fix 'Cannot find name logger' error
- Migrate from  to createNotifyHelpers pattern with proper NotificationIface type
- Remove unnecessary SQL query from created() method for cleaner initialization
- Add educational documentation to all methods explaining workflows, API endpoints, and user experience
- Update all notify calls to use new format (error, success, confirm methods)
- Improve code maintainability with detailed method documentation

4f9fb068c8 Remove unused confirmation code from ActivityListItem and HomeView

- Remove unused handleConfirmClick() and emitConfirmClaim() methods from ActivityListItem
- Remove unused canConfirm computed property and confirmerIdList prop
- Remove unused imports: isGiveClaimType, notifyWhyCannotConfirm, containsHiddenDid
- Remove unused confirmClaim() method from HomeView
- Remove unused @confirm-claim event binding and :confirmer-id-list prop
- Remove unused imports: serverUtil, NOTIFY_CONFIRMATION_ERROR

The confirmation functionality was not being used in ActivityListItem as there was no UI to trigger it. Confirmation is handled in other components like ClaimView and ConfirmGiftView.

778d00c2a4 refactor(HomeView): remove unused methods and deduplicate API server calls

- Remove unused loadSettings() method (functionality moved to initializeIdentity)
- Remove unused checkRegistrationStatus() method (functionality moved to initializeIdentity)
- Deduplicate ensureCorrectApiServer() calls (now only called once in initializeIdentity)
- Clean up import statement formatting for NOTIFY_CONTACT_LOADING_ISSUE

Reduces code complexity by eliminating 66 lines of dead code while maintaining
all existing functionality. Improves maintainability by consolidating initialization
logic into a single method.

d5db39878c Remove debug code from ShareMyContactInfoView

- Remove debug logging and window.__SHARE_CONTACT_DEBUG__ property
- Clean up eslint-disable comments and console.log statements
- Simplify mounted() method to focus on core functionality

0277b05fef Fix: offer validation prematurely closes dialog

- Transferred form validation error handling to an earlier step
- Added validation for negative input (similar to gifting forms)
- Switched amount input to component version for consistency

c1713e1b0b chore: Remove duplicate logic for encoding contactMethods for DB.

e8bf8014b4 chore: remove notifications that don't work, and adjust other commentary & docs.

a11ff04afa fix: Correct success result check for saving profile.

e0b9481be5 fix: Fix error with deep links trying to parse empty query parameters.

ff61a0bdf3 chore: Bump to v 1.0.6 build 39

d086ab2f46 Merge branch 'master' into build-improvement

91e46f435e Merge branch 'offer-validation-logic' into build-improvement

de47829dc2 fix: DataExportSection error

- Fixed improper referencing for PlatformServiceMixin
- Fixed case where exported data has no contact methods

authored-by: Matthew Raymer <matthew.raymer@anomalistdesign.com>

0fc44b31bf Merge branch 'master' into contact-gifting-current-user

jose added 1 commit 4 weeks ago

24f6730572 Fix: remove redundant method

jose added 1 commit 4 weeks ago

6d316c2b3f Fix: restored prop to show/hide "Show All"

jose changed title from ~~Show current user in ContactGiftingView~~ to WIP: Show current user in ContactGiftingView 4 weeks ago

jose added 1 commit 3 weeks ago

ec1a725832 Refactor: improve dialog logic and entity handling

- Split openDialog into separate methods to improve code readability and maintainability through method extraction
- Add receiver name fallback in GiftedDialog when receiver exists but has no name
- Enhance shouldShowYouEntity to prevent selecting "You" as both giver and recipient
- Improve labeling of "(No name)" entities while retaining original entity object properties
- Apply special styling to "Unnamed" and "(No Name)" entities

jose added 1 commit 3 weeks ago

b3f7026afe Merge branch 'master' into contact-gifting-current-user

jose changed title from ~~WIP: Show current user in ContactGiftingView~~ to Show current user in ContactGiftingView 3 weeks ago

trentlarson reviewed 3 weeks ago

src/views/ContactGiftingView.vue

trentlarson commented 3 weeks ago

Poster

Owner

Let's change this logic a little bit, because there are redundant potential states:

The "contact" could be null/undefined. That is the case where "Unnamed" would be used, so we don't need a separate "Unnamed" value. (If we have both potential cases then we have to include similar logic to work with both cases, which makes it more complex.)
The contact could be the current user's activeDid, so that's what we should use in the openDialog instead of the word "You". (We should be checking here for the activeDid... and if we also have to check "You" then there is duplicate logic again... again adding to the complexity and difficulty of maintenance.)

trentlarson marked this conversation as resolved

jose added 1 commit 3 weeks ago

6acebb66ef Merge branch 'master' into contact-gifting-current-user

jose added 1 commit 3 weeks ago

a4528c5703 Refactor: eliminate "special" entity type and use DID-based logic

Replace string-based entity type matching with DID-based logic for "You" and "Unnamed" entities. Treat these as regular person entities instead of special types.

- Remove "special" type from EntitySelectionEvent interface
- Update EntityGrid to emit "You" and "Unnamed" as person entities
- Simplify SpecialEntityCard emit structure (remove entityType parameter)
- Refactor GiftedDialog to process all person entities with DID-based logic
- Update ContactGiftingView and HomeView to use DID-based entity creation
- Remove string literals "You" and "Unnamed" from method signatures

jose commented 3 weeks ago

Poster

Owner

I refactored the entity creation method by eliminating the use of string-type entities, and instead determining those through the logic you mentioned. No more "Unnamed" or "You" special cases, just deduction via DID.

I also looked at related views and components to find similar patterns and refactored those, as well.

trentlarson reviewed 3 weeks ago

src/components/EntityGrid.vue

trentlarson commented 3 weeks ago

Poster

Owner

I see this is only ever set as false. If there are not any cases where it should be true then we can remove this and just set it to the 'false' behavior.

jose commented 3 weeks ago

Poster

Owner

hideShowAll is set to true via HTML attribute hide-show-all when accessing GiftedDialog from ContactGiftingView. This is used to tell GiftedDialog to hide the "Show All" link in that particular context, since "Show All" links to ContactGiftingView just the same.

trentlarson commented 1 week ago

Poster

Owner

Ah! I see. Thanks.

trentlarson marked this conversation as resolved

trentlarson commented 3 weeks ago

Owner

Other than that one outstanding conversation for hideShowAll this looks good!

jose added 1 commit 3 weeks ago

ca8d72e1c9 Fix: remove non-applicable IDs

- Projects use handleID, not DID

jose added 1 commit 3 weeks ago

eb44e7b51e Chore: convert "unnamed" into constant

- "Unnamed/Unknown" simplified into just "Unnamed"
- Phrase variations have their own constants

trentlarson commented 1 week ago

Owner

This looks great!

One last thing (which I put in ClickUp, too): this reveals some inconsistencies in terms. Let's consolidate:

We don't need "member", so remove the UNNAMED_MEMBER and replace usages with SOMEONE_UNNAMED.
Change "unnamed user" to "unnamed person". (We only use the words "person" for anyone, and "contact" for people in the contact list... so you could say "unnamed contact" in some places, but that's totally up to you. Simple is fine!)

jose added 1 commit 1 week ago

cc50c38d13 Chore: simplify wording for person entities

- Replaced all instances of "Unnamed Member" with "Someone Unnamed"
- Removed unused UNNAMED_MEMBER constant
- Renamed UNNAMED_PERSON to THAT_UNNAMED_PERSON to match its value
- Renamed UNNAMED_USER to UNNAMED_PERSON and changed the value to "unnamed person"

jose added 2 commits 1 week ago

ec326495b2 Merge branch 'master' into contact-gifting-current-user

ec53452220 Chore: lint fix

jose merged commit 2c6b787fa2 into master 1 week ago

jose referenced this issue from a commit 1 week ago

Merge pull request 'Show current user in ContactGiftingView' (#155) from contact-gifting-current-user into master

The pull request has been merged as 2c6b787fa2.

No reviewers

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

    * Creates an entity object from the contact parameter
    */
   private createEntityFromContact(
     contact?: GiverReceiverInputInfo | "Unnamed" | "You",

   /** Whether to hide the "Show All" navigation */
   @Prop({ default: false })
   hideShowAll!: boolean;