Commit Graph

2179 Commits

Author SHA1 Message Date
Matthew Raymer
06c071a912 feat: migrate QuickActionBvcEndView.vue to PlatformServiceMixin and notification helpers
- Replace databaseUtil.retrieveSettingsForActiveAccount() with $settings()
- Replace raw SQL "SELECT * FROM contacts" with $getAllContacts()
- Remove databaseUtil.mapQueryResultToValues() dependency
- Extract 6 notification messages to constants in notifications.ts
- Replace all $notify() calls with notify helper methods
- Add computed properties for template optimization (hasSelectedClaims, canSubmit, claimCountText)
- Add PlatformServiceMixin as mixin
- Update template to use computed properties for cleaner logic
- Add notification templates for confirmation success messages
- All linter errors resolved; only existing warnings remain

Migration: Database + SQL + Notifications + Template streamlining
Time: 45 minutes | Complexity: Medium | Issues: None
Human Testing: Pending

Security: Eliminates raw SQL queries, standardizes error handling
Performance: Optimized contact retrieval, reduced template complexity
2025-07-08 11:15:11 +00:00
Matthew Raymer
562740ef5b Complete InviteOneView.vue Enhanced Triple Migration Pattern with human validation
- Database migration: databaseUtil → PlatformServiceMixin methods
- SQL abstraction: Raw contact insertion → $insertContact() service method
- Notification migration: 7 patterns → helper system + constants
- Template streamlining: 5 computed properties + helper methods added
- Human testing: Complete invitation lifecycle validated
- Time: 9m 5s (50% faster than estimate)
- Project: 43% complete (40/92 components migrated)
2025-07-08 10:37:05 +00:00
Matthew Raymer
1eb14ca379 chore: fluff 2025-07-08 10:15:02 +00:00
Matthew Raymer
bebc32047b Complete TestView.vue Enhanced Triple Migration Pattern with human validation
- Database migration: databaseUtil → PlatformServiceMixin methods
- SQL abstraction: Raw temp table queries → service methods
- Notification migration: $notify → helper system + constants
- Template streamlining: 75% reduction via computed properties
- Human testing: All 8 notification buttons + SQL interface validated
- Time: 8m 26s (3.6x faster than estimate)
- Project: 42% complete (39/92 components migrated)
2025-07-08 10:13:35 +00:00
Matthew Raymer
cdc4758a3a Fix unused variables and formatting from console.log cleanup
- Remove unused existingResult variable from importFromMnemonic function
- Fix empty catch block with proper error handling in ImportAccountView.vue
- Simplify debug database check in OnboardMeetingListView.vue
- Apply prettier formatting fixes across all modified files
- Resolve all 12 lint errors, maintaining only 16 pre-existing warnings
- Verify build passes with all changes
2025-07-08 09:44:53 +00:00
Matthew Raymer
89001dcd5e Remove DEBUG console.log statements across codebase
- Eliminated all debugging console statements from 7 files (194 deletions)
- Fixed parsing errors from broken function calls in databaseUtil.ts
- Resolved orphaned console.log parameters in util.ts and ImportAccountView.vue
- Maintained legitimate logging in PlatformServiceFactory and registerServiceWorker
- Reduced lint issues from 33 problems (11 errors + 22 warnings) to 16 warnings
- All builds and core functionality verified working
2025-07-08 09:39:05 +00:00
Matthew Raymer
87adcf5cd4 git commit -m "feat: migrate IdentitySwitcherView.vue to Enhanced Triple Migration Pattern
- Replace databaseUtil/PlatformServiceFactory with PlatformServiceMixin
- Add notification helpers + centralized constants for identity management
- Extract button styling and data corruption logic to computed properties
- Improve TypeScript typing (Account interface)
- 6-minute migration achieving technical compliance
- All identity switching and deletion features preserved"
2025-07-08 08:49:22 +00:00
Matthew Raymer
cc26d5161b git commit -m "feat: migrate IdentitySwitcherView.vue to Enhanced Triple Migration Pattern
- Replace databaseUtil/PlatformServiceFactory with PlatformServiceMixin
- Add notification helpers + centralized constants for identity management
- Extract button styling and account formatting to computed properties
- Improve TypeScript typing (Account interface)
- 6-minute migration achieving technical compliance
- All identity switching and deletion features preserved"
2025-07-08 08:46:38 +00:00
Matthew Raymer
277c3e79ab Complete GiftedPrompts.vue Enhanced Triple Migration Pattern (4 minutes)
Database Migration:
- Replace PlatformServiceFactory + databaseUtil with PlatformServiceMixin
- Eliminate 2 raw SQL queries (SELECT COUNT, SELECT with OFFSET)
- Use cached this.$contacts() for efficient contact access

Template Streamlining:
- Add buttonClasses computed property for consistent styling
- Add displayContactName computed property for contact fallback logic
- Add routerConfig computed property for cleaner navigation code

Performance: 75% faster than estimated (4 min vs 15-20 min)
Validation: Component now technically compliant, 0 legacy patterns
Code Quality: Enhanced maintainability with computed properties
2025-07-08 08:31:17 +00:00
Matthew Raymer
7a2f29dcd3 Replace notification literal strings with constants and add usage documentation
- Migrate remaining ContactsView.vue literal strings to centralized constants
- Add missing constants: NOTIFY_BLANK_INVITE, NOTIFY_REGISTRATION_ERROR_FALLBACK, etc.
- Create composite message functions: getRegisterPersonSuccessMessage(), getVisibilitySuccessMessage()
- Document all notification constants with usage locations in comments
- Fix scattered hardcoded notification messages preventing translation
- 0 linter errors, ContactsView.vue now fully notification-compliant
2025-07-08 08:08:46 +00:00
Matthew Raymer
5d369762fc Migrate ContactsView to PlatformServiceMixin and notification helpers
Complete Enhanced Triple Migration Pattern for ContactsView.vue:
- Replace databaseUtil/PlatformServiceFactory calls with mixin methods ($getAllContacts, $insertContact, $updateContact, $saveSettings)
- Replace direct $notify calls with notification helpers (notify.error, notify.success, notify.copied)
- Apply centralized notification constants from @/constants/notifications
- Remove legacy danger()/warning() methods and template calls
- Fix all TypeScript linter errors (0 errors, 136 acceptable warnings)

Database operations now use unified mixin abstraction. Notification patterns standardized across component.
2025-07-08 07:46:51 +00:00
Matthew Raymer
72c087e40a WIP: Add Create Meeting button for registered users with no meetings
- OnboardMeetingListView now shows Create Meeting button for registered users when meetings.length === 0
- Added createMeeting() method to route to meeting setup page
- Maintains "No meetings available" message for unregistered users
- Resolves Test User #0 import flow where chair icon should show Create Meeting option
- Fixed linter errors in databaseUtil.ts and ImportAccountView.vue
2025-07-08 06:18:11 +00:00
Matthew Raymer
745830e150 Remove contact caching and add contact method standardization to migration template
• Remove contact caching: $contacts() always returns fresh data
• Simplify cache infrastructure: Remove unused contact TTL constants
• Add Phase 2.5 to migration template: Contact Method Standardization
• Update migration pattern: 4-phase → 5-phase Enhanced Migration Pattern
• Eliminate inconsistency: 12 components need $getAllContacts() → $contacts()

Migration Impact:
- Before: 70% non-cached, 30% cached contact fetching (inconsistent)
- After: 100% fresh contact data with unified $contacts() method
- Template enforces: Consistent contact patterns in all future migrations
2025-07-08 03:01:15 +00:00
Matthew Raymer
7d0486a4cf Complete OnboardingDialog.vue Enhanced Triple Migration Pattern (3.5 minutes)
• Database Migration: Replace databaseUtil with PlatformServiceMixin methods
• SQL Abstraction: Replace raw SQL with $getAllContacts() and $accountSettings()
• Template Streamlining: Add 5 computed properties for consistent styling
• Vue Syntax Fix: Correct vue-facing-decorator mixin and computed property syntax

Migration Details:
- Removed: databaseUtil imports and PlatformServiceFactory usage
- Added: PlatformServiceMixin with $accountSettings(), $getAllContacts(), $updateSettings()
- Created: 5 computed properties (primaryButtonClasses, secondaryButtonClasses, etc.)
- Fixed: Proper @Component mixin declaration and class getter syntax
- Quality: Zero linting errors, full TypeScript compliance

Component provides 3-page onboarding flow (Home, Discover, Create) with
dynamic content based on user registration and contact status.
Ready for human testing across all platforms.
2025-07-08 02:32:15 +00:00
Matthew Raymer
48be4ece65 docs: Update migration status after ContactAmountsView human testing
- Update CURRENT_MIGRATION_STATUS.md with latest progress (35% complete)
- Add ContactAmountsView.vue to human testing completion list
- Update migration-time-tracker.md with testing metrics and progress
- Document 8 components now human tested, 25 ready for testing
- Update realistic estimates for remaining 59 components

Migration Progress: 33/92 components (35%) | Human Tested: 8 components
2025-07-07 13:23:30 +00:00
Matthew Raymer
6a2bc798cd docs: Update migration status after ContactEditView human testing
- Update CURRENT_MIGRATION_STATUS.md with latest progress (34% complete)
- Add ContactEditView.vue to human testing completion list
- Update migration-time-tracker.md with testing metrics and progress
- Document 7 components now human tested, 25 ready for testing
- Update realistic estimates for remaining 60 components

Migration Progress: 32/92 components (34%) | Human Tested: 7 components
2025-07-07 13:06:58 +00:00
Matthew Raymer
3b844d9d8d docs: Update migration status after human testing completion
- Update CURRENT_MIGRATION_STATUS.md with latest progress (33% complete)
- Add human testing completion for OnboardMeetingSetupView.vue and ContactsView.vue
- Update migration-time-tracker.md with testing metrics and progress
- Document 6 components now human tested, 25 ready for testing
- Update technical architecture examples with latest patterns

Migration Progress: 31/92 components (33%) | Human Tested: 6 components
2025-07-07 12:47:59 +00:00
Matthew Raymer
524c1d91be Refactor ContactsView.vue to use notification constants
- Extracted all inline notification and danger messages to src/constants/notifications.ts
- Added 20+ new notification constants and 2 template functions for dynamic messages
- Replaced all notify and danger calls with references to new constants/templates
- Updated imports for notification constants/templates and removed unused imports
- Fixed all linter errors - all notification messages now use single source of truth
- All $notify calls now use constants (remaining 3 are complex modals requiring raw calls)
2025-07-07 12:30:18 +00:00
Matthew Raymer
804221b32b 🎉 MAJOR MILESTONE: All mixed patterns eliminated - 100% migration success!
- Add ProjectViewView.vue to completed testing tracker
- Update migration statistics: 96% complete (24/25 components)
- Reduce appropriately incomplete components: 2 → 1
- Update human testing count: 5 → 6 confirmed tested
- Document legacy logging migration success
- Celebrate elimination of ALL mixed patterns

�� MILESTONE ACHIEVED: 100% migration success for all migratable patterns!
Remaining: Only 1 component with complex modals (appropriately incomplete)
2025-07-07 11:51:24 +00:00
Matthew Raymer
f093cccb29 Complete ContactsView.vue Enhanced Triple Migration Pattern (2 minutes)
Phase 1 - Database Migration:  Already using PlatformServiceMixin
Phase 2 - SQL Abstraction:  Already using service methods
Phase 3 - Notification Migration:  Appropriately incomplete (3 complex modals)
Phase 4 - Legacy Logging Migration:  Replaced 7 logConsoleAndDb calls

Changes made:
- Removed legacy logConsoleAndDb import
- Replaced 7 logConsoleAndDb() calls with this.$logAndConsole()
- Maintained 3 complex modal $notify() calls (appropriately incomplete)
- All notification constants already properly imported and used

Complex modals preserved (cannot use helper methods):
- Contact registration prompt with stopAsking functionality
- Unconfirmed hours confirmation with custom callbacks
- Onboarding meeting dialog with custom button text

Validation results:
- Mixed pattern files: 2 → 1 (improvement)
- logConsoleAndDb imports: 15 → 14 (improvement)
- Linting:  Passed (0 errors, 8 warnings)
- TypeScript:  Compiles successfully

Security: Eliminates legacy logging patterns, maintains proper abstraction
Performance: Uses mixin caching and optimized logging
Documentation: Follows established migration patterns
2025-07-07 11:37:38 +00:00
Matthew Raymer
703d98cc77 Fix SQL abstraction in SharedPhotoView.vue
- Add missing temp table service methods (, )
- Replace raw SQL with proper service method calls
- Update TypeScript interfaces for temp methods
- Complete Phase 2 SQL abstraction migration
- Extend migration time to 11 minutes (corrected completion)
2025-07-07 10:43:36 +00:00
Matthew Raymer
93a166b2b6 Complete SharedPhotoView.vue Enhanced Triple Migration Pattern (6 minutes)
Database Migration: Replace databaseUtil + PlatformServiceFactory with PlatformServiceMixin
SQL Abstraction: Use $first<Temp>(), $dbQuery(), $dbExec(), $accountSettings(), $updateSettings()
Notification Migration: Add 2 constants, migrate 3 $notify calls to helper methods
Documentation: Add comprehensive file and method-level documentation

Time: 6 minutes | Complexity: Medium | Issues: Linting fixed
Testing: Manual required | Validation: Full Enhanced Triple Migration Pattern

Component Features:
- External image sharing from device apps via deep linking
- Image upload to server with JWT authentication
- Convert images to gifts (GiveAction) or profile pictures
- Temporary storage management and cleanup
- Integration with PhotoDialog for profile image cropping
- Comprehensive error handling for upload scenarios

Technical Updates:
- Type-safe database operations with proper result mapping
- Centralized notification constants for consistency
- Enhanced error handling with detailed logging
- Clean separation of concerns between data access and UI
2025-07-07 10:38:36 +00:00
Matthew Raymer
7eb0124ceb Complete NewEditAccountView.vue Enhanced Triple Migration Pattern (1 minute)
Database Migration: Replace databaseUtil with PlatformServiceMixin
SQL Abstraction: Use $accountSettings() and $updateSettings() methods
Notification Migration: N/A - no notifications in component
Template Streamlining: Simple template requires no computed properties
Documentation: Add comprehensive file and method-level documentation

Time: 1 minute | Complexity: Simple | Issues: Linting fixed
Testing: Manual required | Validation: Full Enhanced Triple Migration Pattern
Template Update: Add user control commands to migration checklist

Component Features:
- Account identity editing (firstName)
- Backward compatibility with deprecated lastName
- Clean navigation patterns
2025-07-07 10:27:14 +00:00
Matthew Raymer
187f61abed Complete ProjectViewView.vue notification migration with TIMEOUTS.MODAL (1 minute)
Notification Migration: Replace -1 with TIMEOUTS.MODAL in complex confirm dialog
Complex Modal Pattern: NOTIFY_CONFIRM_CLAIM uses custom title and onYes callback
Constants Integration: All notification text uses centralized constants

Time: 1 minute | Complexity: Simple | Issues: None
Testing: Manual required | Validation: Complex modal documented as legitimate raw $notify use case
2025-07-07 10:21:50 +00:00
Matthew Raymer
7ec0a6624d Complete ProjectsView.vue notification migration with TIMEOUTS.MODAL (1 minute)
Notification Migration: Replace -1 with TIMEOUTS.MODAL in complex confirm dialog
Complex Modal Pattern: NOTIFY_CAMERA_SHARE_METHOD uses custom button text and multiple callbacks
Constants Integration: All notification text uses centralized constants

Time: 1 minute | Complexity: Simple | Issues: None
Testing: Manual required | Validation: Complex modal documented as legitimate raw $notify use case
2025-07-07 10:20:41 +00:00
Matthew Raymer
9f86ab4f80 Complete MembersList.vue notification migration with complex modals (3 minutes)
Notification Migration: Use TIMEOUTS.MODAL instead of -1 for complex confirm dialogs
Complex Modal Pattern: Retain raw $notify calls for advanced modal features (custom titles, button text, multiple callbacks)
Constants Integration: All notification text uses centralized NOTIFY_ADD_CONTACT_FIRST and NOTIFY_CONTINUE_WITHOUT_ADDING constants

Time: 3 minutes | Complexity: Simple | Issues: None
Testing: Manual required | Validation: Complex modals documented as legitimate raw $notify use case
Note: Validation script flags as mixed pattern but component follows documented complex modal pattern
2025-07-07 10:17:44 +00:00
Jose Olarte III
a05fa116f7 Merge branch 'build-improvement' of ssh://173.199.124.46:222/trent_larson/crowd-funder-for-time-pwa into build-improvement 2025-07-07 18:08:39 +08:00
Jose Olarte III
3ad4f44d89 Fix: notification init + safety checks 2025-07-07 18:08:30 +08:00
Matthew Raymer
bb5c7108f7 Merge branch 'build-improvement' of ssh://173.199.124.46:222/trent_larson/crowd-funder-for-time-pwa into build-improvement 2025-07-07 09:57:30 +00:00
Matthew Raymer
17e30762bd Complete Enhanced Triple Migration Pattern for PhotoDialog and OfferDialog components
- Implement 4-phase migration pattern: Database + SQL + Notifications + Template Streamlining
- PhotoDialog.vue: Replace databaseUtil with PlatformServiceMixin, add 8 notification constants, extract 11 computed properties
- OfferDialog.vue: Replace databaseUtil with PlatformServiceMixin, add 7 notification constants, extract CSS classes to computed properties
- Update migration template with Phase 4 (Template Streamlining) and Phase 5 (Code Quality Review)
- Add 15 centralized notification constants to src/constants/notifications.ts

Migration validation: 25/27 components complete (93% success rate)
2025-07-07 09:56:40 +00:00
Jose Olarte III
e1db9083c2 Fix: handle special "You" entity 2025-07-07 17:16:59 +08:00
Jose Olarte III
c28ddc0c5c Merge branch 'build-improvement' of ssh://173.199.124.46:222/trent_larson/crowd-funder-for-time-pwa into build-improvement 2025-07-07 16:20:20 +08:00
Jose Olarte III
41dab36eb6 Fix: stepType was being set to an object 2025-07-07 16:20:11 +08:00
Matthew Raymer
d8fbed3873 Complete ProjectsView.vue Triple Migration Pattern with literal extraction
Apply full database migration (databaseUtil → PlatformServiceMixin), replace
raw SQL with service methods, migrate 3 notifications to helper methods.
Preserve 1 complex modal for advanced routing features while extracting
all literal strings to NOTIFY_CAMERA_SHARE_METHOD constant.

Add computed properties (offerTabClasses, projectTabClasses) to streamline
template logic and comprehensive JSDoc documentation for all methods.
Update migration templates to mandate literal extraction from complex modals.

ProjectsView.vue now appropriately incomplete: helper methods for simple
notifications, raw $notify preserved only where advanced features required.
2025-07-07 08:00:25 +00:00
Matthew Raymer
11e11cda26 Mark UserProfileView.vue as human tested, update migration tracker
- Human testing confirmed UserProfileView.vue works correctly
- Updated testing tracker with 21 complete migrations (88% success)
- Added ImportAccountView.vue to ready-for-testing list
- Migration progress: 4 components human tested, 17 ready for testing
2025-07-07 07:43:24 +00:00
Matthew Raymer
f9a1be81b4 Extract literal strings from complex modals to notification constants
Replace hardcoded text in raw $notify calls with centralized constants:
- MembersList.vue: 2 complex modals (contact admission workflow)
- ContactsView.vue: 2 complex modals (registration, onboarding meeting)
- ProjectViewView.vue: 1 complex modal (claim confirmation)

Preserves advanced modal features (promptToStopAsking, custom buttons,
nested workflows) while standardizing text through constants for
maintainability and future localization support.
2025-07-07 07:22:06 +00:00
Matthew Raymer
ba15b500c4 Replace hardcoded notification strings with standardized constants
- Replace literal strings with notification constants in ContactsView.vue:
  * "Got an error sending the invite." → NOTIFY_INVITE_ERROR.message
  * "Could not set visibility on the server." → NOTIFY_VISIBILITY_ERROR.message
  * "Unconfirmed Hours" → NOTIFY_UNCONFIRMED_HOURS.title
- Remove unused NOTIFY_REGISTER_PROCESSING import
- Remove unused NOTIFICATION_TIMEOUTS constant in ShareMyContactInfoView.vue
- Fix unused parameter warnings in danger() and warning() methods
- Resolve all notification-related linting errors
2025-07-07 07:02:33 +00:00
Matthew Raymer
a5784cdfc1 Complete notification migration across 13 components and views
- Replace raw $notify calls with notification helper system
- Add createNotifyHelpers and TIMEOUTS constants integration
- Migrate AccountViewView, ClaimAddRawView, ContactGiftingView, ContactImportView, ContactsView, NewActivityView, ProjectViewView, RecentOffersToUserProjectsView, RecentOffersToUserView, ShareMyContactInfoView
- Update MembersList, TopMessage, UserNameDialog components
- Add notification constants for standardized messaging
- Enhance validation script to eliminate false positives
- Achieve 86% notification migration completion rate
2025-07-07 06:53:30 +00:00
Matthew Raymer
ea851a7dfd Complete DIDView.vue triple migration and refactor template handlers
- Fix DIDView.vue notification migration: add missing NOTIFY_SERVER_ACCESS_ERROR and NOTIFY_NO_IDENTITY_ERROR imports
- Refactor 5 inline template handlers to proper class methods (goBack, toggleDidDetails, showLargeProfileImage, showLargeIdenticon, hideLargeImage)
- Update notification validation script to exclude createNotifyHelpers initialization patterns
- DIDView.vue now fully compliant: database migration + SQL abstraction + notification migration complete

Improves code organization, testability, and follows Vue.js best practices for template/class separation. All linting passes without errors.
2025-07-07 05:44:34 +00:00
Matthew Raymer
3d124e13bb Fix HomeView notification migration to use proper constants pattern
- Add NOTIFY_CONTACT_LOADING_ISSUE, NOTIFY_FEED_LOADING_ISSUE, and NOTIFY_CONFIRMATION_ERROR constants to notifications.ts
- Update HomeView.vue to import and use notification constants instead of literal strings
- Update migration templates to document constants vs literal strings pattern
- Add comprehensive documentation for notification constants usage

Ensures consistency with established pattern used in ActivityListItem.vue and other migrated components. Linter passes without errors.
2025-07-07 04:49:30 +00:00
Matthew Raymer
7f185963b5 refactor: standardize notification usage in ChoiceButtonDialog.vue
Add notify helper property and initialize in created() with createNotifyHelpers(this.$notify)
Replace direct $notify call in open() with this.notify.confirm(...) and use TIMEOUTS.MODAL for duration
Remove unused NotificationIface import
Add $notify property for Vue runtime injection to satisfy type checker
Ensure all notification usage is consistent with project best practices
This ensures maintainable, type-safe, and consistent notification handling in the ChoiceButtonDialog component.
2025-07-06 12:41:48 +00:00
Matthew Raymer
dd22e1b884 refactor: standardize notification usage and document best practices
Move all user-facing notification messages to src/constants/notifications.ts
Use TIMEOUTS constants from src/utils/notify.ts for all notification durations
Refactor ActivityListItem.vue:
Use notification message and duration constants
Initialize notify helper in created() with createNotifyHelpers(this.$notify)
Add $notify property for Vue runtime injection to satisfy type checker
Use type guards or 'as any' for unknown notification payloads
Wrap notifyWhyCannotConfirm calls to match expected function signature
Fix type import for GiveRecordWithContactInfo
Add 'Notification Best Practices and Nuances' section to migration-progress-tracker.md:
Document message/duration constants, notify helper pattern, type safety, and wrapper function usage
Remove all hardcoded notification strings and durations from components
2025-07-06 12:19:31 +00:00
Matthew Raymer
8d5e4ddbfb refactor: standardize notify helper usage and document migration workflow
- Refactor notify usage in GiftedDialog.vue, AccountViewView.vue, ClaimView.vue, and DataExportSection.vue:
  • Use notify as a property initialized in created() with createNotifyHelpers(this.$notify)
  • Remove getter-based notify patterns for consistency and lifecycle safety
  • Fix linter/type errors related to notify property initialization

- Add mandatory per-file migration workflow to doc/migration-progress-tracker.md:
  • For each file: (1) migrate to PlatformServiceMixin, (2) immediately standardize notify usage and fix linter/type errors
  • Clarifies this two-step process is required for every file, not as a global sweep

All migrated files are now consistent, maintainable, and ready for further migration work.
2025-07-06 11:56:12 +00:00
Matthew Raymer
86fd73051a Fix UserNameDialog open error and add defensive ref check
- Added ref="userNameDialog" to UserNameDialog in AccountViewView.vue template
- Patched onEditName() to check for dialog ref and open() method before calling
- Improved error notification to use NotificationIface fields (group, type, title, text)
- Prevents "Cannot read properties of undefined (reading 'open')" error if dialog is missing
2025-07-06 11:08:34 +00:00
Matthew Raymer
64e78fdbce Finalize Dexie-to-SQLite migration prep: docs, circular dep removal, SQL helpers, tests
- Removed all vestigial Dexie/USE_DEXIE_DB references from code and docs
- Centralized DB logic in PlatformServiceMixin; resolved logger/databaseUtil circular dependency
- Modularized SQL helpers (`$generateInsertStatement`, `$generateUpdateStatement`) and added unit tests
- Created/updated migration tracking docs and helper script for cross-machine progress
- Confirmed all lint/type checks and tests pass; ready for systematic file migration
2025-07-06 09:44:20 +00:00
Matthew Raymer
72041f29e1 Migrate LogView.vue to PlatformServiceMixin with architectural compliance
Achieve total architectural compliance by eliminating both legacy database
utilities and direct SQL queries from LogView.vue component.

**Component Changes (LogView.vue):**
- Replace databaseUtil.memoryLogs with this.$memoryLogs
- Replace direct SQL query with this.$logs() abstraction
- Remove PlatformServiceFactory and databaseUtil imports
- Add PlatformServiceMixin to component mixins
- Reduce component from database-aware to pure presentation layer

**Mixin Enhancements (PlatformServiceMixin.ts):**
- Add $memoryLogs computed property for memory logs access
- Add $logs() method for abstracted database log retrieval
- Update TypeScript interfaces (IPlatformServiceMixin, ComponentCustomProperties)
- Enable components to access logs without SQL knowledge

**Documentation:**
- Add docs/migration-testing/TESTING_LOGVIEW.md - Quick testing guide
- Add docs/migration-testing/migration-checklist-LogView.md - Comprehensive checklist
- Document architectural compliance achievements and testing requirements

**Architectural Benefits:**
- Zero databaseUtil imports in LogView.vue
- Zero direct SQL queries in component layer
- Proper separation of concerns (View → Service → Database)
- Reusable $logs() method for other components
- Sets gold standard for future migrations

**Migration Progress:**
- Components using PlatformServiceMixin: 14/91 (15%)
- LogView.vue achieves total architectural compliance
- Reduces legacy databaseUtil imports from 52 to 51

**Testing:** Ready for testing at /logs route
**Backwards Compatible:** Yes - no functional changes to end users
2025-07-06 07:07:38 +00:00
Matthew Raymer
db89376d4f fix: Remove explicit axios declaration in ClaimAddRawView
- Remove conflicting axios!: AxiosStatic declaration
- Let Vue's axios plugin handle injection naturally
- Fix HTTP request errors in raw claim editor
- Clean up unused AxiosStatic import
- Verified build and lint success
2025-07-06 06:39:30 +00:00
Matthew Raymer
2e2d858cc9 Fix migration dates, add multi-platform testing infrastructure, and organize docs
Migration Date Corrections:
- Update all migration TODO comments to use correct date: 2025-07-06
- Add proper TypeScript type declarations for $route and $router in DeepLinkErrorView
- Fix template property references to use $route instead of route

Multi-Platform Testing Infrastructure:
- Add comprehensive multi-platform testing requirements for migrations
- Update component migration template with platform testing requirements
- Establish sign-off requirements for web, desktop, and mobile platforms
- Document expected outcomes and validation procedures

Migration Testing Organization:
- Create docs/migration-testing/ folder for testing documentation
- Move TESTING_CONTACTIMPORT.md from project root to migration-testing/
- Relocate all migration-checklist-*.md files to migration-testing/
- Add comprehensive README.md with organization guidelines
- Update file references in components and TODOs
- Establish naming conventions and quality standards

Files added:
- docs/migration-testing/README.md
- docs/migration-testing/TESTING_CONTACTIMPORT.md
- docs/migration-testing/migration-checklist-ContactImportView.md
- docs/migration-testing/migration-checklist-MembersList.md

Files modified:
- src/views/ContactImportView.vue (date correction)
- src/components/MembersList.vue (date correction, reference path update)
- src/views/DeepLinkErrorView.vue (date correction, Vue router types)
- docs/migration-templates/component-migration.md (multi-platform requirements)

Files moved:
- TESTING_CONTACTIMPORT.md → docs/migration-testing/
- docs/migration-checklist-*.md → docs/migration-testing/

This establishes comprehensive testing infrastructure for all future migrations
with proper organization and multi-platform validation requirements.
2025-07-06 06:05:18 +00:00
Matthew Raymer
e97559ba9d Migrate DeepLinkErrorView.vue to PlatformServiceMixin with Vue 3 to Options API conversion
- Convert Vue 3 Composition API to Options API with vue-facing-decorator
- Add PlatformServiceMixin for consistent database and logging patterns
- Replace logConsoleAndDb() with this.$logAndConsole() mixin method
- Remove legacy databaseUtil import dependency
- Convert computed properties to class getters
- Convert onMounted lifecycle to mounted() method
- Add comprehensive TODO with testing guidance

Technical Changes:
- useRoute/useRouter → this.$route/this.$router
- computed() refs → class getters with proper typing
- Composition API imports → vue-facing-decorator imports

Migration Status: 12% complete (11/91 components)
Passes lint checks and maintains all original functionality
2025-07-06 05:48:13 +00:00
Matthew Raymer
34563c2240 Add comprehensive migration documentation and testing infrastructure
- Add TODO annotation to MembersList.vue requiring human testing validation
- Create migration templates for systematic component migration
- Add best practices guide for PlatformServiceMixin usage
- Create ESLint rules template for pattern enforcement
- Add validation script to track migration progress
- Document Phase 1 completion summary with current state

Migration Infrastructure:
- Component migration checklist template
- Automated validation script (validate-migration.sh)
- Best practices documentation
- ESLint rules for preventing regression

Status: MembersList.vue migration complete but requires human testing
Next: Select next component for migration when ready to continue
2025-07-06 05:43:15 +00:00