Commit Graph

12 Commits

Author SHA1 Message Date
Jose Olarte III
a4528c5703 Refactor: eliminate "special" entity type and use DID-based logic
Replace string-based entity type matching with DID-based logic for "You" and "Unnamed" entities. Treat these as regular person entities instead of special types.

- Remove "special" type from EntitySelectionEvent interface
- Update EntityGrid to emit "You" and "Unnamed" as person entities
- Simplify SpecialEntityCard emit structure (remove entityType parameter)
- Refactor GiftedDialog to process all person entities with DID-based logic
- Update ContactGiftingView and HomeView to use DID-based entity creation
- Remove string literals "You" and "Unnamed" from method signatures
2025-08-15 13:22:49 +08:00
Jose Olarte III
0fc44b31bf Merge branch 'master' into contact-gifting-current-user 2025-08-11 19:01:06 +08:00
Jose Olarte III
bf08e57ce7 Fix: re-organize entity type conditional logic in gifting flow
- Add conditional checks for person vs project entity types when setting DID fields
- Simplify project ID assignment logic by removing redundant entity type checks
- Preserve existing recipient context when selecting givers in ContactGiftingView, especially when dealing with "Unnamed" entity
2025-08-07 18:29:58 +08:00
Jose Olarte III
06f3a4c7c2 Refactor: simplify GiftedDialog with explicit entity type props
Replace complex updateEntityTypes() method with explicit giverEntityType and
recipientEntityType props. This makes the component more declarative and
maintainable by removing hidden logic and making entity type relationships
clear at the call site.

- Remove updateEntityTypes() method and related watchers
- Add explicit giverEntityType and recipientEntityType props with defaults
- Update all views to use inline logic for entity type determination
- Fix entity type preservation in navigation flows
- Enhance query parameter passing for better context preservation
- Fix recipient reset issue in ContactGiftingView
- Resolve entity type mismatch in HomeView project button flow

Files changed:
- GiftedDialog.vue: Remove complex logic, add explicit props
- EntitySelectionStep.vue: Enhanced query parameter handling
- ContactGiftingView.vue: Improved context preservation
- HomeView.vue, ProjectViewView.vue, ClaimView.vue, ContactsView.vue:
  Updated to use explicit entity type props
- Add refactoring documentation
2025-08-03 11:49:46 +08:00
Jose Olarte III
e741790d70 Fix ClaimView affirm delivery action
- Add offer context support to gifting flow
- Add offerId prop to EntitySelectionStep for offer fulfillment context
- Pass offerId through GiftedDialog to EntitySelectionStep
- Update ContactGiftingView to handle offerId from route query parameters
- Extract offer details (description, amount, unitCode) for pre-population
2025-08-01 13:44:28 +08:00
Jose Olarte III
404a7cbc71 Add form field preservation in gifting flow
- Preserve description, amount, and unit code when navigating between gifting steps
- Add form field props to EntitySelectionStep and GiftedDialog components
- Update ContactGiftingView to handle form state persistence in URL parameters
2025-08-01 11:36:17 +08:00
Jose Olarte III
bed2c7106a Added: current user in ContactGiftingView
- "You" is displayed conditionally, similar to GiftedDialog behavior
- "Show All" is hidden in GiftedDialog when accessed from ContactGiftingView (redundant)
2025-07-28 18:46:56 +08:00
Matthew Raymer
c49c137cae EntitySummaryButton.vue: Phase 4 template streamlining migration
- Extract long CSS class to computed property containerClasses
- Fix header comment formatting to proper JSDoc format
- Enhance component documentation for template streamlining
- Update class binding from static to dynamic for better maintainability
- Migration completed in 3 minutes (within estimate)
- No database or SQL operations needed (pure UI component)
- Lint validation passed with no errors

Security audit: No security risks (cosmetic template changes only)
Migration status: 67% complete (62/92 components migrated)
2025-07-09 08:57:24 +00:00
Matthew Raymer
dd0a940fb5 EntityIcon.vue: Documentation enhancement migration
- Add comprehensive file-level documentation with features list
- Enhance method documentation with priority order explanation
- Improve prop documentation with proper TypeScript typing
- Add detailed comments explaining icon generation logic
- Preserve original DiceBear API/library discrepancy comment
- Enhance code readability and maintainability
- Migration completed in 2 minutes (within estimate)
- No database or SQL operations needed (pure UI component)
- Lint validation passed with no errors

Security audit: No security risks (documentation changes only)
Migration status: 65% complete (60/92 components migrated)
2025-07-09 08:51:06 +00:00
Jose Olarte III
41dab36eb6 Fix: stepType was being set to an object 2025-07-07 16:20:11 +08:00
Jose Olarte III
993aa005fa Feature: notify on click why entity is disabled 2025-07-04 19:12:56 +08:00
Matthew Raymer
56286e1fea Fix TypeScript any types and remove deprecated Dexie code
- Replace Record<string, any> with Record<string, string> for query params
- Fix error handling from catch(err: any) to catch(err: unknown)
- Add EntityData interface for proper entity typing
- Update EntitySelectionEvent interface with union types
- Remove USE_DEXIE_DB conditionals and unused import
- Clean up database service calls removing Dexie fallbacks

Resolves 9 TypeScript any type warnings, improves type safety across
entity selection components, and removes deprecated database migration code.
2025-07-04 08:06:08 +00:00