Tree:
2a32903326
ai-context
android-15-check
app_id_fix
ask-for-contacts-export
build-dev-to-dist
build-improvement
build-ios
build-with-env
capacitor-local-save
claim-view-error-handling
claimview-fullfills-offer
contact-gifting-current-user
contacts-view-fixes
cross-platform-factory
cross-platform-factory-redux
d9085ced6df7dc7bdcd899959cea6489cab7f8b8
db-backup-cross-platform
deep-link
deep-links-android-update
deep_linking
design-tweaks-2023-12
electron_fix_20250317
experimental_plugin
eye-slash
fix-contact-import-export
fix-service-worker
friend-tech-inspired-pwa-dialog
get-get-hash
gifting-periphery-improvements
gifting-ui-2025-05
home-icon-enhancements
home-view-notification-improvements
homeview-cleanup-2025-03
homeview-refresh-2025-02
imagemagick-anrdoid
ios-contact-copy
logger-level
logging-upgrade
main
master
master-settings-upgrade
matthew-scratch-2025-06-28
migrate-dexie-to-sqlite
nearby-filter
new-storage
nostr
notification-line-wrapping
notification-request-permission-dialog
notification-section
notify-time
offer-edit
offer-validation-logic
onboarding-dialog-fix
passkey
passkey-cache
performance-optimizations-testing
photo-reverse
plan-loc
platformservicemixin-interface-consolidation
playwright-pwa-install-test
playwright-test-60-fix
playwright-test-updates
profile-pic
project-gives
qrcode-capacitor
registration-gate
remove-image-cache
replace-iconrenderer
script-build-mode
search-map-fix
side_step
simple-signer
split_build_process
sql-absurd-sql
sql-absurd-sql-further
sql-wa-sqlite
star-projects
starred-projects
streamline-attempt
sw-cleanup
tmp
trent-tweaks
tweaks
ui-fixes-2024-03
ui-fixes-2025-03
ui-fixes-2025-06-w2
units-mocking
v-onboarding-2024-04
vite-version
web-serve-fix
web-tests
0.1.8
0.2.1
0.2.11
0.2.17
0.2.2
0.2.4
0.3.35
0.3.50
0.3.51
0.3.52
0.3.53
0.3.54
0.3.55
0.3.56
0.3.57
0.4.1
0.4.2
0.4.3
0.4.4
0.5.8
0.5.9
1.0.0
1.0.2
1.0.4
${ noResults }
1 Commits (2a32903326d13e00abfdbf19c909fd97310b7d8b)
| Author | SHA1 | Message | Date |
|---|---|---|---|
Matthew Raymer
|
9067bec54a |
fix: Convert searchBoxes arrays to JSON strings in $saveSettings and $updateSettings
- Add _convertSettingsForStorage helper method to handle Settings → SettingsWithJsonStrings conversion - Fix $saveSettings and $saveUserSettings to properly convert searchBoxes arrays to JSON strings before database storage - Update SearchAreaView.vue to use array format instead of manual JSON.stringify conversion - Add comprehensive test UI in PlatformServiceMixinTest.vue with visual feedback and clear demonstration of conversion process - Document migration strategy for consolidating $updateSettings into $saveSettings to reduce code duplication - Add deprecation notices to $updateSettings method with clear migration guidance The fix ensures that searchBoxes arrays are properly converted to JSON strings before database storage, preventing data corruption and maintaining consistency with the SettingsWithJsonStrings type definition. The enhanced test interface provides clear visualization of the conversion process and database storage format. Migration Strategy: - $saveSettings: ✅ KEEP (will be primary method after consolidation) - $updateSettings: ⚠️ DEPRECATED (will be removed in favor of $saveSettings) - Future: Consolidate to single $saveSettings(changes, did?) method Files changed: - src/utils/PlatformServiceMixin.ts: Add conversion helper, fix save methods, add deprecation notices - src/views/SearchAreaView.vue: Remove manual JSON conversion - src/test/PlatformServiceMixinTest.vue: Add comprehensive test UI with highlighting - docs/migration-templates/updateSettings-consolidation-plan.md: Document future consolidation strategy |
3 weeks ago |