diff --git a/src/components/ActivityListItem.vue b/src/components/ActivityListItem.vue index c87854d6..81cd066c 100644 --- a/src/components/ActivityListItem.vue +++ b/src/components/ActivityListItem.vue @@ -49,7 +49,7 @@ - + diff --git a/src/interfaces/give.ts b/src/interfaces/give.ts index 241955c7..34e519fa 100644 --- a/src/interfaces/give.ts +++ b/src/interfaces/give.ts @@ -1,13 +1,17 @@ +/** + * Interfaces for the give records with limited contact information, good to show on a feed. + **/ + import { GiveSummaryRecord } from "./records"; -// Common interface for contact information +// Common interface for views with summary contact information export interface ContactInfo { known: boolean; displayName: string; profileImageUrl?: string; } -// Define the contact information fields +// Define a subset of contact information fields interface GiveContactInfo { giver: ContactInfo; issuer: ContactInfo; @@ -17,5 +21,5 @@ interface GiveContactInfo { image?: string; } -// Combine GiveSummaryRecord with contact information using intersection type +// Combine GiveSummaryRecord with contact information export type GiveRecordWithContactInfo = GiveSummaryRecord & GiveContactInfo; diff --git a/src/views/HomeView.vue b/src/views/HomeView.vue index b16af716..1ce8e83a 100644 --- a/src/views/HomeView.vue +++ b/src/views/HomeView.vue @@ -347,10 +347,10 @@ import { GiverReceiverInputInfo, OnboardPage, } from "../libs/util"; -import { GiveSummaryRecord } from "../interfaces"; +import { GiveSummaryRecord } from "../interfaces/records"; import * as serverUtil from "../libs/endorserServer"; import { logger } from "../utils/logger"; -import { GiveRecordWithContactInfo } from "../types"; +import { GiveRecordWithContactInfo } from "../interfaces/give"; import { PlatformServiceFactory } from "@/services/PlatformServiceFactory"; interface Claim { diff --git a/test-playwright/30-record-gift.spec.ts b/test-playwright/30-record-gift.spec.ts index f02bccd6..76084f45 100644 --- a/test-playwright/30-record-gift.spec.ts +++ b/test-playwright/30-record-gift.spec.ts @@ -109,11 +109,8 @@ test('Record something given', async ({ page }) => { // Refresh home view and check gift await page.goto('./'); - await page.locator('li') - .filter({ hasText: finalTitle }) - .locator('a.cursor-pointer') - .filter({ hasText: finalTitle }) - .click(); + const item = await page.locator('li').filter({ hasText: finalTitle }); + await item.locator('[data-testid="circle-info-link"]').click(); await expect(page.getByRole('heading', { name: 'Verifiable Claim Details' })).toBeVisible(); await expect(page.getByText(finalTitle, { exact: true })).toBeVisible(); const page1Promise = page.waitForEvent('popup');