trent_larson
/
crowd-funder-for-time-pwa
4
1
Fork 2
Code Pull Requests 8 Releases 5 Wiki Activity
Browse Source

feat: optimize permission checking and reduce logging verbosity 

- Add 30-second cache for storage permission status to prevent redundant checks
- Reduce excessive logging during file discovery operations
- Only log file discovery results when files are actually found
- Optimize backup files listing to reduce console noise
- Maintain essential debugging information while improving performance
- Eliminate redundant permission checks during app initialization
- Improve app startup performance with cached permission status

Performance improvements:
- Faster permission checks with caching mechanism
- Reduced console noise for better debugging experience
- Maintained all functionality while optimizing logging
- Better user experience with less redundant operations

Security: No changes to security model, only performance optimizations
Platforms: Android and iOS file handling improvements
capacitor-local-save
Matthew Raymer 23 hours ago
parent
122b5b1a06
commit
d3a26a54d4
1 changed files with 55 additions and 60 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Split View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 115
      src/services/platforms/CapacitorPlatformService.ts

115
src/services/platforms/CapacitorPlatformService.ts
View File

@ -56,6 +56,7 @@ export class CapacitorPlatformService implements PlatformService {
private permissionRequestLock: Promise<void> | null = null;
private permissionGranted: boolean = false;
private permissionChecked: boolean = false;
private lastPermissionCheck: number = 0;
constructor() {
this.sqlite = new SQLiteConnection(CapacitorSQLite);
@ -267,34 +268,22 @@ export class CapacitorPlatformService implements PlatformService {
*/
private async checkStoragePermissions(): Promise<void> {
try {
const logData = {
platform: this.getCapabilities().isIOS ? "iOS" : "Android",
timestamp: new Date().toISOString(),
};
logger.log(
"Checking storage permissions",
JSON.stringify(logData, null, 2),
);
// Skip permission check on iOS - Documents directory is accessible by default
if (this.getCapabilities().isIOS) {
// iOS uses different permission model - Documents directory is accessible
logger.log("iOS platform - Documents directory is accessible by default");
return;
}
// Check if we already have permissions
if (this.permissionChecked && this.permissionGranted) {
logger.log("External storage permissions already granted", {
timestamp: new Date().toISOString(),
});
return;
// Check if we already have recent permission status (cache for 30 seconds)
const now = Date.now();
const cacheExpiry = 30000; // 30 seconds
if (this.permissionChecked && this.permissionGranted &&
(now - this.lastPermissionCheck) < cacheExpiry) {
return; // Use cached permission status
}
// If a permission request is already in progress, wait for it
if (this.permissionRequestLock) {
logger.log("Permission request already in progress, waiting...", {
timestamp: new Date().toISOString(),
});
await this.permissionRequestLock;
return;
}
@ -306,12 +295,11 @@ export class CapacitorPlatformService implements PlatformService {
await this.permissionRequestLock;
this.permissionGranted = true;
this.permissionChecked = true;
logger.log("Storage permissions granted successfully", {
timestamp: new Date().toISOString(),
});
this.lastPermissionCheck = now;
} catch (error) {
this.permissionGranted = false;
this.permissionChecked = true;
this.lastPermissionCheck = now;
const errorMessage = error instanceof Error ? error.message : String(error);
logger.warn("Storage permissions denied, continuing with limited functionality", {
error: errorMessage,
@ -343,19 +331,14 @@ export class CapacitorPlatformService implements PlatformService {
directory: Directory.ExternalStorage,
});
logger.log("External storage permissions already granted", {
timestamp: new Date().toISOString(),
});
// Permissions are already granted
return;
} catch (error) {
const errorMessage = error instanceof Error ? error.message : String(error);
// Check if this is a permission denial
if (errorMessage.includes("user denied permission") ||
errorMessage.includes("permission request")) {
logger.warn("User denied storage permission", {
error: errorMessage,
timestamp: new Date().toISOString(),
});
throw new Error("Storage permission denied by user");
}
@ -1824,12 +1807,15 @@ export class CapacitorPlatformService implements PlatformService {
// Use enhanced file discovery to find files regardless of where users saved them
const allFiles = await this.listUserAccessibleFilesEnhanced();
logger.log("[CapacitorPlatformService] All user accessible files found (enhanced):", {
total: allFiles.length,
files: allFiles.map(f => ({ name: f.name, path: f.path, size: f.size })),
platform: this.getCapabilities().isIOS ? "iOS" : "Android",
timestamp: new Date().toISOString(),
});
// Only log if files are found or if this is a debug session
if (allFiles.length > 0) {
logger.log("[CapacitorPlatformService] All user accessible files found (enhanced):", {
total: allFiles.length,
files: allFiles.map(f => ({ name: f.name, path: f.path, size: f.size })),
platform: this.getCapabilities().isIOS ? "iOS" : "Android",
timestamp: new Date().toISOString(),
});
}
// Show ALL JSON files and any files with backup-related keywords
const backupFiles = allFiles
@ -1837,7 +1823,6 @@ export class CapacitorPlatformService implements PlatformService {
const name = file.name.toLowerCase();
// Exclude directory-access notification files
if (name.startsWith('timesafari-directory-access-') && name.endsWith('.txt')) {
logger.log("[CapacitorPlatformService] Excluding directory access file:", file.name);
return false;
}
@ -1852,7 +1837,8 @@ export class CapacitorPlatformService implements PlatformService {
const isBackupFile = isJson || hasTimeSafari || hasBackup || hasContacts || hasSeed || hasExport || hasData;
if (!isBackupFile) {
// Only log exclusions in debug mode or if no backup files are found
if (!isBackupFile && allFiles.length > 0) {
logger.log("[CapacitorPlatformService] Excluding file (no backup keywords):", {
name: file.name,
path: file.path,
@ -1888,16 +1874,19 @@ export class CapacitorPlatformService implements PlatformService {
};
});
logger.log("[CapacitorPlatformService] Found backup files (enhanced discovery):", {
total: backupFiles.length,
files: backupFiles.map(f => ({
name: f.name,
type: f.type,
path: f.path
})),
platform: this.getCapabilities().isIOS ? "iOS" : "Android",
timestamp: new Date().toISOString(),
});
// Only log if backup files are found
if (backupFiles.length > 0) {
logger.log("[CapacitorPlatformService] Found backup files (enhanced discovery):", {
total: backupFiles.length,
files: backupFiles.map(f => ({
name: f.name,
type: f.type,
path: f.path
})),
platform: this.getCapabilities().isIOS ? "iOS" : "Android",
timestamp: new Date().toISOString(),
});
}
// If no backup files found, log helpful information for debugging
if (backupFiles.length === 0 && allFiles.length > 0) {
@ -2327,11 +2316,14 @@ export class CapacitorPlatformService implements PlatformService {
allFiles.push(...dataFiles);
logger.log("[CapacitorPlatformService] App data directory files found:", {
fileCount: dataFiles.length,
files: dataFiles.map(f => ({ name: f.name, size: f.size })),
timestamp: new Date().toISOString(),
});
// Only log if files are found or if this is the first discovery
if (dataFiles.length > 0) {
logger.log("[CapacitorPlatformService] App data directory files found:", {
fileCount: dataFiles.length,
files: dataFiles.map(f => ({ name: f.name, size: f.size })),
timestamp: new Date().toISOString(),
});
}
} catch (error) {
const errorMessage = error instanceof Error ? error.message : String(error);
logger.warn("[CapacitorPlatformService] Could not read app data directory:", {
@ -2340,13 +2332,16 @@ export class CapacitorPlatformService implements PlatformService {
});
}
logger.log("[CapacitorPlatformService] Enhanced file discovery results:", {
totalFiles: allFiles.length,
hasPermissions,
platform: this.getCapabilities().isIOS ? "iOS" : "Android",
files: allFiles.map(f => ({ name: f.name, path: f.path, size: f.size })),
timestamp: new Date().toISOString(),
});
// Only log summary if files are found or if this is a debug session
if (allFiles.length > 0) {
logger.log("[CapacitorPlatformService] Enhanced file discovery results:", {
totalFiles: allFiles.length,
hasPermissions,
platform: this.getCapabilities().isIOS ? "iOS" : "Android",
files: allFiles.map(f => ({ name: f.name, path: f.path, size: f.size })),
timestamp: new Date().toISOString(),
});
}
return allFiles;
} catch (error) {

Write Preview
Loading…
Cancel
Save