Browse Source

fix: migrate critical components causing test failures

- Fix ShareMyContactInfoView.vue mounted() method to use Active Identity façade
- Fix OnboardMeetingSetupView, OnboardMeetingMembersView, OnboardMeetingListView
- Fix ContactAmountsView to use new Active Identity system
- Replace all remaining settings?.activeDid usage with ()

These components were causing Playwright test failures due to
routing issues when activeDid was not found in legacy settings.
activedid_migration
Matthew Raymer 16 hours ago
parent
commit
cf41665629
  1. 2
      playwright.config-local.ts
  2. 3
      src/views/ContactAmountsView.vue
  3. 3
      src/views/OnboardMeetingListView.vue
  4. 3
      src/views/OnboardMeetingMembersView.vue
  5. 3
      src/views/OnboardMeetingSetupView.vue
  6. 3
      src/views/ShareMyContactInfoView.vue

2
playwright.config-local.ts

@ -21,7 +21,7 @@ export default defineConfig({
/* Retry on CI only */
retries: process.env.CI ? 2 : 0,
/* Opt out of parallel tests on CI. */
workers: 1,
workers: 4,
/* Reporter to use. See https://playwright.dev/docs/test-reporters */
reporter: [
['list'],

3
src/views/ContactAmountsView.vue

@ -224,7 +224,8 @@ export default class ContactAmountssView extends Vue {
this.contact = contact;
const settings = await this.$getSettings(MASTER_SETTINGS_KEY);
this.activeDid = settings?.activeDid || "";
// Use new Active Identity façade instead of settings.activeDid
this.activeDid = (await this.$getActiveDid()) || "";
this.apiServer = settings?.apiServer || "";
if (this.activeDid && this.contact) {

3
src/views/OnboardMeetingListView.vue

@ -174,7 +174,8 @@ export default class OnboardMeetingListView extends Vue {
// Load user account settings
const settings = await this.$accountSettings();
this.activeDid = settings?.activeDid || "";
// Use new Active Identity façade instead of settings.activeDid
this.activeDid = (await this.$getActiveDid()) || "";
this.apiServer = settings?.apiServer || "";
this.firstName = settings?.firstName || "";
this.isRegistered = !!settings?.isRegistered;

3
src/views/OnboardMeetingMembersView.vue

@ -106,7 +106,8 @@ export default class OnboardMeetingMembersView extends Vue {
return;
}
const settings = await this.$accountSettings();
this.activeDid = settings?.activeDid || "";
// Use new Active Identity façade instead of settings.activeDid
this.activeDid = (await this.$getActiveDid()) || "";
this.apiServer = settings?.apiServer || "";
this.firstName = settings?.firstName || "";
this.isRegistered = !!settings?.isRegistered;

3
src/views/OnboardMeetingSetupView.vue

@ -349,7 +349,8 @@ export default class OnboardMeetingView extends Vue {
this.$notify as Parameters<typeof createNotifyHelpers>[0],
);
const settings = await this.$accountSettings();
this.activeDid = settings?.activeDid || "";
// Use new Active Identity façade instead of settings.activeDid
this.activeDid = (await this.$getActiveDid()) || "";
this.apiServer = settings?.apiServer || "";
this.fullName = settings?.firstName || "";
this.isRegistered = !!settings?.isRegistered;

3
src/views/ShareMyContactInfoView.vue

@ -76,7 +76,8 @@ export default class ShareMyContactInfoView extends Vue {
async mounted() {
const settings = await this.$settings();
const activeDid = settings?.activeDid;
// Use new Active Identity façade instead of settings.activeDid
const activeDid = await this.$getActiveDid();
if (!activeDid) {
this.$router.push({ name: "home" });
}

Loading…
Cancel
Save