From ce5933f6455508dd996cab5f3b36637946baef2c Mon Sep 17 00:00:00 2001
From: Trent Larson <trent@trentlarson.com>
Date: Mon, 4 Dec 2023 13:29:16 -0700
Subject: [PATCH] remove visibility to contact operations where there is no
 activeDid

---
 project.task.yaml          |   3 --
 src/views/ContactsView.vue | 100 ++++++++++++++++++++-----------------
 2 files changed, 54 insertions(+), 49 deletions(-)

diff --git a/project.task.yaml b/project.task.yaml
index aff2cca..f22b95d 100644
--- a/project.task.yaml
+++ b/project.task.yaml
@@ -1,13 +1,10 @@
 
 tasks:
 
-- in endorser-push-server - mount folder for persistent sqlite DB outside of container
 - extract private_key_hex in webpush.py
 - 40 notifications :
   - push, where we trigger a ServiceWorker(?) in the app to reach out and check for new data assignee:matthew
 
-- .2 change the "claims" verbiage in feeds (eg. safari-notifications.js)
-- .5 allow to manage their notifications even without an identity
 - 01 Ensure each action sent to the server has a confirmation - eg registration (ie a toast something that dismisses after 5-10s)
 - .3 fix the Project-location-selection map display to not show on top of bottom icons (and any other UI tweaks on the map flow) assignee-group:ui
 
diff --git a/src/views/ContactsView.vue b/src/views/ContactsView.vue
index c7ca1df..0e75ad0 100644
--- a/src/views/ContactsView.vue
+++ b/src/views/ContactsView.vue
@@ -110,48 +110,50 @@
           </div>
 
           <div id="ContactActions" class="flex gap-1.5 mt-2">
-            <button
-              v-if="contact.seesMe"
-              class="text-sm uppercase bg-slate-500 text-white px-2 py-1.5 rounded-md"
-              @click="setVisibility(contact, false, true)"
-              title="They can see you"
-            >
-              <fa icon="eye" class="fa-fw" />
-            </button>
-            <button
-              v-else
-              class="text-sm uppercase bg-slate-500 text-white px-2 py-1.5 rounded-md"
-              @click="setVisibility(contact, true, true)"
-              title="They cannot see you"
-            >
-              <fa icon="eye-slash" class="fa-fw" />
-            </button>
-
-            <button
-              class="text-sm uppercase bg-slate-500 text-white px-2 py-1.5 rounded-md"
-              @click="checkVisibility(contact)"
-              title="Check Visibility"
-            >
-              <fa icon="rotate" class="fa-fw" />
-            </button>
-
-            <button
-              @click="register(contact)"
-              class="text-sm uppercase bg-slate-500 text-white ml-6 px-2 py-1.5 rounded-md"
-            >
-              <fa
-                v-if="contact.registered"
-                icon="person-circle-check"
-                class="fa-fw"
-                title="Registered"
-              />
-              <fa
+            <div v-if="activeDid">
+              <button
+                v-if="contact.seesMe"
+                class="text-sm uppercase bg-slate-500 text-white px-2 py-1.5 rounded-md"
+                @click="setVisibility(contact, false, true)"
+                title="They can see you"
+              >
+                <fa icon="eye" class="fa-fw" />
+              </button>
+              <button
                 v-else
-                icon="person-circle-question"
-                class="fa-fw"
-                title="Registration Unknown"
-              />
-            </button>
+                class="text-sm uppercase bg-slate-500 text-white px-2 py-1.5 rounded-md"
+                @click="setVisibility(contact, true, true)"
+                title="They cannot see you"
+              >
+                <fa icon="eye-slash" class="fa-fw" />
+              </button>
+              <button
+                class="text-sm uppercase bg-slate-500 text-white px-2 py-1.5 rounded-md"
+                @click="checkVisibility(contact)"
+                title="Check Visibility"
+                v-if="activeDid"
+              >
+                <fa icon="rotate" class="fa-fw" />
+              </button>
+              <button
+                @click="register(contact)"
+                class="text-sm uppercase bg-slate-500 text-white ml-6 px-2 py-1.5 rounded-md"
+                v-if="activeDid"
+              >
+                <fa
+                  v-if="contact.registered"
+                  icon="person-circle-check"
+                  class="fa-fw"
+                  title="Registered"
+                />
+                <fa
+                  v-else
+                  icon="person-circle-question"
+                  class="fa-fw"
+                  title="Registration Unknown"
+                />
+              </button>
+            </div>
 
             <button
               @click="deleteContact(contact)"
@@ -540,17 +542,23 @@ export default class ContactsView extends Vue {
           (a: Contact, b) => (a.name || "").localeCompare(b.name || ""),
           allContacts,
         );
-        this.setVisibility(newContact, true, false);
+        let addedMessage;
+        if (this.activeDid) {
+          this.setVisibility(newContact, true, false);
+          addedMessage =
+            newContact.name +
+            " was added, and your activity is visible to them.";
+        } else {
+          addedMessage = newContact.name + " was added.";
+        }
         this.$notify(
           {
             group: "alert",
             type: "success",
             title: "Contact Added",
-            text:
-              newContact.name +
-              " was added, and your activity is visible to them.",
+            text: addedMessage,
           },
-          -1,
+          5000,
         );
         // putting this last so that it shows on the top
         this.$notify(