Browse Source

fix(lint): resolve low and medium impact warnings

- Remove console statements and replace with proper logging
- Fix line length violations in comments
- Maintain functionality while improving code quality

Reduces lint warnings from 30 to 25 by addressing:
- 3 console statement violations
- 2 line length violations
pull/164/head^2
Matthew Raymer 3 days ago
parent
commit
adfaef7947
  1. 2
      src/components/ContactInputForm.vue
  2. 2
      src/services/deepLinks.ts
  3. 3
      src/services/platforms/WebPlatformService.ts
  4. 3
      src/views/AccountViewView.vue
  5. 3
      src/views/DIDView.vue

2
src/components/ContactInputForm.vue

@ -167,7 +167,7 @@ export default class ContactInputForm extends Vue {
*/ */
@Emit("qr-scan") @Emit("qr-scan")
private handleQRScan(): void { private handleQRScan(): void {
console.log("[ContactInputForm] QR scan button clicked"); // QR scan button clicked - event emitted for parent handling
} }
} }
</script> </script>

2
src/services/deepLinks.ts

@ -179,7 +179,7 @@ export class DeepLinkHandler {
const validRoute = routeSchema.parse(path) as DeepLinkRoute; const validRoute = routeSchema.parse(path) as DeepLinkRoute;
routeName = ROUTE_MAP[validRoute].name; routeName = ROUTE_MAP[validRoute].name;
} catch (error) { } catch (error) {
console.error(`[DeepLink] Invalid route path: ${path}`); logger.error(`[DeepLink] Invalid route path: ${path}`);
// Redirect to error page with information about the invalid link // Redirect to error page with information about the invalid link
await this.router.replace({ await this.router.replace({

3
src/services/platforms/WebPlatformService.ts

@ -693,7 +693,8 @@ export class WebPlatformService implements PlatformService {
const setClause = keys.map((key) => `${key} = ?`).join(", "); const setClause = keys.map((key) => `${key} = ?`).join(", ");
const sql = `UPDATE settings SET ${setClause} WHERE accountDid = ?`; const sql = `UPDATE settings SET ${setClause} WHERE accountDid = ?`;
const params = [...keys.map((key) => settings[key]), did]; const params = [...keys.map((key) => settings[key]), did];
console.log( // Log update operation for debugging
logger.debug(
"[WebPlatformService] updateDidSpecificSettings", "[WebPlatformService] updateDidSpecificSettings",
sql, sql,
JSON.stringify(params, null, 2), JSON.stringify(params, null, 2),

3
src/views/AccountViewView.vue

@ -61,7 +61,8 @@
/> />
<!-- Notifications --> <!-- Notifications -->
<!-- Currently disabled because it doesn't work, even on Chrome. If restored, make sure it works or doesn't show on mobile/electron. --> <!-- Currently disabled because it doesn't work, even on Chrome.
If restored, make sure it works or doesn't show on mobile/electron. -->
<section <section
v-if="false" v-if="false"
id="sectionNotifications" id="sectionNotifications"

3
src/views/DIDView.vue

@ -7,7 +7,8 @@
<!-- Breadcrumb --> <!-- Breadcrumb -->
<div id="ViewBreadcrumb" class="mb-8"> <div id="ViewBreadcrumb" class="mb-8">
<h1 id="ViewHeading" class="text-lg text-center font-light relative px-7"> <h1 id="ViewHeading" class="text-lg text-center font-light relative px-7">
<!-- Go to 'contacts' instead of just 'back' because they could get here from an edit page (and going back there is annoying). --> <!-- Go to 'contacts' instead of just 'back' because they could get here from an edit page
(and going back there is annoying). -->
<router-link <router-link
:to="{ name: 'contacts' }" :to="{ name: 'contacts' }"
class="text-lg text-center px-2 py-1 absolute -left-2 -top-1" class="text-lg text-center px-2 py-1 absolute -left-2 -top-1"

Loading…
Cancel
Save