From 8e6c83021fbc9877dc2ff0d2401b9bc48aa90358 Mon Sep 17 00:00:00 2001 From: Jose Olarte III Date: Fri, 17 Jul 2026 20:04:08 +0800 Subject: [PATCH] fix(assets): rename splash_dark.png to splash-dark.png Match the filename @capacitor/assets expects so iOS uses the custom dark splash instead of the logo-on-black fallback. --- BUILDING.md | 2 +- README.md | 2 +- capacitor-assets.config.json | 2 +- config/assets/capacitor-assets.config.json | 2 +- doc/android-asset-validation.md | 6 +++--- doc/asset-migration-plan.md | 2 +- resources/{splash_dark.png => splash-dark.png} | Bin scripts/assets-config.ts | 4 ++-- scripts/build-android.sh | 8 ++++---- 9 files changed, 14 insertions(+), 14 deletions(-) rename resources/{splash_dark.png => splash-dark.png} (100%) diff --git a/BUILDING.md b/BUILDING.md index 78e376b7..040b2fec 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -1360,7 +1360,7 @@ npm run assets:validate **Source Assets (Required):** - `resources/icon.png` - App icon source - `resources/splash.png` - Splash screen source -- `resources/splash_dark.png` - Dark mode splash source +- `resources/splash-dark.png` - Dark mode splash source **Android Resources (Generated):** - `android/app/src/main/res/drawable/splash.png` - Splash screen drawable diff --git a/README.md b/README.md index 642c7a44..446f2d69 100644 --- a/README.md +++ b/README.md @@ -199,7 +199,7 @@ icon and splash screen generation across all platforms. ### Asset Sources - **Single source of truth**: `resources/` directory (Capacitor default) -- **Source files**: `icon.png`, `splash.png`, `splash_dark.png` +- **Source files**: `icon.png`, `splash.png`, `splash-dark.png` - **Format**: PNG or SVG files for optimal quality ### Asset Generation diff --git a/capacitor-assets.config.json b/capacitor-assets.config.json index f6b2fc9a..90ae8240 100644 --- a/capacitor-assets.config.json +++ b/capacitor-assets.config.json @@ -22,7 +22,7 @@ "scale": "cover", "target": "android/app/src/main/res" }, - "darkSource": "resources/splash_dark.png", + "darkSource": "resources/splash-dark.png", "ios": { "target": "ios/App/App/Assets.xcassets", "useStoryBoard": true diff --git a/config/assets/capacitor-assets.config.json b/config/assets/capacitor-assets.config.json index 92bd0414..69b8f2d8 100644 --- a/config/assets/capacitor-assets.config.json +++ b/config/assets/capacitor-assets.config.json @@ -22,7 +22,7 @@ "scale": "cover", "target": "android/app/src/main/res" }, - "darkSource": "resources/splash_dark.png", + "darkSource": "resources/splash-dark.png", "ios": { "target": "ios/App/App/Assets.xcassets", "useStoryBoard": true diff --git a/doc/android-asset-validation.md b/doc/android-asset-validation.md index db77aeb8..b34b8a1e 100644 --- a/doc/android-asset-validation.md +++ b/doc/android-asset-validation.md @@ -47,7 +47,7 @@ npm run build:android:studio #### Source Assets (Required) - `resources/icon.png` - App icon source - `resources/splash.png` - Splash screen source -- `resources/splash_dark.png` - Dark mode splash source +- `resources/splash-dark.png` - Dark mode splash source #### Android Resources (Generated) - `android/app/src/main/res/drawable/splash.png` - Splash screen drawable @@ -201,13 +201,13 @@ mkdir -p android/app/src/main/res/mipmap-{mdpi,hdpi,xhdpi,xxhdpi,xxxhdpi} # Copy source assets to assets directory cp resources/icon.png assets/ cp resources/splash.png assets/ -cp resources/splash_dark.png assets/ +cp resources/splash-dark.png assets/ # Generate assets manually npx @capacitor/assets generate # Clean up -rm assets/icon.png assets/splash.png assets/splash_dark.png +rm assets/icon.png assets/splash.png assets/splash-dark.png ``` ## Future Enhancements diff --git a/doc/asset-migration-plan.md b/doc/asset-migration-plan.md index 86c0954e..79ce8b65 100644 --- a/doc/asset-migration-plan.md +++ b/doc/asset-migration-plan.md @@ -89,7 +89,7 @@ system to a standardized, single-source asset configuration approach using resources/ # Image sources ONLY icon.png splash.png - splash_dark.png + splash-dark.png config/assets/ # Versioned config & schema capacitor-assets.config.json diff --git a/resources/splash_dark.png b/resources/splash-dark.png similarity index 100% rename from resources/splash_dark.png rename to resources/splash-dark.png diff --git a/scripts/assets-config.ts b/scripts/assets-config.ts index baaadce5..30f924af 100644 --- a/scripts/assets-config.ts +++ b/scripts/assets-config.ts @@ -92,7 +92,7 @@ function generateAssetConfig(): AssetConfig { }, splash: { source: "resources/splash.png", - darkSource: "resources/splash_dark.png", + darkSource: "resources/splash-dark.png", android: { scale: "cover", target: "android/app/src/main/res" @@ -138,7 +138,7 @@ function validateSourceFiles(): void { const requiredFiles = [ 'resources/icon.png', 'resources/splash.png', - 'resources/splash_dark.png' + 'resources/splash-dark.png' ]; const missingFiles = requiredFiles.filter(file => { diff --git a/scripts/build-android.sh b/scripts/build-android.sh index 4a5fc808..6b18c015 100755 --- a/scripts/build-android.sh +++ b/scripts/build-android.sh @@ -230,8 +230,8 @@ validate_android_assets() { missing_assets+=("resources/splash.png") fi - if [ ! -f "resources/splash_dark.png" ]; then - missing_assets+=("resources/splash_dark.png") + if [ ! -f "resources/splash-dark.png" ]; then + missing_assets+=("resources/splash-dark.png") fi if [ ${#missing_assets[@]} -gt 0 ]; then @@ -278,14 +278,14 @@ validate_android_assets() { # Copy source assets to assets directory for capacitor-assets cp resources/icon.png assets/ 2>/dev/null || log_warn "Could not copy icon.png" cp resources/splash.png assets/ 2>/dev/null || log_warn "Could not copy splash.png" - cp resources/splash_dark.png assets/ 2>/dev/null || log_warn "Could not copy splash_dark.png" + cp resources/splash-dark.png assets/ 2>/dev/null || log_warn "Could not copy splash-dark.png" # Generate assets if npx @capacitor/assets generate >/dev/null 2>&1; then log_success "Android assets regenerated successfully" # Clean up temporary assets - rm -f assets/icon.png assets/splash.png assets/splash_dark.png + rm -f assets/icon.png assets/splash.png assets/splash-dark.png # Verify the resources were created local verification_failed=false