From 8b199ec76c10f8d921c9ea2f66604dcdd20fe824 Mon Sep 17 00:00:00 2001
From: Jose Olarte III <jose.anomalist.design@gmail.com>
Date: Tue, 4 Nov 2025 17:57:38 +0800
Subject: [PATCH] refactor: remove redundant dialogType prop from
 BulkMembersDialog

Remove dialogType prop and consolidate to use only isOrganizer prop.

- Remove dialogType prop from BulkMembersDialog component
- Replace all dialogType checks with isOrganizer boolean checks
- Add comments clarifying isOrganizer true/false meanings
- Remove dialog-type prop binding from MembersList component

This simplifies the component API while maintaining the same functionality.
---
 src/components/BulkMembersDialog.vue | 13 +++++++------
 src/components/MembersList.vue       |  1 -
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/components/BulkMembersDialog.vue b/src/components/BulkMembersDialog.vue
index 412ade19..650beea0 100644
--- a/src/components/BulkMembersDialog.vue
+++ b/src/components/BulkMembersDialog.vue
@@ -145,7 +145,7 @@ import { Contact } from "@/db/tables/contacts";
 export default class BulkMembersDialog extends Vue {
   @Prop({ default: "" }) activeDid!: string;
   @Prop({ default: "" }) apiServer!: string;
-  @Prop({ required: true }) dialogType!: "admit" | "visibility";
+  // isOrganizer: true = organizer mode (admit members), false = member mode (set visibility)
   @Prop({ required: true }) isOrganizer!: boolean;
 
   // Vue notification system
@@ -253,7 +253,8 @@ export default class BulkMembersDialog extends Vue {
   }
 
   async handleMainAction() {
-    if (this.dialogType === "admit") {
+    // isOrganizer: true = admit mode, false = visibility mode
+    if (this.isOrganizer) {
       await this.organizerAdmitAndAddWithVisibility();
     } else {
       await this.memberAddContactWithVisibility();
@@ -487,10 +488,10 @@ export default class BulkMembersDialog extends Vue {
   }
 
   showContactInfo() {
-    const message =
-      this.dialogType === "admit"
-        ? "This user is already your contact, but they are not yet admitted to the meeting."
-        : "This user is already your contact, but your activities are not visible to them yet.";
+    // isOrganizer: true = admit mode, false = visibility mode
+    const message = this.isOrganizer
+      ? "This user is already your contact, but they are not yet admitted to the meeting."
+      : "This user is already your contact, but your activities are not visible to them yet.";
 
     this.$notify(
       {
diff --git a/src/components/MembersList.vue b/src/components/MembersList.vue
index d1b10567..d3ae2a88 100644
--- a/src/components/MembersList.vue
+++ b/src/components/MembersList.vue
@@ -223,7 +223,6 @@
       ref="bulkMembersDialog"
       :active-did="activeDid"
       :api-server="apiServer"
-      :dialog-type="isOrganizer ? 'admit' : 'visibility'"
       :is-organizer="isOrganizer"
       @close="closeBulkMembersDialogCallback"
     />