Browse Source

fix: use "starred" instead of "favorite", fix tests

pull/203/head
Trent Larson 6 days ago
parent
commit
6fe4f21ea8
  1. 2
      src/views/HomeView.vue
  2. 4
      src/views/NewActivityView.vue
  3. 5
      test-playwright/20-create-project.spec.ts
  4. 4
      test-playwright/60-new-activity.spec.ts

2
src/views/HomeView.vue

@ -213,7 +213,7 @@ Raymer * @version 1.0.0 */
}}{{ newStarredProjectChangesHitLimit ? "+" : "" }} }}{{ newStarredProjectChangesHitLimit ? "+" : "" }}
</span> </span>
<p class="text-center"> <p class="text-center">
favorite project{{ numNewStarredProjectChanges === 1 ? "" : "s" }} starred project{{ numNewStarredProjectChanges === 1 ? "" : "s" }}
with changes with changes
</p> </p>
</div> </div>

4
src/views/NewActivityView.vue

@ -161,7 +161,7 @@
}}{{ newStarredProjectChangesHitLimit ? "+" : "" }}</span }}{{ newStarredProjectChangesHitLimit ? "+" : "" }}</span
> >
<span class="text-lg font-medium ml-4" <span class="text-lg font-medium ml-4"
>Favorite Project{{ >Starred Project{{
newStarredProjectChanges.length === 1 ? "" : "s" newStarredProjectChanges.length === 1 ? "" : "s"
}} }}
With Changes</span With Changes</span
@ -446,7 +446,7 @@ export default class NewActivityView extends Vue {
// note that we don't update this.lastAckedOfferToUserJwtId in case they // note that we don't update this.lastAckedOfferToUserJwtId in case they
// later choose the last one to keep the offers as new // later choose the last one to keep the offers as new
this.notify.info( this.notify.info(
"The offers are marked read. Click in the list to keep them unread.", "The offers are marked as read. Click in the list to keep them unread.",
TIMEOUTS.LONG, TIMEOUTS.LONG,
); );
} }

5
test-playwright/20-create-project.spec.ts

@ -100,7 +100,10 @@ test('Create new project, then search for it', async ({ page }) => {
const finalTitle = standardTitle + finalRandomString; const finalTitle = standardTitle + finalRandomString;
const finalDescription = standardDescription + finalRandomString; const finalDescription = standardDescription + finalRandomString;
const editedTitle = finalTitle + standardEdit; const editedTitle = finalTitle + standardEdit;
const editedDescription = finalDescription + standardEdit; const editedDescription =
finalDescription +
standardEdit +
" ... and enough text to overflow into the 'Read More' section.";
// Import user 00 // Import user 00
await importUser(page, '00'); await importUser(page, '00');

4
test-playwright/60-new-activity.spec.ts

@ -109,7 +109,7 @@ test('New offers for another user', async ({ page }) => {
await expect(page.getByText('New Offers To You', { exact: true })).toBeVisible(); await expect(page.getByText('New Offers To You', { exact: true })).toBeVisible();
await page.getByTestId('showOffersToUser').locator('div > svg.fa-chevron-right').click(); await page.getByTestId('showOffersToUser').locator('div > svg.fa-chevron-right').click();
await expect(page.getByText('The offers are marked as viewed')).toBeVisible(); await expect(page.getByText('The offers are marked as read')).toBeVisible();
await page.getByRole('alert').filter({ hasText: 'Info' }).getByRole('button').click(); // dismiss info alert await page.getByRole('alert').filter({ hasText: 'Info' }).getByRole('button').click(); // dismiss info alert
await page.waitForTimeout(1000); await page.waitForTimeout(1000);
@ -140,7 +140,7 @@ test('New offers for another user', async ({ page }) => {
await expect(page.getByText('New Offer To You', { exact: true })).toBeVisible(); await expect(page.getByText('New Offer To You', { exact: true })).toBeVisible();
await page.getByTestId('showOffersToUser').locator('div > svg.fa-chevron-right').click(); await page.getByTestId('showOffersToUser').locator('div > svg.fa-chevron-right').click();
await expect(page.getByText('The offers are marked as viewed')).toBeVisible(); await expect(page.getByText('The offers are marked as read')).toBeVisible();
await page.getByRole('alert').filter({ hasText: 'Info' }).getByRole('button').click(); // dismiss info alert await page.getByRole('alert').filter({ hasText: 'Info' }).getByRole('button').click(); // dismiss info alert
// now see that no offers are shown as new // now see that no offers are shown as new

Loading…
Cancel
Save