trent_larson/crowd-funder-for-time-pwa
4
1
Fork 2
Code Issues Pull Requests 20 Releases 5 Wiki Activity

refactor: simplify notification messages for offer viewing

Browse Source 
- Remove conditional notification logic in NewActivityView
- Remove redundant notification in RecentOffersToUserView and RecentOffersToUserProjectsView
- Standardize to single notification message format
This commit is contained in:
Jose Olarte III
2025-09-19 15:00:17 +08:00
parent 5d9f455fc8
commit 6fd53b020e
3 changed files with 10 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/views/NewActivityView.vue
View File

@@ -242,7 +242,7 @@ export default class NewActivityView extends Vue {
} }
} }
async expandOffersToUserAndMarkRead(fromSeeAll: boolean = false) { async expandOffersToUserAndMarkRead() {
this.showOffersDetails = !this.showOffersDetails; this.showOffersDetails = !this.showOffersDetails;
if (this.showOffersDetails && this.newOffersToUser.length > 0) { if (this.showOffersDetails && this.newOffersToUser.length > 0) {
await this.$updateSettings({ await this.$updateSettings({
@@ -250,10 +250,10 @@ export default class NewActivityView extends Vue {
}); });
// note that we don't update this.lastAckedOfferToUserJwtId in case they // note that we don't update this.lastAckedOfferToUserJwtId in case they
// later choose the last one to keep the offers as new // later choose the last one to keep the offers as new
const message = fromSeeAll this.notify.info(
? "The offers are marked as viewed." "The offers are marked as viewed. Click in the list to keep them as new.",
: "The offers are marked as viewed. Click in the list to keep them as new."; TIMEOUTS.LONG,
this.notify.info(message, TIMEOUTS.LONG); );
} }
} }
@@ -278,7 +278,7 @@ export default class NewActivityView extends Vue {
); );
} }
async expandOffersToUserProjectsAndMarkRead(fromSeeAll: boolean = false) { async expandOffersToUserProjectsAndMarkRead() {
this.showOffersToUserProjectsDetails = this.showOffersToUserProjectsDetails =
!this.showOffersToUserProjectsDetails; !this.showOffersToUserProjectsDetails;
if ( if (
@@ -291,10 +291,10 @@ export default class NewActivityView extends Vue {
}); });
// note that we don't update this.lastAckedOfferToUserProjectsJwtId in case // note that we don't update this.lastAckedOfferToUserProjectsJwtId in case
// they later choose the last one to keep the offers as new // they later choose the last one to keep the offers as new
const message = fromSeeAll this.notify.info(
? "The offers are marked as viewed." "The offers are marked as viewed. Click in the list to keep them as new.",
: "The offers are marked as viewed. Click in the list to keep them as new."; TIMEOUTS.LONG,
this.notify.info(message, TIMEOUTS.LONG); );
} }
} }

1
src/views/RecentOffersToUserProjectsView.vue
View File

@@ -148,7 +148,6 @@ export default class RecentOffersToUserView extends Vue {
lastAckedOfferToUserProjectsJwtId: lastAckedOfferToUserProjectsJwtId:
this.newOffersToUserProjects[0].jwtId, this.newOffersToUserProjects[0].jwtId,
}); });
this.notify.info("The offers are marked as viewed.", TIMEOUTS.LONG);
} }
// eslint-disable-next-line @typescript-eslint/no-explicit-any // eslint-disable-next-line @typescript-eslint/no-explicit-any

1
src/views/RecentOffersToUserView.vue
View File

@@ -138,7 +138,6 @@ export default class RecentOffersToUserView extends Vue {
await this.$updateSettings({ await this.$updateSettings({
lastAckedOfferToUserJwtId: this.newOffersToUser[0].jwtId, lastAckedOfferToUserJwtId: this.newOffersToUser[0].jwtId,
}); });
this.notify.info("The offers are marked as viewed.", TIMEOUTS.LONG);
} }
// eslint-disable-next-line @typescript-eslint/no-explicit-any // eslint-disable-next-line @typescript-eslint/no-explicit-any