show more succinct info in feed, targeted toward user's visibility

src/libs/endorserServer.ts

@@ -352,10 +352,54 @@ export function removeVisibleToDids(input: any): any {
   }
 }
 
-/**
- always returns text, maybe UNNAMED_VISIBLE or UNKNOWN_ENTITY
+export function contactForDid(
+  did: string | undefined,
+  contacts: Contact[],
+): Contact | undefined {
+  return isEmptyOrHiddenDid(did)
+    ? undefined
+    : R.find((c) => c.did === did, contacts);
+}
 
- Similar logic is found in endorser-mobile.
+/**
+ *
+ * Similar logic is found in endorser-mobile.
+ *
+ * @param did
+ * @param activeDid
+ * @param contact
+ * @param allMyDids
+ * @return { known: boolean, displayName: string } where known is true if the display name is some easily-recogizable name, false if it's a generic name like "Someone Anonymous"
+ */
+export function didInfoForContact(
+  did: string | undefined,
+  activeDid: string | undefined,
+  contact?: Contact,
+  allMyDids: string[] = [],
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+): { known: boolean; displayName: string } {
+  if (!did) return { displayName: "Someone Anonymous", known: false };
+  if (contact) {
+    return {
+      displayName: contact.name || "Contact With No Name",
+      known: !!contact.name,
+    };
+  } else if (did === activeDid) {
+    return { displayName: "You", known: true };
+  } else {
+    const myId = R.find(R.equals(did), allMyDids);
+    return myId
+      ? { displayName: "You (Alt ID)", known: true }
+      : isHiddenDid(did)
+        ? { displayName: "Someone Outside Your Network", known: false }
+        : { displayName: "Someone Outside Contacts", known: false };
+  }
+}
+
+/**
+ always returns text, maybe something like "unnamed" or "unknown"
+
+ Now that we're using more informational didInfoForContact under the covers, we might want to consolidate.
  **/
 export function didInfo(
   did: string | undefined,
@@ -363,19 +407,8 @@ export function didInfo(
   allMyDids: string[],
   contacts: Contact[],
 ): string {
-  if (!did) return "Someone Anonymous";
-
-  const contact = R.find((c) => c.did === did, contacts);
-  if (contact) {
-    return contact.name || "Contact With No Name";
-  } else {
-    const myId = R.find(R.equals(did), allMyDids);
-    return myId
-      ? `You${myId !== activeDid ? " (Alt ID)" : ""}`
-      : isHiddenDid(did)
-        ? "Someone Outside Your Network"
-        : "Someone Outside Contacts";
-  }
+  const contact = contactForDid(did, contacts);
+  return didInfoForContact(did, activeDid, contact, allMyDids).displayName;
 }
 
 /**