From 114627b218a6984a9ed0dc4f31f70bea395bc283 Mon Sep 17 00:00:00 2001
From: Matthew Raymer <matthew.raymer@anomalistdesign.com>
Date: Mon, 7 Jul 2025 07:02:33 +0000
Subject: [PATCH] Replace hardcoded notification strings with standardized
 constants
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Replace literal strings with notification constants in ContactsView.vue:
  * "Got an error sending the invite." → NOTIFY_INVITE_ERROR.message
  * "Could not set visibility on the server." → NOTIFY_VISIBILITY_ERROR.message
  * "Unconfirmed Hours" → NOTIFY_UNCONFIRMED_HOURS.title
- Remove unused NOTIFY_REGISTER_PROCESSING import
- Remove unused NOTIFICATION_TIMEOUTS constant in ShareMyContactInfoView.vue
- Fix unused parameter warnings in danger() and warning() methods
- Resolve all notification-related linting errors
---
 src/components/MembersList.vue               |  9 ++--
 src/components/TopMessage.vue                |  7 +--
 src/components/UserNameDialog.vue            |  1 -
 src/constants/notifications.ts               |  3 +-
 src/views/ClaimAddRawView.vue                | 12 ++---
 src/views/ContactGiftingView.vue             |  2 +-
 src/views/ContactImportView.vue              |  2 +-
 src/views/ContactsView.vue                   | 55 +++++---------------
 src/views/NewActivityView.vue                |  7 ++-
 src/views/ProjectViewView.vue                | 17 ++----
 src/views/RecentOffersToUserProjectsView.vue |  2 +-
 src/views/RecentOffersToUserView.vue         |  2 +-
 src/views/ShareMyContactInfoView.vue         | 11 +---
 13 files changed, 37 insertions(+), 93 deletions(-)

diff --git a/src/components/MembersList.vue b/src/components/MembersList.vue
index f29472c1..b2a0106b 100644
--- a/src/components/MembersList.vue
+++ b/src/components/MembersList.vue
@@ -211,7 +211,7 @@ interface DecryptedMember {
 })
 export default class MembersList extends Vue {
   $notify!: (notification: NotificationIface, timeout?: number) => void;
-  
+
   notify!: ReturnType<typeof createNotifyHelpers>;
   libsUtil = libsUtil;
 
@@ -231,7 +231,7 @@ export default class MembersList extends Vue {
 
   async created() {
     this.notify = createNotifyHelpers(this.$notify);
-    
+
     const settings = await this.$accountSettings();
     this.activeDid = settings.activeDid || "";
     this.apiServer = settings.apiServer || "";
@@ -505,10 +505,7 @@ export default class MembersList extends Vue {
       if (err instanceof Error && err.message?.indexOf("already exists") > -1) {
         message = "This person is already in your contact list.";
       }
-      this.notify.error(
-        message,
-        TIMEOUTS.LONG,
-      );
+      this.notify.error(message, TIMEOUTS.LONG);
     }
   }
 }
diff --git a/src/components/TopMessage.vue b/src/components/TopMessage.vue
index 24c2aa40..519a0585 100644
--- a/src/components/TopMessage.vue
+++ b/src/components/TopMessage.vue
@@ -40,7 +40,7 @@ export default class TopMessage extends Vue {
 
   async mounted() {
     this.notify = createNotifyHelpers(this.$notify);
-    
+
     try {
       // Ultra-concise cached settings loading - replaces 50+ lines of logic!
       const settings = await this.$accountSettings(undefined, {
@@ -62,10 +62,7 @@ export default class TopMessage extends Vue {
         this.message = "You are using prod, user " + didPrefix;
       }
     } catch (err: unknown) {
-      this.notify.error(
-        JSON.stringify(err),
-        TIMEOUTS.MODAL,
-      );
+      this.notify.error(JSON.stringify(err), TIMEOUTS.MODAL);
     }
   }
 }
diff --git a/src/components/UserNameDialog.vue b/src/components/UserNameDialog.vue
index 2aaabacd..f4d314ab 100644
--- a/src/components/UserNameDialog.vue
+++ b/src/components/UserNameDialog.vue
@@ -37,7 +37,6 @@
 <script lang="ts">
 import { Vue, Component, Prop } from "vue-facing-decorator";
 
-
 import { MASTER_SETTINGS_KEY } from "../db/tables/settings";
 import { PlatformServiceFactory } from "@/services/PlatformServiceFactory";
 import { PlatformServiceMixin } from "@/utils/PlatformServiceMixin";
diff --git a/src/constants/notifications.ts b/src/constants/notifications.ts
index ab9ee5ac..c8486e22 100644
--- a/src/constants/notifications.ts
+++ b/src/constants/notifications.ts
@@ -74,7 +74,8 @@ export const NOTIFY_VISIBILITY_REFRESHED = {
 // ContactsView.vue specific constants
 export const NOTIFY_BLANK_INVITE = {
   title: "Blank Invite",
-  message: "The invite was not included, which can happen when your iOS device cuts off the link. Try pasting the full link into a browser.",
+  message:
+    "The invite was not included, which can happen when your iOS device cuts off the link. Try pasting the full link into a browser.",
 };
 
 export const NOTIFY_INVITE_REGISTRATION_SUCCESS = {
diff --git a/src/views/ClaimAddRawView.vue b/src/views/ClaimAddRawView.vue
index b1390513..99d80dc7 100644
--- a/src/views/ClaimAddRawView.vue
+++ b/src/views/ClaimAddRawView.vue
@@ -103,7 +103,7 @@ export default class ClaimAddRawView extends Vue {
    */
   async mounted() {
     this.notify = createNotifyHelpers(this.$notify);
-    
+
     await this.initializeSettings();
     await this.loadClaimData();
   }
@@ -203,10 +203,7 @@ export default class ClaimAddRawView extends Vue {
       "Error retrieving claim: " + errorStringForLog(error),
       true,
     );
-    this.notify.error(
-      "Got an error retrieving claim data.",
-      TIMEOUTS.STANDARD,
-    );
+    this.notify.error("Got an error retrieving claim data.", TIMEOUTS.STANDARD);
   }
 
   /**
@@ -226,10 +223,7 @@ export default class ClaimAddRawView extends Vue {
       this.axios,
     );
     if (result.success) {
-      this.notify.success(
-        "Claim submitted.",
-        TIMEOUTS.LONG,
-      );
+      this.notify.success("Claim submitted.", TIMEOUTS.LONG);
     } else {
       logger.error("Got error submitting the claim:", result);
       this.notify.error(
diff --git a/src/views/ContactGiftingView.vue b/src/views/ContactGiftingView.vue
index 92798579..d2577b28 100644
--- a/src/views/ContactGiftingView.vue
+++ b/src/views/ContactGiftingView.vue
@@ -126,7 +126,7 @@ export default class ContactGiftingView extends Vue {
 
   async created() {
     this.notify = createNotifyHelpers(this.$notify);
-    
+
     try {
       const settings = await this.$accountSettings();
       this.apiServer = settings.apiServer || "";
diff --git a/src/views/ContactImportView.vue b/src/views/ContactImportView.vue
index 127bcc82..dd5d3f07 100644
--- a/src/views/ContactImportView.vue
+++ b/src/views/ContactImportView.vue
@@ -348,7 +348,7 @@ export default class ContactImportView extends Vue {
    */
   async created() {
     this.notify = createNotifyHelpers(this.$notify);
-    
+
     await this.initializeSettings();
     await this.processQueryParams();
     await this.processJwtFromPath();
diff --git a/src/views/ContactsView.vue b/src/views/ContactsView.vue
index 23c4c190..b239ab76 100644
--- a/src/views/ContactsView.vue
+++ b/src/views/ContactsView.vue
@@ -305,7 +305,6 @@ import {
   NOTIFY_INVITE_ERROR,
   NOTIFY_ONBOARDING_CONFIRM,
   NOTIFY_REGISTER_NOT_AVAILABLE,
-  NOTIFY_REGISTER_PROCESSING,
   NOTIFY_REGISTER_PERSON_SUCCESS,
   NOTIFY_REGISTER_PERSON_ERROR,
   NOTIFY_VISIBILITY_ERROR,
@@ -390,10 +389,7 @@ export default class ContactsView extends Vue {
 
   // Methods for template simplification
   showNotRegisteredWarning(): void {
-    this.notify.warning(
-      NOTIFY_REGISTER_NOT_AVAILABLE.message,
-      TIMEOUTS.LONG,
-    );
+    this.notify.warning(NOTIFY_REGISTER_NOT_AVAILABLE.message, TIMEOUTS.LONG);
   }
 
   toggleAllContacts(): void {
@@ -434,7 +430,7 @@ export default class ContactsView extends Vue {
 
   public async created() {
     this.notify = createNotifyHelpers(this.$notify);
-    
+
     const settingsRow = await this.$getSettingsRow([
       "activeDid",
       "apiServer",
@@ -490,10 +486,7 @@ export default class ContactsView extends Vue {
     const importedInviteJwt = this.$route.query["inviteJwt"] as string;
     if (importedInviteJwt === "") {
       // this happens when a platform (eg iOS) doesn't include anything after the "=" in a shared link.
-      this.notify.error(
-        NOTIFY_BLANK_INVITE.message,
-        TIMEOUTS.VERY_LONG,
-      );
+      this.notify.error(NOTIFY_BLANK_INVITE.message, TIMEOUTS.VERY_LONG);
     } else if (importedInviteJwt) {
       // make sure user is created
       if (!this.activeDid) {
@@ -560,7 +553,7 @@ export default class ContactsView extends Vue {
           response?: { data?: { error?: { message?: string } } };
           message?: string;
         };
-        let message: string = "Got an error sending the invite.";
+        let message: string = NOTIFY_INVITE_ERROR.message;
         if (err.response && err.response.data && err.response.data.error) {
           if (err.response.data.error.message) {
             message = err.response.data.error.message;
@@ -573,10 +566,7 @@ export default class ContactsView extends Vue {
         } else if (typeof err.message === "string") {
           message = err.message;
         }
-        this.notify.error(
-          message,
-          TIMEOUTS.MODAL,
-        );
+        this.notify.error(message, TIMEOUTS.MODAL);
       }
       // if we're here, they haven't redirected anywhere, so we'll redirect here without a query parameter
       this.$router.push({ path: "/contacts" });
@@ -587,14 +577,10 @@ export default class ContactsView extends Vue {
     return (contactName || AppString.NO_CONTACT_NAME).replace(/\s/g, "\u00A0");
   }
 
-  private danger(message: string, title: string = "Error", timeout = 5000) {
+  private danger(message: string, _title: string = "Error", timeout = 5000) {
     this.notify.error(message, timeout);
   }
 
-  private warning(message: string, title: string = "Error", timeout = 5000) {
-    this.notify.warning(message, timeout);
-  }
-
   private showOnboardingInfo() {
     this.notify.confirm(
       NOTIFY_ONBOARDING_CONFIRM.message,
@@ -703,10 +689,7 @@ export default class ContactsView extends Vue {
     } catch (error) {
       const fullError = "Error loading gives: " + errorStringForLog(error);
       logConsoleAndDb(fullError, true);
-      this.notify.error(
-        "Got an error loading your gives.",
-        TIMEOUTS.STANDARD,
-      );
+      this.notify.error("Got an error loading your gives.", TIMEOUTS.STANDARD);
     }
   }
 
@@ -929,10 +912,7 @@ export default class ContactsView extends Vue {
             }, 1000);
           }
         }
-        this.notify.success(
-          addedMessage,
-          TIMEOUTS.STANDARD,
-        );
+        this.notify.success(addedMessage, TIMEOUTS.STANDARD);
       })
       .catch((err) => {
         const fullError =
@@ -1002,10 +982,7 @@ export default class ContactsView extends Vue {
         userMessage = error as string;
       }
       // Now set that error for the user to see.
-      this.notify.error(
-        userMessage,
-        TIMEOUTS.MODAL,
-      );
+      this.notify.error(userMessage, TIMEOUTS.MODAL);
     }
   }
 
@@ -1037,11 +1014,8 @@ export default class ContactsView extends Vue {
         result,
       );
       const message =
-        (result.error as string) || "Could not set visibility on the server.";
-      this.notify.error(
-        message,
-        TIMEOUTS.LONG,
-      );
+        (result.error as string) || NOTIFY_VISIBILITY_ERROR.message;
+      this.notify.error(message, TIMEOUTS.LONG);
       return false;
     }
   }
@@ -1067,7 +1041,7 @@ export default class ContactsView extends Vue {
         {
           group: "modal",
           type: "confirm",
-          title: "Unconfirmed Hours",
+          title: NOTIFY_UNCONFIRMED_HOURS.title,
           text: message,
           onNo: async () => {
             this.showGiftedDialog(giverDid, recipientDid);
@@ -1223,10 +1197,7 @@ export default class ContactsView extends Vue {
     useClipboard()
       .copy(contactsJwtUrl)
       .then(() => {
-        this.notify.copied(
-          "contact link",
-          TIMEOUTS.STANDARD,
-        );
+        this.notify.copied("contact link", TIMEOUTS.STANDARD);
       });
   }
 
diff --git a/src/views/NewActivityView.vue b/src/views/NewActivityView.vue
index a090010a..fbcd7423 100644
--- a/src/views/NewActivityView.vue
+++ b/src/views/NewActivityView.vue
@@ -156,7 +156,10 @@ import EntityIcon from "../components/EntityIcon.vue";
 import { NotificationIface } from "../constants/app";
 import { Contact } from "../db/tables/contacts";
 import { Router } from "vue-router";
-import { OfferSummaryRecord, OfferToPlanSummaryRecord } from "../interfaces/records";
+import {
+  OfferSummaryRecord,
+  OfferToPlanSummaryRecord,
+} from "../interfaces/records";
 import {
   didInfo,
   displayAmount,
@@ -195,7 +198,7 @@ export default class NewActivityView extends Vue {
 
   async created() {
     this.notify = createNotifyHelpers(this.$notify);
-    
+
     try {
       const settings = await this.$accountSettings();
       this.apiServer = settings.apiServer || "";
diff --git a/src/views/ProjectViewView.vue b/src/views/ProjectViewView.vue
index c6395414..4af14f79 100644
--- a/src/views/ProjectViewView.vue
+++ b/src/views/ProjectViewView.vue
@@ -757,7 +757,7 @@ export default class ProjectViewView extends Vue {
    */
   async created() {
     this.notify = createNotifyHelpers(this.$notify);
-    
+
     const settings = await this.$accountSettings();
     this.activeDid = settings.activeDid || "";
     this.apiServer = settings.apiServer || "";
@@ -806,10 +806,7 @@ export default class ProjectViewView extends Vue {
     useClipboard()
       .copy(deepLink)
       .then(() => {
-        this.notify.copied(
-          "link to this project",
-          TIMEOUTS.SHORT,
-        );
+        this.notify.copied("link to this project", TIMEOUTS.SHORT);
       });
   }
 
@@ -1376,10 +1373,7 @@ export default class ProjectViewView extends Vue {
       this.axios,
     );
     if (result.success) {
-      this.notify.success(
-        "Confirmation submitted.",
-        TIMEOUTS.LONG,
-      );
+      this.notify.success("Confirmation submitted.", TIMEOUTS.LONG);
       this.recentlyCheckedAndUnconfirmableJwts = [
         ...this.recentlyCheckedAndUnconfirmableJwts,
         give.jwtId,
@@ -1389,10 +1383,7 @@ export default class ProjectViewView extends Vue {
       const message =
         (result.error as string) ||
         "There was a problem submitting the confirmation.";
-      this.notify.error(
-        message,
-        TIMEOUTS.LONG,
-      );
+      this.notify.error(message, TIMEOUTS.LONG);
     }
   }
 
diff --git a/src/views/RecentOffersToUserProjectsView.vue b/src/views/RecentOffersToUserProjectsView.vue
index e8f62573..c294d053 100644
--- a/src/views/RecentOffersToUserProjectsView.vue
+++ b/src/views/RecentOffersToUserProjectsView.vue
@@ -120,7 +120,7 @@ export default class RecentOffersToUserView extends Vue {
 
   async created() {
     this.notify = createNotifyHelpers(this.$notify);
-    
+
     try {
       const settings = await this.$accountSettings();
       this.apiServer = settings.apiServer || "";
diff --git a/src/views/RecentOffersToUserView.vue b/src/views/RecentOffersToUserView.vue
index 8db3e2a6..5996f7ce 100644
--- a/src/views/RecentOffersToUserView.vue
+++ b/src/views/RecentOffersToUserView.vue
@@ -112,7 +112,7 @@ export default class RecentOffersToUserView extends Vue {
 
   async created() {
     this.notify = createNotifyHelpers(this.$notify);
-    
+
     try {
       const settings = await this.$accountSettings();
       this.apiServer = settings.apiServer || "";
diff --git a/src/views/ShareMyContactInfoView.vue b/src/views/ShareMyContactInfoView.vue
index 748e0d40..741002d8 100644
--- a/src/views/ShareMyContactInfoView.vue
+++ b/src/views/ShareMyContactInfoView.vue
@@ -57,12 +57,6 @@ import { Account } from "@/db/tables/accounts";
 import { createNotifyHelpers, TIMEOUTS } from "@/utils/notify";
 
 // Constants for magic numbers
-const NOTIFICATION_TIMEOUTS = {
-  COPY_SUCCESS: 5000,
-  SHARE_CONTACTS: 10000,
-  ERROR: 5000,
-} as const;
-
 const DELAYS = {
   SHARE_CONTACTS_DELAY: 3000,
 } as const;
@@ -153,10 +147,7 @@ export default class ShareMyContactInfoView extends Vue {
    * Show success notifications after copying
    */
   private async showSuccessNotifications(): Promise<void> {
-    this.notify.copied(
-      "contact info",
-      TIMEOUTS.LONG,
-    );
+    this.notify.copied("contact info", TIMEOUTS.LONG);
 
     const numContacts = await this.$contactCount();
     if (numContacts > 0) {