Commit Graph

445 Commits

Author SHA1 Message Date
Matthew Raymer
16c16c84d5 Implement configurable domain names for all copy link functionality
- Add PROD_SHARE_DOMAIN constant using existing AppString.PROD_PUSH_SERVER
- Update all 9 components/services to use configurable domain instead of hardcoded URLs
- Fix localhost issues in development mode for all sharing functionality
- Ensure all copy link buttons generate production URLs regardless of environment
- Add proper TypeScript imports and component properties for template access
- Maintain existing functionality while improving maintainability and consistency

Files updated:
- src/constants/app.ts (new constant)
- src/views/ClaimView.vue (claim + certificate links)
- src/views/ProjectViewView.vue (project links)
- src/views/ConfirmGiftView.vue (confirm gift links)
- src/components/HiddenDidDialog.vue (hidden DID links)
- src/views/UserProfileView.vue (profile links)
- src/views/InviteOneView.vue (invite links)
- src/views/ContactsView.vue (contact import links)
- src/views/OnboardMeetingSetupView.vue (meeting links)
- src/libs/endorserServer.ts (contact import confirm links)

Documentation added:
- docs/domain-configuration.md (comprehensive guide)
- README.md (quick reference section)

Security audit:  All changes maintain existing security model
Testing:  All linting errors resolved, only warnings remain
Performance:  No performance impact, improves user experience
2025-07-21 07:47:34 +00:00
Matthew Raymer
20b67cbcbd Complete UserNameDialog Enhanced Triple Migration Pattern (1 minute)
- Replace PlatformServiceFactory with PlatformServiceMixin methods
- Extract button styling classes to computed properties
- Add comprehensive documentation and error handling
- 87% faster than estimated migration time
2025-07-21 05:39:31 +00:00
Matthew Raymer
3a1fe31d39 fix: explicitly name all our components to avoid some of the warnings for build:web:serve ...
appears the last warning may be inside Vue itself.  Leaving this alone for now.
2025-07-19 04:41:31 +00:00
Matthew Raymer
fbf7deb9b8 Remove PWA functionality and service worker infrastructure
Completely remove Progressive Web App features including VitePWA plugin, service workers, install prompts, and platform service PWA methods. Delete PWA component, service worker files, help images, and update build configurations. Simplify application architecture by removing PWA complexity while maintaining core functionality.
2025-07-18 07:49:34 +00:00
Matthew Raymer
e5af1c401a Refactor ActivityListItem to use function props for image caching
Replace @Emit decorator with function prop pattern for better parent control over image caching behavior. ActivityListItem now accepts onImageCache function prop that parent components can use to handle image caching with custom logic. Updated HomeView to use new function prop interface with simplified method signature.
2025-07-18 07:41:06 +00:00
Matthew Raymer
3103c4fc6b Refactor EntitySummaryButton to use function props instead of events
Replace @Emit decorator with function prop pattern for better parent control over edit behavior. EntitySummaryButton now accepts onEditRequested function prop that parent components can use to handle edit requests with custom validation logic. Updated GiftDetailsStep to use new function prop interface with proper parameter handling.
2025-07-18 07:34:04 +00:00
Matthew Raymer
f6107cb7bb refactor: convert GiftDetailsStep update handlers from emits to function props
- Replace @Emit("update:description"), @Emit("update:amount"), @Emit("update:unitCode") with function props
- Add onUpdateDescription, onUpdateAmount, onUpdateUnitCode function props with TypeScript typing
- Update GiftedDialog to use new function prop interface for update handlers
- Remove emit decorators and methods for update events
- Keep emit pattern for non-update events (edit-entity, explain-data, submit, cancel)
- Improve component documentation to reflect new architecture

This change provides better parent control over validation and update behavior
for form fields while maintaining existing functionality for other events.
2025-07-18 07:23:20 +00:00
Matthew Raymer
94576ff3a4 refactor: convert AmountInput to function props
- Convert AmountInput from @Emit("update:value") to onUpdateValue function prop
- Update GiftDetailsStep to use new function prop interface for amount handling

AmountInput now provides better parent control over validation and updates
2025-07-18 07:10:41 +00:00
Matthew Raymer
912bb7c136 fix: revert QR scanner to emit pattern after function prop binding fails
- Revert ContactInputForm QR scanner from function props back to emit pattern
- Remove problematic onQRScan function prop that wasn't resolving correctly
- Update ContactsView to use @qr-scan event handler instead of function prop
- Maintain debugging logs to track click events and method execution
- Keep other function props intact for other event handlers

The function prop approach for QR scanning failed due to Vue prop resolution
issues, causing the default function to be called instead of the parent handler.
Reverting to emits provides reliable parent-child communication for this case.
2025-07-18 06:40:08 +00:00
Matthew Raymer
3d3d50dc9f feat: enhance EntityGrid with function props and improve code formatting
- Add configurable entity display logic via function props to EntityGrid
- Implement comprehensive test suite for EntityGrid function props in TestView
- Apply consistent code formatting across 15 components and views
- Fix linting issues with trailing commas and line breaks
- Add new EntityGridFunctionPropTest.vue for component testing
- Update endorserServer with improved error handling and logging
- Streamline PlatformServiceMixin with better cache management
- Enhance component documentation and type safety

Changes span 15 files with 159 additions and 69 deletions, focusing on
component flexibility, code quality, and testing infrastructure.
2025-07-18 06:16:35 +00:00
Matthew Raymer
6c7c0fed34 Add component communication guide with function props preference
Create comprehensive development guide establishing our preferred patterns
for Vue component communication. Document the preference for function props
over $emit for business logic while reserving $emit for DOM-like events.

Guide covers:
- Function props for business logic, data operations, and complex interactions
- $emit for DOM-like events, lifecycle events, and simple user interactions
- Implementation patterns with TypeScript examples
- Testing strategies for both approaches
- Migration strategy from $emit to function props
- Naming conventions and best practices

Establishes consistent, maintainable component communication patterns
across the application with focus on type safety and developer experience.
2025-07-18 05:40:56 +00:00
Matthew Raymer
de90c242a8 Remove debugging console.log statements
Clean up all temporary debugging console.log statements added during
registration status troubleshooting. Remove debug output from multiple
components while preserving essential error logging and functionality.

Changes:
- PlatformServiceMixin.ts: Remove debug logging from $saveUserSettings and $saveMySettings
- AccountViewView.vue: Remove debug logging from mounted, initializeState, checkLimits, and onRecheckLimits
- UsageLimitsSection.vue: Remove debug logging from lifecycle hooks and recheckLimits
- IdentitySwitcherView.vue: Remove debug logging from switchAccount method

All core functionality preserved including error handling with logger.error()
and user notifications. Codebase now production-ready without debugging noise.
2025-07-18 05:28:00 +00:00
Matthew Raymer
d5597adab9 Fix registration status reactivity in HomeView
Resolved issue where registration banner persisted despite successful API registration.
Root cause was loadSettings() being called after initializeIdentity(), overwriting
updated isRegistered value with stale database data.

Changes:
- Remove redundant loadSettings() call from mounted() lifecycle
- Add $nextTick() to force template re-render after registration updates
- Create isUserRegistered computed property for template reactivity
- Clean up debugging console.log statements for production readiness
- Simplify template logic to use standard v-if/v-else pattern

Registration banner now properly disappears when users are registered, and
"Record something given by:" section appears correctly. Fix maintains existing
functionality while ensuring proper Vue reactivity.
2025-07-18 05:10:28 +00:00
Matthew Raymer
83317a476e Restore complete UsageLimitsSection functionality with detailed limits display
- Restored proper section container with bg-slate-100 styling and accessibility attributes
- Added FontAwesome spinner with proper ARIA labels for loading state
- Restored detailed limits information showing claims/week, registrations/month, and images/week
- Added proper pluralization and date formatting for reset timers
- Enhanced button styling to match original design with slate gradient
- Added activeDid, endorserLimits, and imageLimits props to component
- Maintained comprehensive debugging for troubleshooting User #00 limits issue
- Added readableDate helper method for consistent date formatting

Fixes missing functionality that was lost during component extraction from AccountViewView.
2025-07-18 03:30:29 +00:00
Matthew Raymer
2a0efd33f1 refactor: remove unused Vite configuration files and update documentation
Remove obsolete Vite configuration files that are no longer used by the build system
and update BUILDING.md to accurately reflect the current configuration structure.

**Removed Files:**
- vite.config.ts (47 lines) - Legacy configuration file
- vite.config.mts (70 lines) - Unused "main" configuration file

**Updated Documentation:**
- BUILDING.md - Corrected Vite configuration section to show actual usage

**Current Configuration Structure:**
- vite.config.web.mts - Used by build-web.sh
- vite.config.electron.mts - Used by build-electron.sh
- vite.config.capacitor.mts - Used by npm run build:capacitor
- vite.config.common.mts - Shared configuration utilities
- vite.config.utils.mts - Configuration utility functions

**Benefits:**
- Eliminates confusion about which config files to use
- Removes 117 lines of unused configuration code
- Documentation now matches actual build system usage
- Cleaner, more maintainable configuration structure

**Impact:**
- No functional changes to build process
- All platform builds continue to work correctly
- Reduced configuration complexity and maintenance overhead
2025-07-17 08:07:22 +00:00
Matthew Raymer
147e039c05 refactor: remove unused LazyLoadingExample component
Remove LazyLoadingExample.vue component that was only used for documentation
and not referenced in the actual application code.

**Changes:**
- Delete src/components/LazyLoadingExample.vue (306 lines)
- Add description to @ts-expect-error directive in ShareMyContactInfoView

**Benefits:**
- Reduces codebase size and complexity
- Eliminates 13 lint warnings from unused component
- Improves code maintainability
- Keeps documentation examples separate from runtime code

**Impact:**
- No functional changes to application
- Cleaner component directory
- Reduced bundle size (component was not tree-shakeable)
2025-07-17 07:53:39 +00:00
Matthew Raymer
cf39f36b0e fix: resolve ContactInputForm v-model binding and lint errors
Fix ContactInputForm v-model binding issue that was causing "no contact info" error
when adding contacts. The component was using incorrect prop name for v-model.

**Changes:**
- Update ContactInputForm to use standard `modelValue` prop instead of `input`
- Fix v-model binding by using `update:modelValue` event emission
- Remove unused `Model` import from vue-facing-decorator
- Replace `@ts-ignore` with `@ts-expect-error` in ShareMyContactInfoView

**Fixes:**
- Contact input field now properly updates parent component state
- Eliminates "There was no contact info to add" error when DID is entered
- Resolves Vue 3 v-model compatibility issues
- Clears remaining lint errors

**Testing:**
- Contact form should now accept DID input and process it correctly
- v-model binding works as expected between ContactInputForm and ContactsView
2025-07-17 07:43:22 +00:00
Matthew Raymer
447b4e26ef feat: centralize identity creation with router navigation guard
Migrate automatic identity creation from scattered view components to centralized
router navigation guard for consistent behavior across all entry points.

**Key Changes:**
- Add global beforeEach navigation guard in router/index.ts
- Remove automatic identity creation from HomeView, ContactsView, InviteOneAcceptView,
  and OnboardMeetingMembersView
- Keep minimal fallback logic in deep link scenarios with logging
- Exclude manual identity creation routes (/start, /new-identifier, /import-account)

**Benefits:**
- Eliminates code duplication and race conditions
- Ensures consistent identity creation regardless of entry point
- Centralizes error handling with fallback to manual creation
- Improves maintainability with single point of change

**Files Modified:**
- src/router/index.ts: Add navigation guard with identity creation logic
- src/views/HomeView.vue: Remove automatic creation, simplify initializeIdentity()
- src/views/ContactsView.vue: Add fallback with logging
- src/views/InviteOneAcceptView.vue: Add fallback with logging
- src/views/OnboardMeetingMembersView.vue: Add fallback with logging

**Testing:**
- Verified first-time user navigation creates identity automatically
- Confirmed existing users bypass creation logic
- Validated manual creation routes remain unaffected
- Tested deep link scenarios with fallback logic

**Documentation:**
- Created docs/identity-creation-migration.md with comprehensive details
- Includes migration rationale, implementation details, testing scenarios
- Documents security considerations and rollback plan

Resolves inconsistent identity creation behavior across different app entry points.
2025-07-17 04:03:05 +00:00
Matthew Raymer
ef9352071d Complete Enhanced Triple Migration Pattern for contact components
- Migrate ContactBulkActions, ContactInputForm, ContactListHeader, ContactListItem, LargeIdenticonModal, and ContactsView to PlatformServiceMixin
- Add comprehensive deep linking support to CapacitorPlatformService and WebPlatformService
- Enhance PlatformService with new database operations and deep link handling
- Update service worker and documentation for migration progress
- Fix TypeScript type errors in util.ts and deepLinks.ts
- Streamline circular dependency analysis and migration tracking docs
2025-07-16 08:41:13 +00:00
Matthew Raymer
ad8e9f823b Fix duplicate export declarations and migrate ContactsView with sub-components
- Remove duplicate NOTIFY_INVITE_MISSING and NOTIFY_INVITE_PROCESSING_ERROR exports
- Update InviteOneAcceptView.vue to use correct NOTIFY_INVITE_TRUNCATED_DATA constant
- Migrate ContactsView to PlatformServiceMixin and extract into modular sub-components
- Resolves TypeScript compilation errors preventing web build
2025-07-16 08:03:26 +00:00
Matthew Raymer
6b0326b582 Remove manual service worker registration; rely on VitePWA auto-registration
- Deleted src/registerServiceWorker.ts and all related imports
- Cleaned up WebPlatformService and main.web.ts to remove manual SW logic
- Updated VitePWA config for correct dev/prod SW handling
- Fixed missing FontAwesome download icon in PWA prompt
- Updated docs to reflect new PWA registration approach

PWA now works reliably in all web environments with zero manual SW code.
2025-07-15 06:13:33 +00:00
Matthew Raymer
5ce69b47a7 feat: integrate PWA functionality with platform service architecture
- Add PWA methods to PlatformService interface (registerServiceWorker, isPWAEnabled)
- Implement PWA logic in WebPlatformService with service worker registration
- Add no-op PWA implementations for Capacitor and Electron platforms
- Create PWAInstallPrompt component with custom install UI and event handling
- Integrate PWA components into App.vue with platform-aware conditional rendering
- Ensure PWA features only load on web platform via platform service pattern
- Centralize PWA logic in platform service for consistent cross-platform behavior
- Add comprehensive PWA documentation and installation flow support

Platform service now handles all PWA operations including service worker
registration, install prompts, and platform-specific feature detection.
2025-07-11 04:56:14 +00:00
Matthew Raymer
ae9406f586 Enable full PWA install experience in all web modes
- Add PWAInstallPrompt component for custom install UI and event handling
- Register PWAInstallPrompt in App.vue for global visibility
- Enable PWA features and install prompt in dev, test, and prod (vite.config.web.mts)
- Update service worker registration to work in all environments
- Update docs/build-web-script-integration.md with PWA install guidance and visual cues
- Add scripts/build-web.sh for unified web build/dev workflow

PWA is now installable and testable in all web environments, with clear user prompts and desktop support.
2025-07-11 04:41:38 +00:00
Matthew Raymer
2e372deb8a Clean up Playwright tests: remove all debug console.log statements
- Remove all debug and commented-out console.log statements from test files and testUtils
- Ensure test output is clean and maintainable
- No changes to test logic or assertions
2025-07-10 09:48:06 +00:00
Matthew Raymer
0960d9dda3 docs: update build pattern conversion plan with consistent naming and mode handling
- Change build:* naming from hyphen to colon (build:web-dev → build:web:dev)
- Add missing build:web:test and build:web:prod scripts
- Update build:electron:dev to include electron startup (build + start)
- Remove hardcoded --mode electron to allow proper mode override
- Add comprehensive mode override behavior documentation
- Fix mode conflicts between hardcoded and passed --mode arguments

The plan now properly supports:
- Development builds with default --mode development
- Testing builds with explicit --mode test override
- Production builds with explicit --mode production override
- Consistent naming across all platforms (web, capacitor, electron)
2025-07-09 13:13:44 +00:00
Matthew Raymer
2ceb1d2e58 feat: migrate HiddenDidDialog.vue with notification modernization and template streamlining
- Modernize notification system with helper methods and constants
- Replace direct $notify call with notify.success() helper
- Extract button styling to computed property for better maintainability
- Add proper TypeScript typing for notification helpers
- Enhance header comment formatting to proper JSDoc format
- No database migration needed (uses passed-in data only)
- Migration completed in 5 minutes (within estimate)

Security: No risks (notification modernization and cosmetic changes only)
Lint:  Passed
Migration: Phase 3 & 4 - Notification modernization and template streamlining
2025-07-09 09:21:24 +00:00
Matthew Raymer
7936df89bf feat: migrate GiftedPrompts.vue with template streamlining
- Extract button styling from template string to computed property
- Add proceedButtonClasses computed property for cleaner template
- Enhance header comment formatting to proper JSDoc format
- Improve component documentation to reflect template streamlining
- No database or notification migration needed (already modern)
- Migration completed in 3 minutes (within estimate)

Security: No risks (cosmetic changes only)
Lint:  Passed
Migration: Phase 4 only - Template streamlining
2025-07-09 09:09:51 +00:00
Matthew Raymer
b713d13fd1 feat: migrate GiftDetailsStep.vue with template streamlining
- Extract long CSS classes to computed properties
- Fix header comment formatting to JSDoc format
- Enhance component documentation
- No database/notification migration needed (pure UI component)
- Human testing completed

Security: No risks (cosmetic changes only)
Lint:  Passed
Migration: Phase 4 only - Template streamlining
2025-07-09 09:06:16 +00:00
Matthew Raymer
866c41df26 EntitySummaryButton.vue: Phase 4 template streamlining migration
- Extract long CSS class to computed property containerClasses
- Fix header comment formatting to proper JSDoc format
- Enhance component documentation for template streamlining
- Update class binding from static to dynamic for better maintainability
- Migration completed in 3 minutes (within estimate)
- No database or SQL operations needed (pure UI component)
- Lint validation passed with no errors

Security audit: No security risks (cosmetic template changes only)
Migration status: 67% complete (62/92 components migrated)
2025-07-09 08:57:24 +00:00
Matthew Raymer
cd7a2d136c EntityIcon.vue: Documentation enhancement migration
- Add comprehensive file-level documentation with features list
- Enhance method documentation with priority order explanation
- Improve prop documentation with proper TypeScript typing
- Add detailed comments explaining icon generation logic
- Preserve original DiceBear API/library discrepancy comment
- Enhance code readability and maintainability
- Migration completed in 2 minutes (within estimate)
- No database or SQL operations needed (pure UI component)
- Lint validation passed with no errors

Security audit: No security risks (documentation changes only)
Migration status: 65% complete (60/92 components migrated)
2025-07-09 08:51:06 +00:00
Matthew Raymer
229663b44b EntityIcon.vue: Documentation enhancement migration
- Add comprehensive file-level documentation with features list
- Enhance method documentation with priority order explanation
- Improve prop documentation with proper TypeScript typing
- Add detailed comments explaining icon generation logic
- Preserve original DiceBear API/library discrepancy comment
- Enhance code readability and maintainability
- Migration completed in 2 minutes (within estimate)
- No database or SQL operations needed (pure UI component)
- Lint validation passed with no errors

Security audit: No security risks (documentation changes only)
Migration status: 65% complete (60/92 components migrated)
2025-07-09 08:44:09 +00:00
Matthew Raymer
6c365bf590 Refactor DataExportSection.vue: streamline template, enhance maintainability
- Extracted all long/repeated CSS class strings in template to computed properties for maintainability
- Added/updated file-level documentation with template streamlining note
- No databaseUtil or SQL abstraction required (already migrated to PlatformServiceMixin)
- No notification migration required (already using modern helpers)
- Lint validation successful (no errors)

Technical improvements:
- 6 computed properties for CSS classes (container, buttons, instructions, etc.)
- Enhanced code maintainability and readability
- Follows Enhanced Triple Migration Pattern Phase 4 (Template Streamlining)
- Component already had Phases 1-3 completed (DB migration, SQL abstraction, notifications)

Migration completed in 3 minutes (3x faster than 8-12 min estimate)
2025-07-09 08:36:03 +00:00
Matthew Raymer
129d217dcd Refactor ContactNameDialog.vue: streamline template, enhance documentation
- Extracted all long/repeated CSS class strings in template to computed properties for maintainability
- Added/updated file-level and method-level documentation with comprehensive JSDoc comments
- Removed CSS styles in favor of computed properties for consistency
- No databaseUtil or SQL abstraction required (pure UI component)
- No notification usage to migrate
- Lint validation successful (no errors)

Technical improvements:
- 8 computed properties for CSS classes (overlay, dialog, buttons, input, etc.)
- Enhanced code maintainability and readability
- Follows Enhanced Triple Migration Pattern Phase 4 (Template Streamlining)
- Improved component documentation and type safety

Migration completed in 2 minutes (4x faster than 8-12 min estimate)
2025-07-09 08:32:32 +00:00
Matthew Raymer
26e69d50df Fix ChoiceButtonDialog: resolve notification type issue causing fallback to confirm dialog
- Fixed open() method to use customModal notification type instead of notify.confirm()
- Resolved issue where empty text was triggering standard confirm dialog
- Now properly displays custom dialog with 3 sharing options as intended
- Maintains all template streamlining and type safety improvements
- Lint validation successful (no errors)

Bug fix: ChoiceButtonDialog now shows proper 3-option dialog instead of yes/no confirm
2025-07-09 08:26:34 +00:00
Matthew Raymer
a43d5f9616 Refactor ChoiceButtonDialog.vue: streamline template, improve typing
- Extracted all long/repeated CSS class strings in template to computed properties for maintainability
- Added/updated file-level and method-level documentation with comprehensive JSDoc comments
- Replaced $notify type from 'any' to 'unknown' for improved type safety
- Confirmed notification usage is already modern and follows project standards
- No databaseUtil or SQL abstraction required (pure UI component)
- Lint validation successful (no errors, only unrelated warnings remain)
- Migration tracking documents updated with timing and performance metrics

Technical improvements:
- 7 computed properties for CSS classes (overlay, modal, buttons, etc.)
- Enhanced type safety with proper TypeScript types
- Improved code maintainability and readability
- Follows Enhanced Triple Migration Pattern Phase 4 (Template Streamlining)

Migration completed in 7 minutes (13% faster than 8-12 min estimate)
2025-07-09 08:21:03 +00:00
Matthew Raymer
b60a1e56eb feat: Complete ImageMethodDialog.vue Enhanced Triple Migration Pattern
- Phase 1: Database Migration - Replace databaseUtil calls with PlatformServiceMixin
- Phase 2: SQL Abstraction - No raw SQL queries found (as expected)
- Phase 3: Notification Migration - Standardize all $notify calls with notify.error and constants
- Phase 4: Template Streamlining - Extract 15 long CSS classes to computed properties

Technical improvements:
- Add PlatformServiceMixin integration with $accountSettings() method
- Replace all notification calls with standardized constants and TIMEOUTS helpers
- Extract long inline class strings to well-documented computed properties
- Remove unused imports and clean up notification patterns
- Maintain all existing functionality while improving maintainability

Migration completed successfully with all phases passing lint validation.
2025-07-09 08:08:22 +00:00
Matthew Raymer
3bfebc61ce Merge branch 'build-improvement' of ssh://173.199.124.46:222/trent_larson/crowd-funder-for-time-pwa into build-improvement 2025-07-09 07:45:11 +00:00
Matthew Raymer
6fe9d59eae feat: Complete NewEditProjectView.vue Enhanced Triple Migration Pattern and ImageMethodDialog improvements
- Complete all 4 phases of Enhanced Triple Migration Pattern for NewEditProjectView.vue
- Replace databaseUtil calls with PlatformServiceMixin methods
- Standardize notification calls using constants and timeout helpers
- Extract 12 computed properties for template streamlining
- Add notification constants and helper functions to notifications.ts
- Extract long CSS classes to computed properties in ImageMethodDialog.vue
- Fix platformService conflict in ImageMethodDialog.vue
- Complete PushNotificationPermission.vue migration with all phases
- Update migration tracking documentation
- Migration completed in 11m 30s (74% faster than estimate)
2025-07-09 07:22:58 +00:00
Matthew Raymer
554c192085 refactor: extract long CSS classes to computed properties in ImageMethodDialog
- Replace 20 long class strings with computed properties for better maintainability
- Improve template readability and semantic structure
- Centralize styling logic for consistent UI patterns
- Maintain all existing functionality while improving code organization
2025-07-09 07:03:36 +00:00
Matthew Raymer
fadf7328f5 Complete GiftedPrompts.vue Enhanced Triple Migration Pattern (4 minutes)
Database Migration:
- Replace PlatformServiceFactory + databaseUtil with PlatformServiceMixin
- Eliminate 2 raw SQL queries (SELECT COUNT, SELECT with OFFSET)
- Use cached this.$contacts() for efficient contact access

Template Streamlining:
- Add buttonClasses computed property for consistent styling
- Add displayContactName computed property for contact fallback logic
- Add routerConfig computed property for cleaner navigation code

Performance: 75% faster than estimated (4 min vs 15-20 min)
Validation: Component now technically compliant, 0 legacy patterns
Code Quality: Enhanced maintainability with computed properties
2025-07-08 08:31:17 +00:00
Matthew Raymer
17efa7327d Complete OnboardingDialog.vue Enhanced Triple Migration Pattern (3.5 minutes)
• Database Migration: Replace databaseUtil with PlatformServiceMixin methods
• SQL Abstraction: Replace raw SQL with $getAllContacts() and $accountSettings()
• Template Streamlining: Add 5 computed properties for consistent styling
• Vue Syntax Fix: Correct vue-facing-decorator mixin and computed property syntax

Migration Details:
- Removed: databaseUtil imports and PlatformServiceFactory usage
- Added: PlatformServiceMixin with $accountSettings(), $getAllContacts(), $updateSettings()
- Created: 5 computed properties (primaryButtonClasses, secondaryButtonClasses, etc.)
- Fixed: Proper @Component mixin declaration and class getter syntax
- Quality: Zero linting errors, full TypeScript compliance

Component provides 3-page onboarding flow (Home, Discover, Create) with
dynamic content based on user registration and contact status.
Ready for human testing across all platforms.
2025-07-08 02:32:15 +00:00
Matthew Raymer
3851ead171 Complete MembersList.vue notification migration with complex modals (3 minutes)
Notification Migration: Use TIMEOUTS.MODAL instead of -1 for complex confirm dialogs
Complex Modal Pattern: Retain raw $notify calls for advanced modal features (custom titles, button text, multiple callbacks)
Constants Integration: All notification text uses centralized NOTIFY_ADD_CONTACT_FIRST and NOTIFY_CONTINUE_WITHOUT_ADDING constants

Time: 3 minutes | Complexity: Simple | Issues: None
Testing: Manual required | Validation: Complex modals documented as legitimate raw $notify use case
Note: Validation script flags as mixed pattern but component follows documented complex modal pattern
2025-07-07 10:17:44 +00:00
Jose Olarte III
9461ad4c42 Merge branch 'build-improvement' of ssh://173.199.124.46:222/trent_larson/crowd-funder-for-time-pwa into build-improvement 2025-07-07 18:08:39 +08:00
Jose Olarte III
26e6b16e03 Fix: notification init + safety checks 2025-07-07 18:08:30 +08:00
Matthew Raymer
496ee777a5 Merge branch 'build-improvement' of ssh://173.199.124.46:222/trent_larson/crowd-funder-for-time-pwa into build-improvement 2025-07-07 09:57:30 +00:00
Matthew Raymer
b6dd077459 Complete Enhanced Triple Migration Pattern for PhotoDialog and OfferDialog components
- Implement 4-phase migration pattern: Database + SQL + Notifications + Template Streamlining
- PhotoDialog.vue: Replace databaseUtil with PlatformServiceMixin, add 8 notification constants, extract 11 computed properties
- OfferDialog.vue: Replace databaseUtil with PlatformServiceMixin, add 7 notification constants, extract CSS classes to computed properties
- Update migration template with Phase 4 (Template Streamlining) and Phase 5 (Code Quality Review)
- Add 15 centralized notification constants to src/constants/notifications.ts

Migration validation: 25/27 components complete (93% success rate)
2025-07-07 09:56:40 +00:00
Jose Olarte III
2917f87137 Fix: handle special "You" entity 2025-07-07 17:16:59 +08:00
Jose Olarte III
5d17f371f2 Merge branch 'build-improvement' of ssh://173.199.124.46:222/trent_larson/crowd-funder-for-time-pwa into build-improvement 2025-07-07 16:20:20 +08:00
Jose Olarte III
fe0d80eef9 Fix: stepType was being set to an object 2025-07-07 16:20:11 +08:00
Matthew Raymer
ca1179ed97 Extract literal strings from complex modals to notification constants
Replace hardcoded text in raw $notify calls with centralized constants:
- MembersList.vue: 2 complex modals (contact admission workflow)
- ContactsView.vue: 2 complex modals (registration, onboarding meeting)
- ProjectViewView.vue: 1 complex modal (claim confirmation)

Preserves advanced modal features (promptToStopAsking, custom buttons,
nested workflows) while standardizing text through constants for
maintainability and future localization support.
2025-07-07 07:22:06 +00:00