Browse Source

fix error editing an offer, tweak tests to fix red in IntelliJ

Trent Larson 3 months ago
parent
commit
a8bb1b46c2
  1. 2
      src/views/OfferDetailsView.vue
  2. 4
      test-playwright/20-create-project.spec.ts
  3. 14
      test-playwright/30-record-gift.spec.ts
  4. 4
      test-playwright/40-add-contact.spec.ts
  5. 4
      test-playwright/50-record-offer.spec.ts

2
src/views/OfferDetailsView.vue

@ -275,7 +275,7 @@ export default class OfferDetailsView extends Vue {
// find any project ID // find any project ID
let project; let project;
if ( if (
this.prevCredToEdit?.claim?.itemOffered?.isPartOf["@type"] === this.prevCredToEdit?.claim?.itemOffered?.isPartOf?.["@type"] ===
"PlanAction" "PlanAction"
) { ) {
project = this.prevCredToEdit?.claim?.itemOffered?.isPartOf; project = this.prevCredToEdit?.claim?.itemOffered?.isPartOf;

4
test-playwright/20-create-project.spec.ts

@ -12,8 +12,8 @@ test('Create new project, then search for it', async ({ page }) => {
const finalRandomString = randomString.substring(0, 16); const finalRandomString = randomString.substring(0, 16);
// Standard texts // Standard texts
const standardTitle = "Idea "; const standardTitle = 'Idea ';
const standardDescription = "Description of Idea "; const standardDescription = 'Description of Idea ';
// Combine texts with the random string // Combine texts with the random string
const finalTitle = standardTitle + finalRandomString; const finalTitle = standardTitle + finalRandomString;

14
test-playwright/30-record-gift.spec.ts

@ -2,23 +2,17 @@ import { test, expect } from '@playwright/test';
import { importUser } from './testUtils'; import { importUser } from './testUtils';
test('Record something given', async ({ page }) => { test('Record something given', async ({ page }) => {
// Generate a random string of 16 characters // Generate a random string of 3 characters
let randomString = Math.random().toString(36).substring(2, 18); const randomString = Math.random().toString(36).substring(2, 5);
// In case the string is shorter than 16 characters, generate more characters until it is 16 characters long
while (randomString.length < 16) {
randomString += Math.random().toString(36).substring(2, 18);
}
const finalRandomString = randomString.substring(0, 16);
// Generate a random non-zero single-digit number // Generate a random non-zero single-digit number
const randomNonZeroNumber = Math.floor(Math.random() * 99) + 1; const randomNonZeroNumber = Math.floor(Math.random() * 99) + 1;
// Standard title prefix // Standard title prefix
const standardTitle = "Gift "; const standardTitle = 'Gift ';
// Combine title prefix with the random string // Combine title prefix with the random string
const finalTitle = standardTitle + finalRandomString; const finalTitle = standardTitle + randomString;
// Import user 00 // Import user 00
await importUser(page, '00'); await importUser(page, '00');

4
test-playwright/40-add-contact.spec.ts

@ -15,7 +15,7 @@ test('Add contact, record gift, confirm gift', async ({ page }) => {
const randomNonZeroNumber = Math.floor(Math.random() * 99) + 1; const randomNonZeroNumber = Math.floor(Math.random() * 99) + 1;
// Standard title prefix // Standard title prefix
const standardTitle = "Gift "; const standardTitle = 'Gift ';
// Combine title prefix with the random string // Combine title prefix with the random string
const finalTitle = standardTitle + finalRandomString; const finalTitle = standardTitle + finalRandomString;
@ -51,7 +51,7 @@ test('Add contact, record gift, confirm gift', async ({ page }) => {
// Record something given by new contact // Record something given by new contact
await page.getByRole('heading', { name: contactName }).click(); await page.getByRole('heading', { name: contactName }).click();
await page.getByPlaceholder('What was given').fill(finalTitle); await page.getByPlaceholder('What was given').fill(finalTitle);
await page.getByRole('spinbutton', { id: 'inputGivenAmount' }).fill(randomNonZeroNumber.toString()); await page.getByRole('spinbutton').fill(randomNonZeroNumber.toString());
await page.getByRole('button', { name: 'Sign & Send' }).click(); await page.getByRole('button', { name: 'Sign & Send' }).click();
await expect(page.getByText('That gift was recorded.')).toBeVisible(); await expect(page.getByText('That gift was recorded.')).toBeVisible();

4
test-playwright/50-record-offer.spec.ts

@ -2,8 +2,8 @@ import { test, expect } from '@playwright/test';
import { importUser } from './testUtils'; import { importUser } from './testUtils';
test('Record an offer', async ({ page }) => { test('Record an offer', async ({ page }) => {
// Generate a random string of 6 characters, skipping the "0." at the beginning // Generate a random string of 3 characters, skipping the "0." at the beginning
const randomString = Math.random().toString(36).substring(2, 8); const randomString = Math.random().toString(36).substring(2, 5);
// Standard title prefix // Standard title prefix
const finalTitle = `Offering of ${randomString}`; const finalTitle = `Offering of ${randomString}`;
const randomNonZeroNumber = Math.floor(Math.random() * 998) + 1; const randomNonZeroNumber = Math.floor(Math.random() * 998) + 1;

Loading…
Cancel
Save