From 56e34408755d1b14d82b921e991492fdf0dff035 Mon Sep 17 00:00:00 2001 From: Trent Larson Date: Mon, 12 Aug 2024 18:51:41 -0600 Subject: [PATCH] misc commentary --- CHANGELOG.md | 2 +- README.md | 2 ++ playwright.config-local.ts | 2 +- src/registerServiceWorker.ts | 1 + vite.config.mjs | 2 +- 5 files changed, 6 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1650cf703..3413c4d7d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). -## [0.3.18] - 2024.07.12 +## ? ### Fixed - List of offers wasn't showing. diff --git a/README.md b/README.md index c4350bc0b..c64fd0898 100644 --- a/README.md +++ b/README.md @@ -39,6 +39,8 @@ npm run lint * Update the ClickUp tasks & CHANGELOG.md & the version in package.json, run `npm install`. +* Commit everything (since the commit hash is used the app). + * Record what version is currently on production. * Run the correct build: diff --git a/playwright.config-local.ts b/playwright.config-local.ts index ff9f647a0..02f0ae318 100644 --- a/playwright.config-local.ts +++ b/playwright.config-local.ts @@ -86,7 +86,7 @@ export default defineConfig({ * }, * * But if we do then the testInfo.config.webServer is null and the API-setting test 00 fails. - * It is worth considering a change such that Time Safari's default Endorer API server is NOT set + * It is worth considering a change such that Time Safari's default Endorser API server is NOT set * in the user's settings so that it can be blanked out and the default is used. */ webServer: { diff --git a/src/registerServiceWorker.ts b/src/registerServiceWorker.ts index 6a4985823..ba7d8a5fe 100644 --- a/src/registerServiceWorker.ts +++ b/src/registerServiceWorker.ts @@ -2,6 +2,7 @@ import { register } from "register-service-worker"; +// NODE_ENV is "production" by default with "vite build". See https://vitejs.dev/guide/env-and-mode if (import.meta.env.NODE_ENV === "production") { register("/sw_scripts-combined.js", { ready() { diff --git a/vite.config.mjs b/vite.config.mjs index 4e60ee08f..aa55e11e0 100644 --- a/vite.config.mjs +++ b/vite.config.mjs @@ -16,7 +16,7 @@ export default defineConfig({ srcDir: '.', filename: 'sw_scripts-combined.js', manifest: { - // This is used for the app name. It doesn't include a space, because iOS complains if i recall correctly. + // This is used for the app name. It doesn't include a space, because iOS complains if I recall correctly. // There is a name with spaces in the constants/app.js file for use internally. name: process.env.TIME_SAFARI_APP_TITLE || require('./package.json').name, short_name: process.env.TIME_SAFARI_APP_TITLE || require('./package.json').name,